On Thu, 26 Sep 2019, Lars Kurth wrote:
> From: Lars Kurth
>
> This document highlights what reviewers such as maintainers and committers
> look
> for when reviewing code. It sets expectations for code authors and provides
> a framework for code reviewers.
I think the document is missing a coupl
On Thu, 26 Sep 2019, Lars Kurth wrote:
> From: Lars Kurth
>
> This guide provides Best Practice on identifying and resolving
> common classes of disagreement
>
> Signed-off-by: Lars Kurth
> --
> Cc: minios-de...@lists.xenproject.org
> Cc: xen-...@lists.xenproject.org
> Cc: win-pv-de...@lists.xe
On Thu, 26 Sep 2019, Lars Kurth wrote:
> From: Lars Kurth
>
> This guide covers the bulk on Best Practice related to code review
> It primarily focusses on code review interactions
> It also covers how to deal with Misunderstandings and Cultural
> Differences
>
> Signed-off-by: Lars Kurth
> ---
On Fri, 27 Sep 2019, Jan Beulich wrote:
> On 26.09.2019 21:39, Lars Kurth wrote:
> > +### Verbose vs. terse
> > +Due to the time it takes to review and compose code reviewer, reviewers
> > often adopt a
> > +terse style. It is not unusual to see review comments such as
> > +> typo
> > +> s/resions
