Re: [MirageOS-devel] Query about mirage-tcpip and checksums

2015-11-23 Thread Richard Mortier
On 23 November 2015 at 13:20, Hannes Mehnert wrote: > On 11/23/2015 11:39, Richard Mortier wrote: >> Ah, thanks! >> >> Any objections if I paste this into an issue (and perhaps make >> reference to it in a comment in the code)? > > there's some discussion on https://github.com/mirage/mirage/pull/2

Re: [MirageOS-devel] Query about mirage-tcpip and checksums

2015-11-23 Thread Hannes Mehnert
On 11/23/2015 11:39, Richard Mortier wrote: > Ah, thanks! > > Any objections if I paste this into an issue (and perhaps make > reference to it in a comment in the code)? there's some discussion on https://github.com/mirage/mirage/pull/286 and https://github.com/mirage/mirage-tcpip/pull/111 ... mi

Re: [MirageOS-devel] Query about mirage-tcpip and checksums

2015-11-23 Thread Richard Mortier
Ah, thanks! Any objections if I paste this into an issue (and perhaps make reference to it in a comment in the code)? On 20 November 2015 at 21:38, Balraj Singh wrote: > The short answer is that the checksum is assumed to have been verified > before the packet is handed to the Mirage stack. > >

Re: [MirageOS-devel] Query about mirage-tcpip and checksums

2015-11-20 Thread Balraj Singh
The short answer is that the checksum is assumed to have been verified before the packet is handed to the Mirage stack. The problem with doing an additional redundant verification in Mirage is that when two local VMs are talking then the Xen driver, which has offered checksum offload, does not do

[MirageOS-devel] Query about mirage-tcpip and checksums

2015-11-20 Thread Richard Mortier
One of my undergraduate students who's doing a project with MirageOS and the TCP/IP stack in particular asked a question that I couldn't immediately answer -- wondered if someone else could :) Specifically, https://github.com/mirage/mirage-tcpip/blob/master/tcp/pcb.ml#L99 appears to define `verify