Re: Patch for a little install.sub bug

2013-08-25 Thread Alexander Hall
On 08/25/13 10:18, Alexander Hall wrote: On 08/25/13 01:39, Loïc BLOT wrote: A better patch could be: ask_which "speed" "should $_d use" \ "9600 19200 38400 57600 115200" ${CSPEED:-""} That would be "9600 19200 38400 57600 115200" "$CSPEED" in my world. ;-) but this patch is

Re: Patch for a little install.sub bug

2013-08-25 Thread Alexander Hall
On 08/25/13 01:39, Loïc BLOT wrote: In fact i'm not tired, it's logical :) Here is my patched question: ask_which "speed" "should $_d use" \ "9600 19200 38400 57600 115200" $CSPEED $pxe_console_speed Show: [auto] instead if [9600] (auto is value of pxe_console_speed). If i do a echo "spee

Re: Patch for a little install.sub bug

2013-08-24 Thread Loïc BLOT
In fact i'm not tired, it's logical :) Here is my patched question: ask_which "speed" "should $_d use" \ "9600 19200 38400 57600 115200" $CSPEED $pxe_console_speed Show: [auto] instead if [9600] (auto is value of pxe_console_speed). If i do a echo "speed: $CSPEED" before ask_which, CSPEED is

Re: Patch for a little install.sub bug

2013-08-24 Thread Loïc BLOT
Hmm you are right, i think i'm tired :) -- Best regards, Loïc BLOT, UNIX systems, security and network expert http://www.unix-experience.fr Le samedi 24 août 2013 à 23:03 +, Christian Weisgerber a écrit : > Loïc BLOT wrote: > > > if [[ $resp == y ]]; then > >

Re: Patch for a little install.sub bug

2013-08-24 Thread Christian Weisgerber
Loïc BLOT wrote: > if [[ $resp == y ]]; then > ask_which "speed" "should $_d use" \ > "9600 19200 38400 57600 115200" $CSPEED > case $resp in > done) defcons=n ;; >

Patch for a little install.sub bug

2013-08-24 Thread Loïc BLOT
Hello, this evening i was writing pxe automated install modifications on install.sh and install.sub when i found a bug in installer, when the console speed is asked. Original (5.3): if [[ -n $CDEV ]]; then _d=${CPROM:-$CDEV} ask_yn "Change the default console to $_d