The constant MFSNAMELEN as defined in: 

lib/libc/sys/getfsstat.2:#define MFSNAMELEN   16 
lib/libc/sys/statfs.2:#define MFSNAMELEN   16
sys/sys/mount.h: #define MFSNAMELEN      16

defines the fs type name and, according to comments, it includes nul 
terminating character.

 The following code makes uses of strncpy and involves MFSNAMELEN

./sys/kern/vfs_subr.c:225:      strncpy(mp->mnt_stat.f_fstypename, 
vfsp->vfc_name, MFSNAMELEN);
./sys/kern/vfs_subr.c:2272:     strncpy(sbp->f_fstypename, 
mp->mnt_vfc->vfc_name, MFSNAMELEN);
./sys/kern/vfs_syscalls.c:243:  strncpy(mp->mnt_stat.f_fstypename, 
vfsp->vfc_name, MFSNAMELEN);
./sys/miscfs/procfs/procfs_vfsops.c:190:        strncpy(sbp->f_fstypename, 
mp->mnt_vfc->vfc_name, MFSNAMELEN);
./sys/msdosfs/msdosfs_vfsops.c:669:     strncpy(sbp->f_fstypename, 
mp->mnt_vfc->vfc_name, MFSNAMELEN);
./sys/nfs/nfs_vfsops.c:646:     strncpy(&mp->mnt_stat.f_fstypename[0], 
mp->mnt_vfc->vfc_name, MFSNAMELEN);
./sys/ntfs/ntfs_vfsops.c:628:   strncpy(sbp->f_fstypename, 
mp->mnt_vfc->vfc_name, MFSNAMELEN);
./sys/ufs/ext2fs/ext2fs_vfsops.c:704:   strncpy(sbp->f_fstypename, 
mp->mnt_vfc->vfc_name, MFSNAMELEN);
./sys/ufs/mfs/mfs_vfsops.c:222: strncpy(&sbp->f_fstypename[0], 
mp->mnt_vfc->vfc_name, MFSNAMELEN);


Can be those replace safely by strlcpy without any modification to MFSNAMELEN 
constant? 

Reply via email to