Right now mixxx handles toggling pushbuttons itself. It listens only
for a note-on event, and toggles the state of the value.
However, I have a Korg nanoKontrol, and it has the ability to create its
own toggling pushbuttons. When a button is in that mode, one push emits
note on, and the next push emits note-off.
The reason this is a problem is that the korg toggling behavior is
incompatible with mixxx's. I could just set the korg to have
non-toggling buttons, but then the buttons don't stay lit when they are
toggled on. (And, the korg doesn't have controls to light up the
lights, so I can't script it)
would it make sense to change the mixxx toggle behavior to this?
if (currentvalue == false && c == NOTE_ON)
currentvalue = true;
else if (currentvalue == true && c == NOTE_OFF)
currentvalue = false;
this would work for either button behavior. The only flaw I can see is
that with a standard non-toggling midi control, the toggle doesn't turn
off until the user lifts their finger off the button.
This is somewhat relevant to my vinyl branch, in which the vinylcontrol
pushbutton is currently not a toggling button, but it should be. Since
I'm using my korg, keeping it as a non-toggle button makes sense for me
and no one else.
Owen
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
