Re: [Mixxx-devel] ControlObject and ControlDoublePrivate overview

2015-01-16 Thread Ferran Pujol Camins
Now I have Mixxx showing hotcue names in main waveform. I think this modification alone is not ready to trunk. There's some usability inconsistencies and things to improve to deliver a better cue point experience. I keep a list of all of them here: Cuepoins-2.0 Blueprint

Re: [Mixxx-devel] ControlObject and ControlDoublePrivate overview

2015-01-16 Thread RJ Ryan
On Fri, Jan 16, 2015 at 6:56 AM, Ferran Pujol Camins < ferranpujolcam...@gmail.com> wrote: > Thank you RJ, I have a first working version, however, WaveformRenderMark > now inherits from QObject. Who should its parent be? It can have a NULL parent since renderers are created in the main thread (

Re: [Mixxx-devel] ControlObject and ControlDoublePrivate overview

2015-01-16 Thread Ferran Pujol Camins
That's cool. Could you please have a look at my previous mail regarding WaveformRenderMark's parent? 2015-01-16 18:41 GMT+01:00 RJ Ryan : > Nope, any number. And we support 37 hotcues in the engine (which is > totally arbitrary but we have to pre-instantiate the COs for now so we have > to have s

Re: [Mixxx-devel] ControlObject and ControlDoublePrivate overview

2015-01-16 Thread RJ Ryan
Nope, any number. And we support 37 hotcues in the engine (which is totally arbitrary but we have to pre-instantiate the COs for now so we have to have some limit). On Fri, Jan 16, 2015 at 9:35 AM, Ferran Pujol Camins < ferranpujolcam...@gmail.com> wrote: > Also, is there a limit on how many save

Re: [Mixxx-devel] ControlObject and ControlDoublePrivate overview

2015-01-16 Thread Ferran Pujol Camins
Also, is there a limit on how many saved cues (not hotcues but cues) a track can have? 2015-01-16 15:56 GMT+01:00 Ferran Pujol Camins : > Thank you RJ, I have a first working version, however, WaveformRenderMark > now inherits from QObject. Who should its parent be? > > 2015-01-13 16:59 GMT+01:0

Re: [Mixxx-devel] ControlObject and ControlDoublePrivate overview

2015-01-16 Thread Ferran Pujol Camins
Thank you RJ, I have a first working version, however, WaveformRenderMark now inherits from QObject. Who should its parent be? 2015-01-13 16:59 GMT+01:00 RJ Ryan : > Hi Ferran, > > You should follow the waveform renderers and overload > WaveformWidgetRendererAbstract::onSetTrack(): > > https://gi