Re: [Mixxx-devel] Code refactoring

2011-02-01 Thread Mika Haulo
On Feb 1, 2011, at 11:33 AM, Albert Santoni wrote: > On Mon, Jan 31, 2011 at 11:19 PM, Tobias Rafreider > wrote: >> Mika, you'll definitely run into merge conflicts. A lot of library >> improvements have been done in the 'tree_item_browser' branch. Once, we >> merge this into trunk for 1.10 some

Re: [Mixxx-devel] Code refactoring

2011-02-01 Thread Albert Santoni
On Mon, Jan 31, 2011 at 11:19 PM, Tobias Rafreider wrote: > Mika, you'll definitely run into merge conflicts. A lot of library > improvements have been done in the 'tree_item_browser' branch. Once, we > merge this into trunk for 1.10 some refactoring may be a good idea. In the meantime, he could

Re: [Mixxx-devel] Code refactoring

2011-01-31 Thread Tobias Rafreider
Mika, you'll definitely run into merge conflicts. A lot of library improvements have been done in the 'tree_item_browser' branch. Once, we merge this into trunk for 1.10 some refactoring may be a good idea. Regards, Tobias Am 01.02.11 00:24, schrieb Mika Haulo: > Merge-hell is certainly someth

Re: [Mixxx-devel] Code refactoring

2011-01-31 Thread Mika Haulo
Merge-hell is certainly something that should be avoided. The plan is to work on the library code for now, and as RJ said, it shouldn't cause problems. Any other refactoring would be another task. On Feb 1, 2011, at 12:51 AM, Sean M. Pappalardo - D.J. Pegasus wrote: > > > On 01/31/2011 11:46

Re: [Mixxx-devel] Code refactoring

2011-01-31 Thread Sean M. Pappalardo - D.J. Pegasus
On 01/31/2011 11:46 PM, RJ Ryan wrote: > The main reason against refactoring too much is that you may cause > merge-hell for the 20 or so outstanding branches > that will be looking to merge to trunk > in the near future. With that said, you could continue to wo

Re: [Mixxx-devel] Code refactoring

2011-01-31 Thread RJ Ryan
Hey Mika, The main reason against refactoring too much is that you may cause merge-hell for the 20 or so outstanding branchesthat will be looking to merge to trunk in the near future. If you stick to the library code, there shouldn't be too many problems in that ar

[Mixxx-devel] Code refactoring

2011-01-31 Thread Mika Haulo
Hey guys, It looks like the code in *feature classes (crate, playlist, brower etc.) has become a little bit messy and there is a lot of unncessary duplicate code. I think that code should be cleaned up. Not only it makes sense in general, but a clean codebase is also much more pleasant for any