Re: [Mixxx-devel] Patch for search functionality on mixxx 1.8

2010-05-10 Thread Owen Williams
While we're at it, I often search on the comments and file path. Can we add those fields too? And finally, it would be nice if space-separated terms were ANDed together in the search. I implemented this behavior in my own 1.7 branch, but didn't get around to changing the newer sqlite code. than

Re: [Mixxx-devel] Patch for search functionality on mixxx 1.8

2010-05-10 Thread RJ Ryan
Hi Graeme, Thanks for the patch -- I agree that it's an oversight that we only search artist/title. Also, Josh is correct -- adjacent string literals are joined into one, it's just a nice trick to keep the lines 80 columns clean. Cheers, RJ Ryan On Mon, May 10, 2010 at 6:54 PM, gra...@salsaholic

Re: [Mixxx-devel] Patch for search functionality on mixxx 1.8

2010-05-10 Thread Josh Matthews
C++ will concatenate adjacent constant strings at compile-time, which is far more efficient than using run-time string object concatenation. Cheers, Josh On 10 May 2010 18:54, gra...@salsaholics.org wrote: > I often search for tracks by album name - not just artist and title. This > patch > exte

[Mixxx-devel] Patch for search functionality on mixxx 1.8

2010-05-10 Thread gra...@salsaholics.org
I often search for tracks by album name - not just artist and title. This patch extends the search functionality to include album name. I noticed a plus was missing in old code. Does C++ cope with this itself? or was this an undiscovered bug? Regards Graeme # Bazaar merge directive format 2 (