Re: [Mixxx-devel] Patch to remove compile warnings

2013-01-12 Thread Owen Williams
This type of big churning patch would be a candidate for a trunk commit (as opposed to 1.11) since it's going to cause tons of merge problems in other branches. O n Sat, 2013-01-12 at 13:55 +0100, Max Linke wrote: > Hi > > I made a patch to remove the compiler warnings and clean up the code a >

Re: [Mixxx-devel] Patch to remove compile warnings

2013-01-12 Thread Daniel Schürmann
Hi Max Thank you for your diligence work! Can you please file a bug and attach you patch there? It better to track it there. Can you explain you changes to mixxx/src/controllers/controllerlearningeventfilter.cpp? Else the patch looks good to me. I agree to Owen, this is a candidate for lp:mixxx

Re: [Mixxx-devel] Patch to remove compile warnings

2013-01-17 Thread Max Linke
Hi I filed bug for this. https://bugs.launchpad.net/mixxx/+bug/1100898 best Max On Sat, 12 Jan 2013 22:29:11 +0100 Daniel Schürmann wrote: > Hi Max > > Thank you for your diligence work! > > Can you please file a bug and attach you patch there? > It better to track it there. > > Can you ex