[Mixxx-devel] small patch to fix some deletes

2012-12-08 Thread Owen Williams
I found some objects that were leaking, as well as an issue with the order that objects were destroyed. Let me know if this looks ok to commit. Owen === modified file 'mixxx/src/mixxx.cpp' --- mixxx/src/mixxx.cpp 2012-12-06 17:11:14 + +++ mixxx/src/mixxx.cpp 2012-12-08 15:11:45 + @@

Re: [Mixxx-devel] small patch to fix some deletes

2012-12-08 Thread RJ Ryan
Shouldn't those be deleted in VinylControl::~VinylControl() and not in VinylControl::ToggleVinylControl? Otherwise, LGTM. Though the QAction/QMenu's aren't actually leaking since they are parented to the WTrackTableView they will be deleted when it is delete but I think it's good to explicitly