From: "Dr. David Alan Gilbert"
Nothing has checked the zr36067_debug variable since 2021 after
commit efdd0d42e276 ("media: staging: media: zoran: remove
detect_guest_activity")
It's set as a module parameter, remove it.
Signed-off-by: Dr. David Alan Gilbert
---
drivers/media/pci/zoran/zoran_
Rename min_buffers_needed into min_queued_buffers and update
the documentation about it.
Signed-off-by: Benjamin Gaignard
CC: Laurent Pinchart
CC: Mauro Carvalho Chehab
CC: Shawn Guo
CC: Sascha Hauer
CC: Pengutronix Kernel Team
CC: Fabio Estevam
CC: NXP Linux Team
CC: Hugues Fruchet
CC:
zoran driver use a dma engine and needs a minimum number of
buffers to be present before start streaming.
That is 'min_dma_buffers_needed' purpose so use it instead
of 'min_buffers_needed' field.
Signed-off-by: Benjamin Gaignard
CC: Corentin Labbe
CC: mjpeg-users@lists.sourceforge.net
---
drive
Hi Abhijeet,
Thank you for the zoran patches, unfortunately these are a duplicate of
https://patchwork.linuxtv.org/project/linux-media/patch/20220810115445.2302477-2-hverkuil-ci...@xs4all.nl/
I wish I'd noticed your patches earlier, it would have saved me some work :-(
I'm marking your patches
No problem, I understand.
On Wed, 24 Aug, 2022, 3:18 pm Hans Verkuil, wrote:
> Hi Abhijeet,
>
> Thank you for the zoran patches, unfortunately these are a duplicate of
>
>
> https://patchwork.linuxtv.org/project/linux-media/patch/20220810115445.2302477-2-hverkuil-ci...@xs4all.nl/
>
> I wish I'd
Deleted part of code in block comment
Signed-off-by: Abhijeet Srivastava
---
drivers/staging/media/zoran/zoran_driver.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/drivers/staging/media/zoran/zoran_driver.c
index b408c1d4e0a7..836edf6
Em Fri, 22 Jul 2022 20:52:29 +0200
Philipp Hortmann escreveu:
> On 7/22/22 20:26, Abhijeet Srivastava wrote:
> > Deleted part of code in block comment
> >
> > Signed-off-by: Abhijeet Srivastava
> > ---
> > drivers/staging/media/zoran/zoran_driver.c | 9 -
> > 1 file changed, 9 deleti
On 7/22/22 20:26, Abhijeet Srivastava wrote:
Deleted part of code in block comment
Signed-off-by: Abhijeet Srivastava
---
drivers/staging/media/zoran/zoran_driver.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/drivers/staging/media
On 7/21/22 17:00, Abhijeet Srivastava wrote:
Warning found by checkpatch.pl script.
Signed-off-by: Abhijeet Srivastava
---
drivers/staging/media/zoran/zoran_card.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/stag
On Thu, Jul 21, 2022 at 11:07:22PM +0530, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: Abhijeet Srivastava
> ---
> drivers/staging/media/zoran/zoran_driver.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/
Warning found by checkpatch.pl script.
Signed-off-by: Abhijeet Srivastava
---
drivers/staging/media/zoran/zoran_driver.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/drivers/staging/media/zoran/zoran_driver.c
index 4304b7
Warning found by checkpatch.pl script.
Signed-off-by: Abhijeet Srivastava
---
drivers/staging/media/zoran/zoran_card.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
index 26f978a1cc72..
Warning found by checkpatch.pl script
Signed-off-by: Abhijeet Srivastava
---
drivers/staging/media/zoran/videocodec.h | 180 +++
1 file changed, 90 insertions(+), 90 deletions(-)
diff --git a/drivers/staging/media/zoran/videocodec.h
b/drivers/staging/media/zoran/videocodec.
On Fri, May 06, 2022 at 10:14:55AM +0300, Dan Carpenter wrote:
> On Fri, May 06, 2022 at 01:30:12AM -0400, Ian Cowan wrote:
> > On Thu, Apr 28, 2022 at 10:15:03AM +0200, Hans Verkuil wrote:
> > > Hi Ian,
> > >
> > > When I compiled this patch series with smatch I got these warnings:
> > >
> > > z
This adds the zrdev_dbg() (pointing to pci_dbg()), zrdev_err() (pointing
to pci_err()), and zrdev_info() (pointing to pci_info()) macros to the
zoran drivers. These are the preferred method for debugging and this
will allow to extract the device from the zoran struct to make the call.
Signed-off-b
On Thu, Apr 28, 2022 at 10:15:03AM +0200, Hans Verkuil wrote:
> Hi Ian,
>
> When I compiled this patch series with smatch I got these warnings:
>
> zoran/videocodec.c:45 videocodec_attach() warn: variable dereferenced before
> check 'master' (see line 40)
> zoran/videocodec.c:115 videocodec_deta
This replaces all of the dprintk macro calls with the zrdev_dbg,
zrdev_info, or zrdev_err calls as appropriate. This allows for the
removal of the dprintk macro from each file it is defined in, along with
the removal of module params that track the debugging level.
In the case that the debugging l
This replaces all of the pr_err calls to the preferred zrdev_err macro
that calls the dev_err macro. There are a few locations where the pr_err
is left because a zoran struct cannot be created. This is the result of
error handling for another struct's existence that is required to create
a zoran st
This adds inline functions in the videocodec header file to convert the
videocodec and videocodec_master structs to their respective contained
zoran struct. This will be used to pass the zoran struct to the
zrdev_XXX() macros defined in the zoran header.
In the zoran header, the new include is add
On Fri, May 06, 2022 at 01:30:12AM -0400, Ian Cowan wrote:
> On Thu, Apr 28, 2022 at 10:15:03AM +0200, Hans Verkuil wrote:
> > Hi Ian,
> >
> > When I compiled this patch series with smatch I got these warnings:
> >
> > zoran/videocodec.c:45 videocodec_attach() warn: variable dereferenced
> > bef
On Thu, Apr 28, 2022 at 10:15:03AM +0200, Hans Verkuil wrote:
> Hi Ian,
>
> On 25/04/2022 16:41, Ian Cowan wrote:
> > This replaces all of the dprintk() macro calls to the zrdev_dbg(),
> > zrdev_info(), or zrdev_err() calls as appropriate. This allows for the
> > removal of the dprintk() macro fro
Hi Ian,
On 25/04/2022 16:41, Ian Cowan wrote:
> This replaces all of the dprintk() macro calls to the zrdev_dbg(),
> zrdev_info(), or zrdev_err() calls as appropriate. This allows for the
> removal of the dprintk() macro from each file it is defined in, along
> with removal of the module params th
Hi Ian,
url:
https://github.com/intel-lab-lkp/linux/commits/Ian-Cowan/staging-media-zoran-add-zrdev_dbg-macros/20220425-092814
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
1efba7ef1d7da5944493728c5375fef5b2130de4
config: i386-randconfig-m021-20220425
(https://do
This adds the zrdev_dbg() (pointing to pci_dbg()), zrdev_err() (pointing
to pci_err()), and zrdev_info() (pointing to pci_info()) macros to the
zoran drivers. These are the preferred method for debugging and this
will allow to extract the device from the zoran struct to make the call.
Signed-off-b
This replaces all of the pr_err() calls to the preferred zrdev_err()
macro that calls the dev_dbg() macro.
Signed-off-by: Ian Cowan
---
drivers/staging/media/zoran/videocodec.c | 32 +---
drivers/staging/media/zoran/zr36016.c| 28 +
drivers/staging/med
This adds inline functions in the videocodec header file to convert the
videocodec and videocodec_master structs to their respective contained
zoran struct. This will be used to pass the zoran struct to the
zrdev_XXX() macros defined in the zoran header.
In the zoran header, the new include is add
This adds inline functions in the videocodec header file to convert the
videocodec and videocodec_master structs to their respective contained
zoran struct. This will be used to pass the zoran struct to the
zrdev_XXX() macros defined in the zoran header.
In the zoran header, the new include is add
This adds the zrdev_dbg() (pointing to pci_dbg()), zrdev_err() (pointing
to pci_err()), and zrdev_info() (pointing to pci_info()) macros to the
zoran drivers. These are the preferred method for debugging and this
will allow to extract the device from the zoran struct to make the call.
Signed-off-b
On Sun, Apr 24, 2022 at 09:17:22PM +0200, LABBE Corentin wrote:
> Hello
>
> Thanks for your patchs, removing dprintk is a good idea.
> Please use pci_xxx() instead of dev_xxx() to be consistent with the rest of
> the driver.
> The comment title is misleading, zrdev_err is not about debugging. Wha
Le Sat, Apr 23, 2022 at 01:17:45AM -0400, Ian Cowan a écrit :
> This adds the zrdev_dbg() (pointing to dev_dbg()), zrdev_err() (pointing
> to dev_err()), and zrdev_info() (pointing to dev_info()) macros to the
> zoran drivers. These are the preferred method for debugging and this
> will allow to ex
On Sun, Apr 24, 2022 at 09:22:30PM -0400, Ian Cowan wrote:
> On Sun, Apr 24, 2022 at 09:17:22PM +0200, LABBE Corentin wrote:
> > Hello
> >
> > Thanks for your patchs, removing dprintk is a good idea.
> > Please use pci_xxx() instead of dev_xxx() to be consistent with the rest of
> > the driver.
>
This adds inline functions in the videocodec header file to convert the
videocodec and videocodec_master structs to their respective contained
zoran struct. This will be used to pass the zoran struct to the
zrdev_XXX() macros defined in the zoran header.
In the zoran header, the new include is add
This replaces all of the dprintk() macro calls to the zrdev_dbg(),
zrdev_info(), or zrdev_err() calls as appropriate. This allows for the
removal of the dprintk() macro from each file it is defined in, along
with removal of the module params that track the debugging level.
In the case that a debug
This adds the zrdev_dbg() (pointing to dev_dbg()), zrdev_err() (pointing
to dev_err()), and zrdev_info() (pointing to dev_info()) macros to the
zoran drivers. These are the preferred method for debugging and this
will allow to extract the device from the zoran struct to make the call.
Signed-off-b
On Sat, Apr 23, 2022 at 01:23:31AM -0400, Ian Cowan wrote:
> On Fri, Apr 22, 2022 at 07:10:34AM +0200, Greg KH wrote:
> > On Thu, Apr 21, 2022 at 08:30:25PM -0400, Ian Cowan wrote:
> > > On Thu, Apr 21, 2022 at 06:52:04PM +0300, Dan Carpenter wrote:
> > > > On Thu, Apr 21, 2022 at 11:22:00AM -0400,
On Fri, Apr 22, 2022 at 07:10:34AM +0200, Greg KH wrote:
> On Thu, Apr 21, 2022 at 08:30:25PM -0400, Ian Cowan wrote:
> > On Thu, Apr 21, 2022 at 06:52:04PM +0300, Dan Carpenter wrote:
> > > On Thu, Apr 21, 2022 at 11:22:00AM -0400, Ian Cowan wrote:
> > > >
> > > > For using the dev_dbg() macro, d
This replaces all of the pr_err() calls to the preferred zrdev_err()
macro that calls the dev_dbg() macro.
Signed-off-by: Ian Cowan
---
drivers/staging/media/zoran/videocodec.c | 32 +---
drivers/staging/media/zoran/zr36016.c| 28 +
drivers/staging/med
This adds inline functions in the videocodec header file to convert the
videocodec and videocodec_master structs to their respective contained
zoran struct. This will be used to pass the zoran struct to the
zrdev_dbg() macros defined in the zoran header.
In the zoran header, the new include is add
This replaces all of the dprintk() macro calls to the zrdev_dbg(),
zrdev_info(), or zrdev_err() calls as appropriate. This allows for the
removal of the dprintk() macro from each file it is defined in, along
with removal of the module params that track the debugging level.
In the case that a debug
On Thu, Apr 21, 2022 at 08:30:25PM -0400, Ian Cowan wrote:
> On Thu, Apr 21, 2022 at 06:52:04PM +0300, Dan Carpenter wrote:
> > On Thu, Apr 21, 2022 at 11:22:00AM -0400, Ian Cowan wrote:
> > >
> > > For using the dev_dbg() macro, do you define this in the header file
> > > (i.e. for this it would
On Thu, Apr 21, 2022 at 06:52:04PM +0300, Dan Carpenter wrote:
> On Thu, Apr 21, 2022 at 11:22:00AM -0400, Ian Cowan wrote:
> >
> > For using the dev_dbg() macro, do you define this in the header file
> > (i.e. for this it would be videocodec.h), or where should this be
> > included from?
>
> dev
This removed the dprintk() function which used the printk() function for
kernel debug printing. These have all been replaced with the appropriate
pr_X() functions. Where the log level is necessary, this has been replace
by using CONSOLE_LOGLEVEL_DEFAULT.
Signed-off-by: Ian Cowan
---
drivers/stag
On Thu, Apr 21, 2022 at 06:52:04PM +0300, Dan Carpenter wrote:
> On Thu, Apr 21, 2022 at 11:22:00AM -0400, Ian Cowan wrote:
> >
> > For using the dev_dbg() macro, do you define this in the header file
> > (i.e. for this it would be videocodec.h), or where should this be
> > included from?
>
> dev
On Thu, Apr 21, 2022 at 05:21:54PM +0300, Dan Carpenter wrote:
> On Wed, Apr 20, 2022 at 08:23:16PM -0400, Ian Cowan wrote:
> > This is a patch to refactor the zoran debugging function. This function
> > existed in all of the changed files and they also all import the
> > videocodec header file. Th
On Thu, Apr 21, 2022 at 11:22:00AM -0400, Ian Cowan wrote:
>
> For using the dev_dbg() macro, do you define this in the header file
> (i.e. for this it would be videocodec.h), or where should this be
> included from?
dev_dbg() is defined in include/linux/dev_printk.h. Look around at how
it's use
This is a patch to refactor the zoran debugging function. This function
existed in all of the changed files and they also all import the
videocodec header file. This patch moves the dprintk function into the
videocodec header file and out of each of the individual files.
Signed-off-by: Ian Cowan
On Wed, Apr 20, 2022 at 08:23:16PM -0400, Ian Cowan wrote:
> This is a patch to refactor the zoran debugging function. This function
> existed in all of the changed files and they also all import the
> videocodec header file. This patch moves the dprintk function into the
> videocodec header file a
On 3/14/22 1:55 AM, Mauro Carvalho Chehab wrote:
media Kconfig has two entries associated to V4L API:
VIDEO_DEV and VIDEO_V4L2.
On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.
VIDEO_DEV were meant to:
1) enable Video4Linux and make its Kconfig options to appear;
It was <2022-03-14 pon 17:35>, when Mauro Carvalho Chehab wrote:
> media Kconfig has two entries associated to V4L API:
> VIDEO_DEV and VIDEO_V4L2.
>
> On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.
> VIDEO_DEV were meant to:
> 1) enable Video4Linux and make its Kconfig
media Kconfig has two entries associated to V4L API:
VIDEO_DEV and VIDEO_V4L2.
On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.
VIDEO_DEV were meant to:
1) enable Video4Linux and make its Kconfig options to appear;
2) it makes the Kernel build the V4L core.
wh
I opted to join two series and one separate patch on a single series, as they're
related and one depends on the others. That's the second version of it.
It basically sorts the main media Makefile/Kconfig files and reorganizes
drivers/media/platform
building system. Now, the entries there are orga
Em Mon, 14 Mar 2022 16:07:45 +0100
Jacopo Mondi escreveu:
> Hi Mauro
>
> On Sun, Mar 13, 2022 at 08:12:05AM +0100, Mauro Carvalho Chehab wrote:
> > media Kconfig has two entries associated to V4L API:
> > VIDEO_DEV and VIDEO_V4L2.
> >
> > On Kernel 2.6.x, there were two V4L APIs, each one with i
On 14/03/2022 08:55, Mauro Carvalho Chehab wrote:
media Kconfig has two entries associated to V4L API:
VIDEO_DEV and VIDEO_V4L2.
On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.
VIDEO_DEV were meant to:
1) enable Video4Linux and make its Kconfig options to appear;
I opted to join two series and one separate patch on a single series, as they're
related and one depends on the others:
- Sort Makefiles and platform/Kconfig
https://lore.kernel.org/linux-media/cover.1647155572.git.mche...@kernel.org/T/#t
- Organize media platform drivers per manufacturer
htt
Hi Mauro
On Sun, Mar 13, 2022 at 08:12:05AM +0100, Mauro Carvalho Chehab wrote:
> media Kconfig has two entries associated to V4L API:
> VIDEO_DEV and VIDEO_V4L2.
>
> On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.
> VIDEO_DEV were meant to:
> 1) enable Video4Linux and
media Kconfig has two entries associated to V4L API:
VIDEO_DEV and VIDEO_V4L2.
On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.
VIDEO_DEV were meant to:
1) enable Video4Linux and make its Kconfig options to appear;
2) it makes the Kernel build the V4L core.
wh
media Kconfig has two entries associated to V4L API:
VIDEO_DEV and VIDEO_V4L2.
On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.
VIDEO_DEV were meant to:
1) enable Video4Linux and make its Kconfig options to appear;
2) it makes the Kernel build the V4L core.
wh
It remains some unused code from old zoran buffer handling.
Let's remove them.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 14 -
drivers/staging/media/zoran/zoran_card.c | 36 --
drivers/staging/media/zoran/zoran_device.h | 2 --
The vidmem parameter is no longer necessary since we removed framebuffer
support.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran
We need to empty zoran_init() for removing it later.
Furthermore, this permit to use pci_xxx instead of pr_xxx for prettier
printing.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 64
1 file changed, 33 insertions(+), 31 deletions(-)
diff
Since all kconfigs for card selection are bool, this causes all selected modules
to be always built-in.
Prevent this by moving selects to the main tristate kconfig.
By doing this, remove also all "if MEDIA_SUBDRV_AUTOSELECT" which are
wrong, since zoran always need them to work.
Signed-off-by: Co
Move some code out of zr36057_init() and create new functions for handling
zr->video_dev.
This permit to ease code reading and fix a zr->video_dev memory leak.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 2 +-
drivers/staging/media/zoran/zoran_card.c | 80 +
From: Hans Verkuil
This makes no sense for MJPEG formats and it is just easier to
drop support for this altogether.
Signed-off-by: Hans Verkuil
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 2 +-
drivers/staging/media/zoran/zoran_driver.c | 12
2
vb2_dma_contig_set_max_seg_size need to have a size in parameter and not
a DMA_BIT_MASK().
While fixing this issue, also fix error handling of all DMA size
setting.
Reported-by: kernel test robot
Fixes: d4ae3689226e5 ("media: zoran: device support only 32bit DMA address")
Signed-off-by: Corentin
The zoran driver is split in many modules, but this lead to some
problems.
One of them is that load order is incorrect when everything is built-in.
Having more than one module is useless, so merge all zoran modules in
one.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/Kconfig
All zoran module will be merged, so to prevent conflict, the debug
module parameter need to be renamed
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/videocodec.c | 8
drivers/staging/media/zoran/zr36016.c| 12 ++--
drivers/staging/media/zoran/zr36050.c|
After each capture, zoran driver complains that it remains some unused
buffer. This is due to a missing count handling.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/d
From: Hans Verkuil
TRY_FMT must not set actual capture values (zr->buffer_size in
this case), since it is a 'try' only.
zoran_try_fmt_vid_cap() also didn't fill in fmt->fmt.pix.bytesperline
and fmt->fmt.pix.sizeimage correctly.
Signed-off-by: Hans Verkuil
Signed-off-by: Corentin Labbe
---
dr
Add debugfs for displaying zoran debug and stats information.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/Kconfig | 1 +
drivers/staging/media/zoran/zoran.h | 2 ++
drivers/staging/media/zoran/zoran_card.c | 36
3 files changed, 39 insertion
Reduces the size of the probe function by adding zoran_i2c_init/zoran_i2c_exit
functions.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 73 ++--
1 file changed, 54 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_ca
From: Hans Verkuil
Do not spam the kernel log with messages that result from incorrect
userspace input. Those should be either dropped completely (the error
code gives sufficient info) or changed to debug messages.
Signed-off-by: Hans Verkuil
Signed-off-by: Corentin Labbe
---
drivers/staging/
On the case tmp_dcim=1, the index of buffer is miscalculated.
This generate a NULL pointer dereference later.
So let's fix the calcul and add a check to prevent this to reappear.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_device.c | 7 ++-
1 file changed, 6 insertio
Simplify code by using module_pci_driver()
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
ind
Now we have a debugfs, we can remove all PROCFS stuff.
We keep videocodec_debugfs_show(), it will be used later
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/videocodec.c | 24 +---
drivers/staging/media/zoran/videocodec.h | 3 +++
2 files changed, 4 insertio
Hello
The main change of this serie is to merge all zoran related modules in
one.
This fixes the load order problem when everything is built-in.
But this serie include several more fixes found while working on this.
Regards
Changes since v3:
- Fixed a lock up when doing a capture
- added fixes p
From: Hans Verkuil
This fixes several issues found with 'v4l2-compliance -s':
1) read()/write() is supported, but not reported in the capabilities
2) S_STD(G_STD()) failed: setting the same standard should just return 0.
3) G_PARM failed to set readbuffers.
4) different field values in the forma
Le Mon, Nov 08, 2021 at 09:21:22AM +0100, Hans Verkuil a écrit :
> On 07/11/2021 17:35, LABBE Corentin wrote:
> > Le Wed, Nov 03, 2021 at 05:29:46PM +0100, Hans Verkuil a écrit :
> >> On 03/11/2021 16:57, LABBE Corentin wrote:
> >>> Le Wed, Nov 03, 2021 at 04:21:02PM +0100, Hans Verkuil a écrit :
>
On 07/11/2021 17:35, LABBE Corentin wrote:
> Le Wed, Nov 03, 2021 at 05:29:46PM +0100, Hans Verkuil a écrit :
>> On 03/11/2021 16:57, LABBE Corentin wrote:
>>> Le Wed, Nov 03, 2021 at 04:21:02PM +0100, Hans Verkuil a écrit :
Hi Corentin,
On 26/10/2021 21:34, Corentin Labbe wrote:
>>>
Le Wed, Nov 03, 2021 at 05:29:46PM +0100, Hans Verkuil a écrit :
> On 03/11/2021 16:57, LABBE Corentin wrote:
> > Le Wed, Nov 03, 2021 at 04:21:02PM +0100, Hans Verkuil a écrit :
> >> Hi Corentin,
> >>
> >> On 26/10/2021 21:34, Corentin Labbe wrote:
> >>> Hello
> >>>
> >>> The main change of this s
On 03/11/2021 16:57, LABBE Corentin wrote:
> Le Wed, Nov 03, 2021 at 04:21:02PM +0100, Hans Verkuil a écrit :
>> Hi Corentin,
>>
>> On 26/10/2021 21:34, Corentin Labbe wrote:
>>> Hello
>>>
>>> The main change of this serie is to fusion all zoran related modules in
>>> one.
>>> This fixes the load o
Hi Corentin,
On 26/10/2021 21:34, Corentin Labbe wrote:
> Hello
>
> The main change of this serie is to fusion all zoran related modules in
> one.
> This fixes the load order problem when everything is built-in.
I've been testing this series, and while the module load/unload is now working,
I'm
Le Wed, Nov 03, 2021 at 04:21:02PM +0100, Hans Verkuil a écrit :
> Hi Corentin,
>
> On 26/10/2021 21:34, Corentin Labbe wrote:
> > Hello
> >
> > The main change of this serie is to fusion all zoran related modules in
> > one.
> > This fixes the load order problem when everything is built-in.
>
>
Le Tue, Nov 02, 2021 at 08:40:28PM +0300, Dan Carpenter a écrit :
> On Sun, Oct 17, 2021 at 10:05:06PM +0200, LABBE Corentin wrote:
> > Le Thu, Oct 14, 2021 at 10:37:52AM +0300, Dan Carpenter a écrit :
> > > On Wed, Oct 13, 2021 at 06:58:06PM +, Corentin Labbe wrote:
> > > > +config VIDEO_ZORAN
On Sun, Oct 17, 2021 at 10:05:06PM +0200, LABBE Corentin wrote:
> Le Thu, Oct 14, 2021 at 10:37:52AM +0300, Dan Carpenter a écrit :
> > On Wed, Oct 13, 2021 at 06:58:06PM +, Corentin Labbe wrote:
> > > +config VIDEO_ZORAN_DEBUG
> > > + bool "Enable zoran debugfs"
> > > + depends on VIDEO_ZORAN
Reduces the size of the probe function by adding zoran_i2c_init/zoran_i2c_exit
functions.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 73 ++--
1 file changed, 54 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_ca
All zoran module will be merged, so to prevent conflict, the debug
module parameter need to be renamed
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/videocodec.c | 8
drivers/staging/media/zoran/zr36016.c| 12 ++--
drivers/staging/media/zoran/zr36050.c|
Since all kconfigs for card selection are bool, this causes all selected modules
to be always built-in.
Prevent this by moving selects to the main tristate kconfig.
By doing this, remove also all "if MEDIA_SUBDRV_AUTOSELECT" which are
wrong, since zoran always need them to work.
Signed-off-by: Co
Hello
The main change of this serie is to fusion all zoran related modules in
one.
This fixes the load order problem when everything is built-in.
Regards
Changes since v2:
- added the 4 latest patchs
- removed DEBUGFS kconfig option
- fixed Dan Carpenter's reported codec issues
- fixed kernel te
The zoran driver is split in many modules, but this lead to some
problems.
One of them is that load order is incorrect when everything is built-in.
Having more than one module is useless, so fusion all zoran modules in
one.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/Kconfig
Move some code out of zr36057_init() and create new functions for handling
zr->video_dev.
This permit to ease code reading and fix a zr->video_dev memory leak.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 2 +-
drivers/staging/media/zoran/zoran_card.c | 80 +
The DC30 uses a non-i2c ITT MSE3000 encoder and not an adv7175 as stated
in the card list.
So remove adv7175 from DC30.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/driv
vb2_dma_contig_set_max_seg_size need to have a size in parameter and not
a DMA_BIT_MASK().
While fixing this issue, also fix error handling of all DMA size
setting.
Reported-by: kernel test robot
Fixes: d4ae3689226e5 ("media: zoran: device support only 32bit DMA address")
Signed-off-by: Corentin
The vidmem parameter is no longer necessary since we removed framebuffer
support.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran
Add debugfs for displaying zoran debug and stats information.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/Kconfig | 1 +
drivers/staging/media/zoran/zoran.h | 2 ++
drivers/staging/media/zoran/zoran_card.c | 36
3 files changed, 39 insertion
Simplify code by using module_pci_driver()
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
ind
Now we have a debugfs, we can remove all PROCFS stuff.
We keep videocodec_debugfs_show(), it will be used later
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/videocodec.c | 24 +---
drivers/staging/media/zoran/videocodec.h | 3 +++
2 files changed, 4 insertio
After each capture, zoran driver complains that it remains some unused
buffer. This is due to a missing count handling.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/d
It remains some unused code from old zoran buffer handling.
Let's remove them.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 14 -
drivers/staging/media/zoran/zoran_card.c | 36 --
drivers/staging/media/zoran/zoran_device.h | 2 --
We need to empty zoran_init() for removing it later.
Furthermore, this permit to use pci_xxx instead of pr_xxx for prettier
printing.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 64
1 file changed, 33 insertions(+), 31 deletions(-)
diff
Le Mon, Oct 25, 2021 at 05:13:04PM +0200, Hans Verkuil a écrit :
> On 25/10/2021 16:21, LABBE Corentin wrote:
> > Le Mon, Oct 25, 2021 at 02:45:02PM +0200, Hans Verkuil a écrit :
> >> Hi Corentin,
> >>
> >> On 13/10/2021 20:58, Corentin Labbe wrote:
> >>> Hello
> >>>
> >>> The main change of this s
1 - 100 of 357 matches
Mail list logo
