Re: [mkgmap-dev] [PATCH v1] Reduce number of cuts in multipolygon processing

2010-02-25 Thread Marko Mäkelä
I wrote: I found something strange in my test: Error at line 2341764, col 41 Bad file format: 63240004.osm.gz Exception in thread main java.lang.NullPointerException at uk.me.parabola.mkgmap.combiners.FileInfo.getFileInfo (FileInfo.java:136) at

Re: [mkgmap-dev] Merging adjacent multipolygons

2010-02-25 Thread Apollinaris Schoell
On 25 Feb 2010, at 24:09 , Marko Mäkelä wrote: Hi WanMil, Have you looked at merging adjacent multipolygons? There was some controversy on the Finnish forum http:// forum.openstreetmap.org/viewforum.php?id=15 but I was not alone with the opinion that lakes should be defined as

Re: [mkgmap-dev] [PATCH v1] Reduce number of cuts in multipolygon processing

2010-02-25 Thread Mark Burton
Marko, If nobody opposes, I will commit the patch. Fine, but why not hang on for a while and give people a chance to try it out and report back before it gets committed. Mark ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk

Re: [mkgmap-dev] [PATCH v1] Reduce number of cuts in multipolygon processing

2010-02-25 Thread Marko Mäkelä
Mark, Marko, If nobody opposes, I will commit the patch. Fine, but why not hang on for a while and give people a chance to try it out and report back before it gets committed. Sure, it is a non-trivial change to the algorithm. What about one week? If I forget, WanMil please remind

Re: [mkgmap-dev] [PATCH v1] Reduce number of cuts in multipolygon processing

2010-02-25 Thread Mark Burton
Hello Marko, Sure, it is a non-trivial change to the algorithm. What about one week? If I forget, WanMil please remind me. :-) My rule of thumb for committing non-trivial changes goes along the lines of: if you receive negative reports, either fix the patch or convince the reporter

[mkgmap-dev] Fwd: resolution and zoom levels in style files

2010-02-25 Thread Steve Ratcliffe
Hi, I'm forwarding this mail that ended up at the bounce address rather than going to the list. Original Message Subject: resolution and zoom levels in style files Date: Thu, 25 Feb 2010 03:43:52 +0100 From: Daniela Duerbeck daniela.duerb...@gmx.de Reply-To:

Re: [mkgmap-dev] Fwd: resolution and zoom levels in style files

2010-02-25 Thread Felix Hartmann
On 25.02.2010 13:04, Steve Ratcliffe wrote: Hi, I'm forwarding this mail that ended up at the bounce address rather than going to the list. Original Message Subject: resolution and zoom levels in style files Date: Thu, 25 Feb 2010 03:43:52 +0100 From: Daniela

Re: [mkgmap-dev] [PATCH v1] Reduce number of cuts in multipolygon processing

2010-02-25 Thread Felix Hartmann
I too ran into problems using the patch (on Austria from geofabrik): java.lang.NullPointerException at uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation.cutOutInnerPolygons(MultiPolygonRelation.java:892) at

[mkgmap-dev] Weird turn instructions

2010-02-25 Thread Carlos Dávila
At least since version of 12/02/2010 I'm getting some weird turn instructions in places where they worked fine in the past . In this area [1] I get two of these estrange instructions when driving SE from Avenida Cordel de Merinas to SW in Avenida Hernán Cortés. The sequence of instructions (both

Re: [mkgmap-dev] Weird turn instructions

2010-02-25 Thread Mark Burton
Hi Carlos, At least since version of 12/02/2010 I'm getting some weird turn instructions in places where they worked fine in the past . In this area [1] I get two of these estrange instructions when driving SE from Avenida Cordel de Merinas to SW in Avenida Hernán Cortés. The sequence of

Re: [mkgmap-dev] [PATCH v1] Reduce number of cuts in multipolygon processing

2010-02-25 Thread Marko Mäkelä
Hi Felix, WanMil, Maybe both Marko and me am using some other patches that break something here? The only other patch I have on top of r1584 default style is the translation of traffic_calming=* in the POI file. No changes to the code. Could it be some hard-to-trigger race condition? I

[mkgmap-dev] [PATCH v2] Reduce number of cuts in multipolygon processing

2010-02-25 Thread WanMil
The patch fixes a NullPointerException (thanks Felix!) which sometimes happened with the first patch. @Marko: I don't know any reason, why this multipolygon patch should trigger your exception. The stacktrace shows that you use a modified Main.java which seems to trigger the Exception.

Re: [mkgmap-dev] Merging adjacent multipolygons

2010-02-25 Thread WanMil
Hi WanMil, Have you looked at merging adjacent multipolygons? There was some controversy on the Finnish forumhttp:// forum.openstreetmap.org/viewforum.php?id=15 but I was not alone with the opinion that lakes should be defined as multipolygons, no matter how complex they are, and that

Re: [mkgmap-dev] [PATCH v2] Reduce number of cuts in multipolygon processing

2010-02-25 Thread Felix Hartmann
okay, new patch seems to be working. On Austria it rather got slower than faster however, but difference is not significant. Also map size increased and did not decrease. Could not yet find out big differences. If you think it is better/more correct (you understand a lot more about it), then

[mkgmap-dev] Garmin colour palette

2010-02-25 Thread Daniela Duerbeck
Hi! I am not sure whether this is the correct ML for this posting, but I think it is not completely wrong. I saw that the colour palette used in the online Typ file editor has too few and some wrong colours, almost for my Garmin Etrex Legend HCx. So I extracted the colour palette of a Garmin

Re: [mkgmap-dev] Fwd: resolution and zoom levels in style files

2010-02-25 Thread Garvan maew
Daniela Duerbeck wrote: I think there are a few problems for a beginner like me: I have 27 zoom levels on my Garmin device. I have 24 levels for resolution in the style file I have 8 mappings of resolution to levels in the options file. I learned that some levels on the device show overzoom