Version mkgmap-r2883 was committed by gerd on Tue, 17 Dec 2013
Store CoordNode instead of nodeid in IdentityHashMap.
This avoids the creation of different CoordNode instances
with equal ids. It also reduces memory requirements
a little bit as we don't have to create many thousands of
Hi all,
I am not sure if the --road-name-pois option is still used.
The option tries to adds a poi for each road name.
The code uses the Coord.equals() to detect whether to
different road segments with equal names are connected
or not. The test is not 100% correct, as it should test
whether the
Hi Minko,
Hi Wanmil
I tested it again and after some modifications of my styles everything shows up
on the map as intended.
So the labels are fine now.
Great!
Some remarks:
1) I had to add this line in my style to make housenumber search work:
# Assign the street name for house number
Hi Gerd,
I don't remember any place where the mergeroads branch prints a warning
for such a case.
But I noticed that the RoadMerger uses Coord.equals instead of ==.
I'll have to change that.
WanMil
Hi all,
I am not sure if the --road-name-pois option is still used.
The option tries to
2) To make the place pois appear again I had to add some rules in the
finalize section:
finalize
name=* { name '${name}' }
Mmmh, name=* { name '${name}' } is the first rule in the compat_points
file. But I will check place pois again.
To be sure that I am looking for the right thing:
You are
Wanmil, you are right.
First I didnt use compat_points only compat_lines.
Then I found out that name=* { name '${name}' } in the pois file did the trick
in the finalize section to make the place names appear again. With
compat_points it works too.
Thanks!
Minko
To be sure that I am looking
Hi Gerd,
sounds good. I don't know about any problems because
StyledConverter.addShape returns directly if the way is not closed.
WanMil
Hi,
I just wonder why we use the rules in polygons AND lines for a way that
is not closed (in OSM)
If I got that right, the way should only be processed
Hi WanMil,
yes, and the rules in lines are processed first, so we don't risk a wrong match,
but it might safe some CPU cycles to check fewer rules.
I'll change it in StyledConverter.
Gerd
Date: Tue, 17 Dec 2013 15:48:51 +0100
From: wmgc...@web.de
To: mkgmap-dev@lists.mkgmap.org.uk
Subject:
Chris66 wrote
Am 04.12.2013 10:53, schrieb Gerd Petermann:
because
the way starts with a short segment that is not part of the loop.
And so the way is NOT closed in OSM-sense.
I agree. Question is why the unit test for the is_closed() style function
doesn't agree. It seems to expect that
Chris66 wrote
Am 04.12.2013 10:53, schrieb Gerd Petermann:
because
the way starts with a short segment that is not part of the loop.
And so the way is NOT closed in OSM-sense.
I agree. Question is why the unit test for the is_closed() style function
doesn't agree. It seems to expect that
Do you agree?
Yes. I wonder if hasEqualEndPoints() is required?
not If all routines that create shapes make sure that
they add the identical point to close the shape. In trunk,
this is not always the case, so I use it find those cases.
I'll post a patch later to show my results.
But
Do you agree?
Yes. I wonder if hasEqualEndPoints() is required?
not If all routines that create shapes make sure that
they add the identical point to close the shape. In trunk,
this is not always the case, so I use it find those cases.
I'll post a patch later to show my results.
Hi,
attached is a patch that should fix the remaining possible
problems regarding the reported Way.isClosed() and Coord.equals()
problems.
It seems that the use of IdentityHashMap is a bit slower than HashMap,
so throughput is a few percent slower.
Open question:
What is the expected result of
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Steve,
I don't want to bother you. Is there any news about this?
Henning
Am 25.11.2013 00:17, schrieb Steve Ratcliffe:
Hi Henning
in the end of August it worked without any problems. I've just
read here that something was changed with
3) Carpool tag is still not independent from access=no / motorcar=no
in Basecamp
I tried to clear all the carpool flags with set mkgmap:carpool=no
but that doesnt work.
The carpool handling is independent in the branch. But only if you
don't
use the compat_* includes.
Hi Wanmil
I
3) Carpool tag is still not independent from access=no / motorcar=no
in Basecamp
I tried to clear all the carpool flags with set mkgmap:carpool=no
but that doesnt work.
The carpool handling is independent in the branch. But only if you
don't
use the compat_* includes.
Hi Wanmil
I gave
Version mkgmap-r2885 was committed by gerd on Tue, 17 Dec 2013
make sure that returned shapes begin and end with identical points
This has an influence on routines like BoundaryRelation.
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
Hi Henning
OK, I will stop the command line overriding the declared CodePage in the
.txt file.
It seems like it is likely more often the wrong thing to do. If anyone
believes that there is a remaining problem then we will have to find
another way to fix that problem.
..Steve
-BEGIN
Version mkgmap-r2886 was committed by steve on Tue, 17 Dec 2013
Revert the part of r2762 where the command line code-page overrides the
declared one.
The warning that the command line and declared CodePage are different is still
printed
although there may not be anything actually wrong with
Steve,
This means that everyone needs to make everywhere sure that the correct
stuff is written inside the source file...
I really think it's the more convenient way to have:
1. The CP taken from the source file is the the one 'normally' used
2. CLI Argument 'overrules' the content of the TYP
Version mkgmap-r2887 was committed by gerd on Wed, 18 Dec 2013
revert changes from r2885
Can cause big empty triangles in sea, don't know yet why
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
Version mkgmap-r2888 was committed by gerd on Wed, 18 Dec 2013
now really make sure that returned shapes begin and end with identical
points.
Added unit test to verify special cases with equal points
___
mkgmap-dev mailing list
Version mkgmap-r2889 was committed by gerd on Wed, 18 Dec 2013
added unit test to make sure that Java2DConverter now really
returns shapes with identical start and end points
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
23 matches
Mail list logo
