Re: [mkgmap-dev] housenumbers and addr:interpolation

2014-12-02 Thread Gerd Petermann
Hi WanMil, (did not read this yesterday) I agree in most points, but maybe the information that is given with the addr:interpolation tag should also be used? The stats in taginfo say that most of them are odd/even, so we can ignore them. But what about "all" ? Do you have time to code the inter

[mkgmap-dev] [Patch v2] evaluate type=associatedStreet

2014-12-02 Thread Gerd Petermann
Hi all, attached is a slightly modified version of the patch with improved logging. I suggest to use uk.me.parabola.mkgmap.osmstyle.housenumber.level=FINE in the logging props if you want to find out more about housenumber processing. If I hear no complains I'll commit this patch on thursday. G

[mkgmap-dev] Commit: r3358: ISO-filter-v2.patch : new style filter country-ISO

2014-12-02 Thread svn commit
Version mkgmap-r3358 was committed by gerd on Tue, 02 Dec 2014 ISO-filter-v2.patch : new style filter country-ISO ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

[mkgmap-dev] [Patch v3] drive-on-left/drive-on-right handling

2014-12-02 Thread Gerd Petermann
Hi all, attached is v3 of the patch. I think we should finish this before we start with the coding for the non-rectangular tiles support. 1) I've tried to make sure that the flags in TRE and NOD are set to equal values. 2) The options --drive-on-left and --drive-on-right are deprecated but sti

Re: [mkgmap-dev] [Patch v3] drive-on-left/drive-on-right handling

2014-12-02 Thread Andrzej Popowski
Hi Gerd, I publish some maps of Africa, like East Africa or South Africa. These are parts of the world, where people drive on left. My default is drive-on-left, but maps include some small parts with drive on right too. I'm afraid drive-on=detect could fail for my maps, for example if a tile

Re: [mkgmap-dev] [Patch v3] drive-on-left/drive-on-right handling

2014-12-02 Thread GerdP
Hi Andrzej, do you think that we should count all routable ways ? Gerd popej wrote > Hi Gerd, > > I publish some maps of Africa, like East Africa or South Africa. These > are parts of the world, where people drive on left. My default is > drive-on-left, but maps include some small parts with

Re: [mkgmap-dev] [Patch v3] drive-on-left/drive-on-right handling

2014-12-02 Thread Colin Smale
I can't see how that would work, unless you can deduce that two parallel one-ways are part of the same dual carriageway. And that's an algorithm that many people would like to have, I'm sure... Colin On 2014-12-02 13:45, GerdP wrote: > Hi Andrzej, > > do you think that we should count all

Re: [mkgmap-dev] [Patch v3] drive-on-left/drive-on-right handling

2014-12-02 Thread GerdP
Hi Colin, I did not think that far. My idea is to detect the country of each routable way, I don't care about unclear cases. If that result says that there are more ways in the dol area, we set the drive-on-left flag. We may also cumulate the lengths of the ways. I don't care if any specific way i

Re: [mkgmap-dev] [Patch v3] drive-on-left/drive-on-right handling

2014-12-02 Thread Steve Ratcliffe
On 02/12/14 12:32, Andrzej Popowski wrote: I'm afraid drive-on=detect could fail for my maps, for example if a tile contains no roundabouts. Does drive-on-left / right make any difference if there are no roundabouts? ..Steve ___ mkgmap-dev mailing li

Re: [mkgmap-dev] [Patch v3] drive-on-left/drive-on-right handling

2014-12-02 Thread GerdP
Hi Steve, I did not try it, but I would expect different results when Garmin calculates the fastest route. A left turn in an "dor" typically takes more time than a right turn. Gerd Steve Ratcliffe wrote > On 02/12/14 12:32, Andrzej Popowski wrote: >> I'm afraid drive-on=detect could fail for m

Re: [mkgmap-dev] [Patch v3] drive-on-left/drive-on-right handling

2014-12-02 Thread Steve Ratcliffe
Hi Gerd I did not try it, but I would expect different results when Garmin calculates the fastest route. Yes I don't know the answer and it certainly could make a difference, but I do not recall anyone ever saying that it actually did. ..Steve ___

Re: [mkgmap-dev] housenumbers and addr:interpolation

2014-12-02 Thread Steve Ratcliffe
Hi Gerd I agree in most points, but maybe the information that is given with the addr:interpolation tag should also be used? The stats in taginfo say that most of them are odd/even, so we can ignore them. But what about "all" ? I agree that addr:interpolation should be used when present. If y

Re: [mkgmap-dev] housenumbers and addr:interpolation

2014-12-02 Thread GerdP
Hi Steve, I found another tag that we don't use: addr:place This is used frequently, but I don't know if the img format supports it? Gerd Steve Ratcliffe wrote > Hi Gerd > >> I agree in most points, but maybe the information that is >> given with the addr:interpolation tag should also be used

Re: [mkgmap-dev] [Patch v3] drive-on-left/drive-on-right handling

2014-12-02 Thread Andrzej Popowski
Hi, > do you think that we should count all routable ways? Maybe this could be better? But my problem is that your algorithm prefer dirve-on-right. If I use drive-on=detect, then drive-on-right is selected when detect fails (regardless of detect algorithm). In my opinion, this should be conf

Re: [mkgmap-dev] housenumbers and addr:interpolation

2014-12-02 Thread Andrzej Popowski
Hi Gerd, > I found another tag that we don't use: > addr:place > This is used frequently, but I don't know if the img format > supports it? addr:place is used instead of addr:street - some addresses don't contain street name but name of village instead. I don't think there is possibility to a

Re: [mkgmap-dev] [Patch v3] drive-on-left/drive-on-right handling

2014-12-02 Thread Steve Ratcliffe
On 02/12/14 10:00, Gerd Petermann wrote: @Steve, WanMil: I've added a ThreadLocal to TREHeader similar to that in NODHeader, but I think it would be better to store that info only once for each thread, I just don't know where, maybe MapMaker? Besides that I am not sure how this works when we writ

Re: [mkgmap-dev] [Patch v3] drive-on-left/drive-on-right handling

2014-12-02 Thread GerdP
Hi Steve, Steve Ratcliffe wrote > This should be treated in a similar way that copyright message are > handled. > > Add a method to LoadableMapDataSource and retrieve that value > somewhere in MapBuilder where it can easily be set into both > NOD and TRE. hmm, I'm not happy with that as well. Lo

Re: [mkgmap-dev] [Patch v3] drive-on-left/drive-on-right handling

2014-12-02 Thread GerdP
Hi Andrzej, okay, I agree. I'll try to implement it that way tomorrow. Gerd popej wrote > Hi, > > > do you think that we should count all routable ways? > > Maybe this could be better? > > But my problem is that your algorithm prefer dirve-on-right. If I use > drive-on=detect, then drive-o