Re: [mkgmap-dev] Commit r4124: slightly modified maxjobs-v6.patch by Mike Baggaley

2018-02-19 Thread Gerd Petermann
Hi Carlos, I've added a test to avoid this exception. @Mike: Not sure what goes wrong here. I think when you feed mkgmap with *.img there is nothing that can be done with more than one job. Gerd Von: mkgmap-dev im Auftrag von Carlos Dávila Gesendet:

[mkgmap-dev] Commit r4125: avoid division by zero

2018-02-19 Thread svn commit
Version mkgmap-r4125 was committed by gerd on Mon, 19 Feb 2018 avoid division by zero http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=4125 ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listin

Re: [mkgmap-dev] Commit r4124: slightly modified maxjobs-v6.patch by Mike Baggaley

2018-02-19 Thread Carlos Dávila
El 19/02/18 a las 14:53, svn commit escribió: Version mkgmap-r4124 was committed by gerd on Mon, 19 Feb 2018 slightly modified maxjobs-v6.patch by Mike Baggaley -- if max-jobs option is not set, try to find a reasonable value -- further improve documentation of options -- report run time in hou

[mkgmap-dev] work in progress: new option dem-shrink-factors

2018-02-19 Thread Gerd Petermann
Hi all, Frank Stinner found more about the meaning of the byte in DEM header at offset 0x12 of the zoom level header. This value gives a shrink factor that is used to minimize the deltas. All height delta values are divided by this factor, so that e.g. with a factor of 5 the values 12,19,20,10 b

[mkgmap-dev] parameter for --transparent option

2018-02-19 Thread Gerd Petermann
Hi all, I have no idea how to solve the problem with crashes in MapSource when --route is used with --transparent and --dem . Maybe there is another flag that has to be changed, maybe it is not supported by Garmin. So, the best work around seems to be using transparent background polygons (0x4b)

[mkgmap-dev] Commit r4124: slightly modified maxjobs-v6.patch by Mike Baggaley

2018-02-19 Thread svn commit
Version mkgmap-r4124 was committed by gerd on Mon, 19 Feb 2018 slightly modified maxjobs-v6.patch by Mike Baggaley -- if max-jobs option is not set, try to find a reasonable value -- further improve documentation of options -- report run time in hours, minutes and seconds instead of ms http://ww

Re: [mkgmap-dev] max-jobs patch

2018-02-19 Thread Mike Baggaley
Hi Gerd, I would prefer removing the static modifier as you suggest, but accessing the variable via mm.maxJobs rather than mm.getMaxJobs(), and having no getter implementation. However, I am happy with using the getter if you prefer it. I think getters and setters in mkgmap have been overused. I

Re: [mkgmap-dev] methods to write signed / unsigned integers

2018-02-19 Thread Ticker Berkin
Hi I think it is important to indicate if a signed or unsigned is being written so that the range can be asserted: eg: public void putU1(int val) { assert val >= 0 && val <= 255 : val; buf.put((byte)val); } and public void putS1(int val) {

Re: [mkgmap-dev] max-jobs patch

2018-02-19 Thread Gerd Petermann
Hi Mike, sorry for the late response. I've just recognized the static modifier in maxjobs. I think it is better to use a getter instead, see attached modifed version of the patch. If you agree, I'll commit this version. Gerd Von: mkgmap-dev im Auftrag v