Re: [mkgmap-dev] Please test branch NET-no-NOD

Hi Ticker, okay, I can reproduce the poor performance in this area. My timings: SCHW: uk.me.parabola.imgfmt.app.net.RoadNetwork 74210001.osm.pbf: routing island check took 5281 ms Total time taken: 35 seconds Most of the additional time is used to remove the nodes from NOD. This can be improve

Re: [mkgmap-dev] Please test branch NET-no-NOD

Hi Gerd split.list contains: 74210001: 2362592,-73088 to 2376288,-50304 Note feed in a lot of points (postcodes) into the splitter, but there is nothing in the default style that will process them. splitter command line is: java -Xmx1540M -ea -jar ../splitter/splitter.jar --geonames -file=../cit

Re: [mkgmap-dev] Please test branch NET-no-NOD

Hi Ticker, please let me know the mkgmap options and the area for 74210001. Maybe try with commented the log statements (except the one for the timing ) Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Dienstag, 22. Oktober 2019 18:33 An: De

Re: [mkgmap-dev] Please test branch NET-no-NOD

Hi Gerd These are with default style. mkgmap-NET-no-NOD-r4304 --x-check-routing-island-len=700 SEVE: uk.me.parabola.imgfmt.app.net.RoadNetwork 74210002.osm.pbf: check for routing islands found 38 islands SEVE: uk.me.parabola.imgfmt.app.net.RoadNetwork 74210002.osm.pbf: routing island check too

Re: [mkgmap-dev] Please test branch NET-no-NOD

Hi Ticker, strange, in my tests the test for routing islands performed in < 50 ms. So, there seems to be a special case. Also, I did not see that big effect on img siz. Please can you test with default style for comparison? Gerd Von: mkgmap-dev im Auftr

Re: [mkgmap-dev] Please test branch NET-no-NOD

Hi Gerd Testing mkgmap-NET-no-NOD-r4304 with 2 tile local area with option --x-check-routing-island-len=700 Some build statistics: SEVE: uk.me.parabola.imgfmt.app.net.RoadNetwork 74210002.osm.pbf: check for routing islands found 293 islands SEVE: uk.me.parabola.imgfmt.app.net.RoadNetwork 74210

Re: [mkgmap-dev] Commit r4314: fix assertion error when option --make-poi-index is used

Hi Ticker, thanks for review. Collections.sort(list) simply calls list.sort(null), so performance should not matter. I agree that the stream().ap() stuff doesn't inprove readability, I'll probably remove that from the patch. Gerd Von: mkgmap-dev im Auf

Re: [mkgmap-dev] Commit r4314: fix assertion error when option --make-poi-index is used

Hi Gerd Looking at sort6.patch: Generally - Collections.sort(keys); + keys.sort(null); I think the obj.sort() form looks better. Possibly more efficient? Considering the lambdas. In some cases isn't

Re: [mkgmap-dev] type/subtype of points and cities

Hi Minko, "(like you say)" should have been ... "(like Ticker wrote)" ... (a small dot with the label) ... sorry, I forgot to use the typ file, so 0x1101 is displayed with an icon showing a bus and without the label. But why do you use a type that is not indexed? Gerd __

Re: [mkgmap-dev] type/subtype of points and cities

Hi Ticker, thanks. @Minko: I've created a small map with "Openfietsmap full" style and trunk r4315 , OSM data contains an amenity=bus_station. The result is that this POI appears in the map (a small dot with the label), but it is not in the mdr (like you say). I found no older versions of mkgm

Re: [mkgmap-dev] type/subtype of points and cities

Hi Gerd The old reader/osm/Gtype:checkType() didn't diagnose cities (however they might be defined) with non-zero subtypes - this is where the new message comes from. Old general/MapPoint:isCity[Type] defined city as: return type >= 0x0100 && type <= 0x1100 ie 0x1100 is city, 0x1101 isn

Re: [mkgmap-dev] type/subtype of points and cities

Hi Ticker, I see some new warnings for Minkos popular Openfietsmap styles with this patch: checking style: Openfietsmap full Warning: invalid type 0x1101 for POINT in style file points, line 97 Warning: invalid type 0x1102 for POINT in style file points, line 263 Warning: invalid type 0x1102 for P

Re: [mkgmap-dev] type/subtype of points and cities

Hi Gerd Here is the patch based on the current trunk Ticker On Tue, 2019-04-23 at 11:51 +0100, Ticker Berkin wrote: > Hi > > I think the mkgmap internal handling of types/subtypes of points is > obscure. > > In the points style file, the type code is always full, ie type << 8 > | > subtype, but

Re: [mkgmap-dev] Commit r4314: fix assertion error when option --make-poi-index is used

Hi Ticker, sorry, I think I thought that Steve should take care and it slipped my mind. Unfortunately Steve seems to have lost interest in reviewing patches. So yes, please review the patch and post a new version based on trunk. Gerd P.S. I just stumbled over this while checking a possible refact

Re: [mkgmap-dev] Commit r4314: fix assertion error when option --make-poi-index is used

Hi Gerd I noticed this problem in April and there was a fix to it in the patch that simplified/clarified point type/subtype and city range handling: http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2019q2/029623.html The posting didn't elicit any responses, but I think the changes worthwhile. If you w