Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Gerd Petermann
Hi Ticker, I didn't notice that overlays are not documented. They appear in doc\styles\files.txt but it seems this part is commented out, so the text doesn't make it into the pdf. The major difference with overlays compared to [continue] is the data flow. The lines from overlays where possibl

[mkgmap-dev] Commit r4726: modify evaluation of direction flag (again)

2021-05-18 Thread svn commit
Version mkgmap-r4726 was committed by gerd on Wed, 19 May 2021 modify evaluation of direction flag (again) (dirFlagSetting_v2.patch by Ticker Berkin, modified) - don't ignore option --line-types-with-direction if --allow-reverse-merge option is not set - allow to have direction-flag unset even fo

Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Ticker Berkin
Hi Gerd Yes Ticker On Tue, 2021-05-18 at 15:56 +, Gerd Petermann wrote: > Hi Ticker, > > which "existing behaviour" do you mean? That before r4703? > > Gerd > > > Von: mkgmap-dev im Auftrag > von Ticker Berkin > Gesendet: Dienstag, 18. Mai 2021 1

Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Gerd Petermann
Hi Ticker, which "existing behaviour" do you mean? That before r4703? Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Dienstag, 18. Mai 2021 17:51 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] Line direction flag, merging etc H

Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Ticker Berkin
Hi Gerd (& Minko?) overlay files are undocumented and probably unused except in OpenFietsMaps. It is a very restricted way of doing what is now done with [... continue {with_actions}] or, even simpler, something like: tourism=camp_site [0x2b03 resolution 24] [0x2b05 resolution 24] [continue] all

Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Gerd Petermann
Hi Ticker, this is getting even more ugly than I expected when I wrote that I don't want to support multiple ways to set the flag... Whatever we decide there will be lots of confusion :( With overlay types and --line-types-with-direction it is not clear if one has to list the type that is used

Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Ticker Berkin
Hi Gerd I had tried it on some in-between version that I think had equivalent logic to the patch and it didn't get overridden. Doesn't the final (or only) lineAdder set it unconditionally for oneway roads? If I've misread it I'll build and test. Ticker On Tue, 2021-05-18 at 14:01 +, Gerd Pe

Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Gerd Petermann
Hi Ticker, sorry, you are right. The branch forces the direction flag for oneway roads. Now I don't like both versions :( Have to think again about this Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Dienstag, 18. Mai 2021 16:01 An:

Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Gerd Petermann
Hi Ticker, I don't see that oneway forces direction flag when the tag mkgmap:has-direction=no is set in the branch. Did you try it? Gerd Von: mkgmap-dev im Auftrag von Ticker Berkin Gesendet: Dienstag, 18. Mai 2021 15:53 An: Development list for mkgma

Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Ticker Berkin
Hi Gerd The code in low-res-opt looks like ignore-oneway-for-lines.patch. The disadvantage of this, as I see it, is that has-direction can't be forced false for one-way roads. I think my version is clearer. Considering substitute lines from /overlays: I had intended that they all (first and dup

Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Gerd Petermann
Hi Ticker, this would be my intended patch for trunk, it makes StyledConverter in branch and trunk identical. Gerd Von: mkgmap-dev im Auftrag von Gerd Petermann Gesendet: Dienstag, 18. Mai 2021 14:35 An: Development list for mkgmap Betreff: Re: [mkgma

Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Gerd Petermann
Hi Ticker, in the branch I found a solution which doesn't set the direction flag for overlay lines when the OSM way is a oneway and a road with overlay type is created. With your patch still ALL lines created from the overlay type have the direction flag set in that case. Tested this with the u

Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Ticker Berkin
Hi Gerd ISTR there are 2 oneway flags in NET/NOD, along with the other access flags! I recommends patching trunk - it fixes --lines-types-with-direction and should clarify possible problems/solutions for Felix. Ticker On Tue, 2021-05-18 at 08:56 +, Gerd Petermann wrote: > Hi Ticker, > > I

Re: [mkgmap-dev] Line direction flag, merging etc

2021-05-18 Thread Gerd Petermann
Hi Ticker, I just noticed that NET also contains a oneway flag, so I think it should be OK to have the direction flag in RGN be independant from oneway in NET /NOD. Not sure if I use your patch for trunk or merge it into the low-res-opt branch. I think only the branch cares about it because the

Re: [mkgmap-dev] 4179

2021-05-18 Thread Felix Hartmann
well as I said - I think it is actually good if they are reversed - so the same route stays a longer time on the road. With the current versions this works well - it seems all "copies" that can be reversed, are reversed. Even though something is asysmetrical - it does not mean that they may not be

[mkgmap-dev] improve sea/coastline rendering

2021-05-18 Thread Gerd Petermann
Hi all, see item 15 in http://gis.19327.n8.nabble.com/default-style-lines-enhancements-tc5971280.html This is one that I do understand and support. I think there are only few situations in which you want to render natural=coastline as line. The only one that I can think of is that you don't re