Re: [mkgmap-dev] Format6Encoder/Decoder

2021-11-29 Thread Ticker Berkin
Hi Gerd Please ignore previous patch - I hadn't saved deletion of other changes Attached is good version Sorry about that Ticker Index: doc/options.txt === --- doc/options.txt (revision 4819) +++ doc/options.txt (working copy) @@

Re: [mkgmap-dev] Format6Encoder/Decoder

2021-11-29 Thread Ticker Berkin
Hi Gerd I don't like the idea of these static warnings and I doubt if this combination is likely to be given. However I have added a note to options.txt and corrected / expanded the text in this area. I've incorporated you changes to the unit test. Not related to this patch, but to code-page na

Re: [mkgmap-dev] relation label patch

2021-11-29 Thread Gerd Petermann
Hi Mike, probably no problem as long as mkgmap:street is filled with the name that is used in the addr:street tag of the housenumber objects. Gerd Von: mkgmap-dev im Auftrag von Mike Baggaley Gesendet: Montag, 29. November 2021 14:05 An: 'Development

Re: [mkgmap-dev] relation label patch

2021-11-29 Thread Mike Baggaley
Hi Gerd, I do use --housenumbers. Is my name processing likely to be causing problems in Wales? I only occasionally go to Wales, so probably wouldn't have noticed any issue. Cheers, Mike -Original Message- From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com] Sent: 29 November 2

Re: [mkgmap-dev] relation label patch

2021-11-29 Thread Gerd Petermann
Hi Mike, OK, that's something I didn't think about before. You probably don't use the --housenumbers option? Gerd Von: mkgmap-dev im Auftrag von Mike Baggaley Gesendet: Montag, 29. November 2021 11:08 An: 'Development list for mkgmap' Betreff: Re: [mk

Re: [mkgmap-dev] relation label patch

2021-11-29 Thread Mike Baggaley
HI Gerd, in Wales many of the names are put as dual nationality in the name field with name:en and name:cy holding the English and Welsh variants. I use just the English as the name if there is one, but also add the Welsh name as another label for roads and places. In my points and lines files I h

Re: [mkgmap-dev] Format6Encoder/Decoder

2021-11-29 Thread Gerd Petermann
Hi Ticker, maybe show a warning message (once) when --lower-case is used without --code-page or with code-page=0? I've modified the unit test: - actual/expected where reversed - better(?) explanation for length differences Gerd Von: mkgmap-dev im Auftr

Re: [mkgmap-dev] Format6Encoder/Decoder

2021-11-29 Thread Ticker Berkin
Hi Gerd Yes, my mistake that --lower-case got ignored; I had forgotten that LBLFile didn't call setUpperCase(false). After this, I decided that it was better to make the encoder's letter- case default the same as the other encoders and be explicit in CodeFunctionsTest as to what was required for

[mkgmap-dev] Commit r4819: relationlabel.patch by Mike Baggaley:

2021-11-29 Thread svn commit
Version mkgmap-r4819 was committed by gerd on Mon, 29 Nov 2021 relationlabel.patch by Mike Baggaley: "Allows a node tagged with a role of label or admin_centre to be still used if it has no name defined, rather than only if it matches the name on the relation. Also an improvement in the diagnost