Re: [mkgmap-dev] [PATCH] Fix crash when parsing invalid UTF-8 files (WanMil)

2011-10-26 Thread WanMil
Using the patch I cannot reproduce the problem any more :-)) +1 to commit. Thanks! WanMil > > Hi > >> The problem should be fixed by using a separate Sort object for each >> thread. One solution would be if CommandArgs.getSort() returns a copy. I >> am not sure how to create a valid copy of a So

Re: [mkgmap-dev] [PATCH] Fix crash when parsing invalid UTF-8 files (WanMil)

2011-10-25 Thread Steve Ratcliffe
Hi The problem should be fixed by using a separate Sort object for each thread. One solution would be if CommandArgs.getSort() returns a copy. I am not sure how to create a valid copy of a Sort object. Steve, can you help? The problem is that there is only one MapMaker object. Attached patch

Re: [mkgmap-dev] [PATCH] Fix crash when parsing invalid UTF-8 files (WanMil)

2011-10-25 Thread Steve Ratcliffe
Hi > I think the problem is that the mkgmap Sort object is unsynchronized but > used by several threads. If they use the internal encoder at the same Ahh, well spotted. However... > The problem should be fixed by using a separate Sort object for each > thread. One solution would be if CommandA

Re: [mkgmap-dev] [PATCH] Fix crash when parsing invalid UTF-8 files (WanMil)

2011-10-25 Thread WanMil
>> Thanks for the patch. >> Can you post the exception you want to catch in your patch? The patch covers >> a problem which I think should be fixed at its origin. So a stacktrace would >> be very helpful. > >> Thanks! >> WanMil > > The origin is either JVM6 or the benelux dataset, depending on ho

Re: [mkgmap-dev] [PATCH] Fix crash when parsing invalid UTF-8 files (WanMil)

2011-10-25 Thread Rutger Nijlunsing
> Thanks for the patch. > Can you post the exception you want to catch in your patch? The patch covers > a problem which I think should be fixed at its origin. So a stacktrace would > be very helpful. > Thanks! > WanMil The origin is either JVM6 or the benelux dataset, depending on how you look