Re: [mkgmap-dev] [PATCH] Splitter area rounding seems wrong

2011-08-30 Thread Steve Ratcliffe
Hi 1. If the goal is to shift the boundaries onto a coarse grid, why round *down* for longitudes and *up* for latitudes? Why not round in the same direction for both? Even though I made that change (originally it rounded down/up in the same way as your patch). I have no idea why one goes up

Re: [mkgmap-dev] [PATCH] Splitter area rounding seems wrong

2011-08-29 Thread Steve Ratcliffe
Hi This looks like a bug to me. The attached patch rounds the minimum longitude/latitude down and the maximum longitude/latitude up, making sure that the rounded area always fully contains the original area. Not sure that I agree. Wouldn't this mean that tile boundaries would overlap if they

Re: [mkgmap-dev] [PATCH] Splitter area rounding seems wrong

2011-08-29 Thread Bartosz Fabianowski
Wouldn't this mean that tile boundaries would overlap if they were originally touching but not aligned? Yes, you are right. The splitter code is not sufficiently documented to make it clear what it is trying to achieve. After looking at the code, it seemed to me that the goal was to expand

[mkgmap-dev] [PATCH] Splitter area rounding seems wrong

2011-08-28 Thread Bartosz Fabianowski
Hi list I am debugging a coastline/sea generation issue and in the process of this, discovered what I believe to be a splitter bug. There is a method in RoundingUtils.java that rounds the boundaries of an area to multiples of Garmin units. The minimum and maximum longitude are both rounded

Re: [mkgmap-dev] [PATCH] Splitter area rounding seems wrong

2011-08-28 Thread WanMil
Hi Bartosz, thanks for your bugfix. It seems reasonable for me. @Steve: can you check that and commit it? WanMil Hi list I am debugging a coastline/sea generation issue and in the process of this, discovered what I believe to be a splitter bug. There is a method in RoundingUtils.java