Re: [mkgmap-dev] [PATCH v1] Tag delete bug fix

2010-01-08 Thread Mark Burton
Using this patch, I am seeing better than 20% speed improvement when processing the Baltic map. YMMV. The amount of speed up is dependent on the density of tags. If your nodes/way are heavily tagged, you will see a speed benefit with this patch. It will also reduce VM required (I don't have any

Re: [mkgmap-dev] [PATCH v1] Tag delete bug fix

2010-01-08 Thread Mark Burton
Hi Steve, Anyway, please check the attached patch for sanity ... Looks good to me. Thanks, will now finally gain the benefit of not wasting gobs of memory in the hash maps! OK - now committed. It's just a stroke of luck that I stumbled across these issues, if I hadn't tried to delete a

[mkgmap-dev] [PATCH v1] Tag delete bug fix

2010-01-07 Thread Mark Burton
Hi Steve, I think I have found the problem in Tags.java that was causing the assertion when I tried to delete multiple tags. I believe the root cause was the fact that remove() would decrement size so it looked as if there was space but it didn't actually remove the key (as the comment there