[mkgmap-dev] [PATCH v4] sea polygons

2009-08-15 Thread Christian Gawron
With this version of the patch, the intersection of the bounding box and the landmass does not have to be simply connected as in version 3 of the patch. There are still some "flooded island" in ireland, but I'm pretty sure this is a problem in the multipolygon code this patch relies on (it jus

Re: [mkgmap-dev] [PATCH v4] sea polygons

2009-08-16 Thread maning sambale
Cannot build this patch using latest trunk (1135): man...@cumingi:~/osm/routable_garmin/mkgmap/trunk$ ant distBuildfile: build.xml prepare: compile: [javac] Compiling 7 source files to /home/maning/osm/routable_garmin/mkgmap/trunk/build/classes [javac] /home/maning/osm/routable_garmin/mk

Re: [mkgmap-dev] [PATCH v4] sea polygons

2009-08-17 Thread Clinton Gladstone
On Sun, Aug 16, 2009 at 12:49 AM, Christian Gawron wrote: > With this version of the patch, the intersection of the bounding box and the > landmass does not have to be simply connected as in version 3 of the patch. Hm... I tried out this patch with a tiled map of Germany. The results were kind of

Re: [mkgmap-dev] [PATCH v4] sea polygons

2009-08-18 Thread Robert Joop
On 09-08-17 17:38:46 CEST, Clinton Gladstone wrote: > On Sun, Aug 16, 2009 at 12:49 AM, Christian > Gawron wrote: > > > With this version of the patch, the intersection of the bounding box and the > > landmass does not have to be simply connected as in version 3 of the patch. > > Hm... I tried ou

Re: [mkgmap-dev] [PATCH v4] sea polygons

2009-08-20 Thread Christian Gawron
Thanks for the feedback! One trivial bug in the patch was that a tile with no shoreline at all got a sea polygon as "background". This can be fixed by adding // don't do anything if there is no shoreline if (shoreline.size() == 0) return; at the begin of generateSeaPolygon

Re: [mkgmap-dev] [PATCH v4] sea polygons

2009-08-20 Thread Robert Joop
On 09-08-20 21:42:23 CEST, Christian Gawron wrote: > Thanks for the feedback! > > One trivial bug in the patch was that a tile with no shoreline at all > got a sea polygon as "background". > This can be fixed by adding > // don't do anything if there is no shoreline > if (shorelin