[mkgmap-dev] Patch to reduce memory usage by interning strings.

2011-10-20 Thread Kristen Eisenberg
On 31/03/10 14:56, Scott A Crosby wrote: I noticed that mkgmap does not intern any strings. In particular, this This is true. There is a pending patch that deals with excessive memory use in a slightly different way which is on the style-speed branch, with a pre-built one available at the

Re: [mkgmap-dev] Patch to reduce memory usage by interning strings.

2011-10-20 Thread Steve Ratcliffe
On 20/10/11 19:57, Kristen Eisenberg wrote: On 31/03/10 14:56, Scott A Crosby wrote: I noticed that mkgmap does not intern any strings. In particular, this This is true. There is a pending patch that deals with excessive memory use in a slightly different way which is on the style-speed

Re: [mkgmap-dev] Patch to reduce memory usage by interning strings.

2010-04-02 Thread WanMil
Am 02.04.2010 06:16, schrieb Scott A Crosby: On Thu, 01 Apr 2010 12:10:22 +0100, Steve Ratcliffest...@parabola.me.uk writes: On 31/03/10 14:56, Scott A Crosby wrote: I noticed that mkgmap does not intern any strings. In particular, this This is true. There is a pending patch that deals

Re: [mkgmap-dev] Patch to reduce memory usage by interning strings.

2010-04-01 Thread Steve Ratcliffe
On 31/03/10 14:56, Scott A Crosby wrote: I noticed that mkgmap does not intern any strings. In particular, this This is true. There is a pending patch that deals with excessive memory use in a slightly different way which is on the style-speed branch, with a pre-built one available at the

Re: [mkgmap-dev] Patch to reduce memory usage by interning strings.

2010-04-01 Thread Chris Miller
I think the point that Chris brought up applies mostly in cases where there is a lot of contended access between threads. If that is the case then it won't matter much for us as reading the input files is currently single threaded. It's true, the biggest gains by far in the approach I was

Re: [mkgmap-dev] Patch to reduce memory usage by interning strings.

2010-04-01 Thread Scott A Crosby
On Wed, 31 Mar 2010 23:58:45 +0200, WanMil wmgc...@web.de writes: Am 31.03.2010 22:10, schrieb Scott A Crosby: On Wed, 31 Mar 2010 21:13:49 +0200, WanMilwmgc...@web.de writes: my patch interned all keys and additionally the values of a limited number of keys. Maybe it's not necessary to

Re: [mkgmap-dev] Patch to reduce memory usage by interning strings.

2010-04-01 Thread Scott A Crosby
On Wed, 31 Mar 2010 22:12:12 + (UTC), Chris Miller chris_overs...@hotmail.com writes: Note that Java's String.intern() method can be pretty slow, so while you'll save a fair chunk of memory you'll potentially suffer a noticable performance hit too if you're calling it a lot. By adding a

Re: [mkgmap-dev] Patch to reduce memory usage by interning strings.

2010-04-01 Thread Scott A Crosby
On Thu, 01 Apr 2010 12:10:22 +0100, Steve Ratcliffe st...@parabola.me.uk writes: On 31/03/10 14:56, Scott A Crosby wrote: I noticed that mkgmap does not intern any strings. In particular, this This is true. There is a pending patch that deals with excessive memory use in a slightly

[mkgmap-dev] Patch to reduce memory usage by interning strings.

2010-03-31 Thread Scott A Crosby
I noticed that mkgmap does not intern any strings. In particular, this tile, generated by the splitter, fails to build with -Xmx3000m on 64-bit jdk under linux. With my patch, mkgmap generates the tile with -Xmx1000m. bounds minlat='55.1953125' minlon='9.4921875' maxlat='56.6015625'

Re: [mkgmap-dev] Patch to reduce memory usage by interning strings.

2010-03-31 Thread WanMil
I noticed that mkgmap does not intern any strings. In particular, this tile, generated by the splitter, fails to build with -Xmx3000m on 64-bit jdk under linux. With my patch, mkgmap generates the tile with -Xmx1000m. bounds minlat='55.1953125' minlon='9.4921875' maxlat='56.6015625'

Re: [mkgmap-dev] Patch to reduce memory usage by interning strings.

2010-03-31 Thread Scott A Crosby
On Wed, 31 Mar 2010 21:13:49 +0200, WanMil wmgc...@web.de writes: I noticed that mkgmap does not intern any strings. In particular, this tile, generated by the splitter, fails to build with -Xmx3000m on 64-bit jdk under linux. With my patch, mkgmap generates the tile with -Xmx1000m.

Re: [mkgmap-dev] Patch to reduce memory usage by interning strings.

2010-03-31 Thread WanMil
Am 31.03.2010 22:10, schrieb Scott A Crosby: On Wed, 31 Mar 2010 21:13:49 +0200, WanMilwmgc...@web.de writes: I noticed that mkgmap does not intern any strings. In particular, this tile, generated by the splitter, fails to build with -Xmx3000m on 64-bit jdk under linux. With my patch, mkgmap

Re: [mkgmap-dev] Patch to reduce memory usage by interning strings.

2010-03-31 Thread Chris Miller
Note that Java's String.intern() method can be pretty slow, so while you'll save a fair chunk of memory you'll potentially suffer a noticable performance hit too if you're calling it a lot. By adding a barrier-free caching layer in front of the String.intern() calls you can gain a reasonable