Re: [mkgmap-dev] Possible optimization of StyledConverter

2012-01-12 Thread Gerd Petermann
slow down the program? Gerd Date: Sun, 8 Jan 2012 21:49:14 + From: st...@parabola.me.uk To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] Possible optimization of StyledConverter Hi hmm, do you think about storing the information in e.g. a bitmask rather than in tags

Re: [mkgmap-dev] Possible optimization of StyledConverter

2012-01-08 Thread Steve Ratcliffe
Hi hmm, do you think about storing the information in e.g. a bitmask rather than in tags? Yes, if I had done that part, I would have tried to go directly from osm tags to properties on the Element, rather than the two stage process of osm tag to mkgmap:* tag. ..Steve

Re: [mkgmap-dev] Possible optimization of StyledConverter

2012-01-07 Thread Gerd Petermann
Hello Steve, My example of amenity was probably a bad one to include, since I was only looking at amenity=restaurant, and it may not be benificial with other values. I'm would be suprised that the highway one did not make an improvement. But in any case, I didn't see a difference in

Re: [mkgmap-dev] Possible optimization of StyledConverter

2012-01-06 Thread Steve Ratcliffe
Hi thanks for the explanation, I'll verify my assumptions. Regarding your patch: I see a change in the number of evaluated rules, but it is is slightly higher with the patch. I think this proves that my understanding is wrong, but the patch is probably too special, means, it has to be

Re: [mkgmap-dev] Possible optimization of StyledConverter

2012-01-05 Thread Steve Ratcliffe
Hi The point that I have in mind is this: Style files typically have many different rules starting with e.g. highway=* ... The current iplementation in RuleSet.java and RuleIndex.java will first create a set of all rules that might match for the existing tags of a given element. Next, it

[mkgmap-dev] Possible optimization of StyledConverter

2012-01-04 Thread GerdP
Steve, WanMil, the discussion about a prepro for styles inspired me to think about a compiler/optimizer for style rules. The point that I have in mind is this: Style files typically have many different rules starting with e.g. highway=* ... The current iplementation in RuleSet.java and