I think the patch after meth-lazy needs rebasing. Just comment it out in the
series file for now.
how could I comment it ?
___
mlvm-dev mailing list
mlvm-dev@openjdk.java.net
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
Am Montag, den 23.07.2012, 09:47 +0200 schrieb Henri Gomez:
I think the patch after meth-lazy needs rebasing. Just comment it out in
the series file for now.
how could I comment it ?
Edit the series file with a text editor and prefix the line that shows
the name of that patch with # .
Edit the series file with a text editor and prefix the line that shows
the name of that patch with # .
Thanks Roman
Since it won't be in phase with mlvm mercurial repo, I should patch it
after syncing, right ?
___
mlvm-dev mailing list
On 07/22/2012 03:45 AM, John Rose wrote:
On Jul 18, 2012, at 1:43 AM, Aleksey Shipilev wrote:
Yes.
Thanks John. I'm having a glance over the fix in new webrev, and this
feels even worse:
+ private static SpeciesData get(String types) {
+// Acquire cache lock for query.
+
On 07/22/2012 04:16 AM, John Rose wrote:
P.S. If there's something you don't like in one of the files, let us know.
As I noted before, we can (and will) roll more adjustments into the next
push.
I have a question about $PREPARED_FORMS there. It looks like it is not
used anywhere in the code,
Changeset: a8cb0e14256a
Author:twisti
Date: 2012-07-23 10:12 -0700
URL: http://hg.openjdk.java.net/mlvm/mlvm/hotspot/rev/a8cb0e14256a
meth-lazy: fixed 32-bit SPARC C1 problem
! meth-lazy-7023639.review.patch
___
mlvm-dev mailing list
Changeset: b078b2c12089
Author:jrose
Date: 2012-07-23 10:36 -0700
URL: http://hg.openjdk.java.net/mlvm/mlvm/hotspot/rev/b078b2c12089
meth-lazy: consolidate for review
! meth-lazy-7023639.patch
- meth-lazy-7023639.review.patch
! series
Changeset: 0cd0e35d7fe6
Author:jrose
Date: 2012-07-23 10:44 -0700
URL: http://hg.openjdk.java.net/mlvm/mlvm/jdk/rev/0cd0e35d7fe6
meth-lazy: consolidate for review
! meth-lazy-7023639.patch
- meth-lazy-7023639.review.patch
! series
___
John,
Both webrevs point to jdk changes. Where are hotspot changes?
Vladimir
John Rose wrote:
On Jul 13, 2012, at 2:41 AM, John Rose wrote:
Here is that webrev:
http://cr.openjdk.java.net/~jrose/7023639/webrev.jdk.00/
These are the changes to JDK code that accompany the JVM changes
On Jul 23, 2012, at 2:27 AM, Aleksey Shipilev wrote:
Global synchronization is the performance smell, and this looks to be
potential scalability bottleneck (it sends shivers down my spine every
time I see static synchronized in the same line. That is not to
mention synchronizing on
On Jul 23, 2012, at 11:15 AM, Vladimir Kozlov wrote:
Both webrevs point to jdk changes. Where are hotspot changes?
Oops, fixed. Please try again:
http://cr.openjdk.java.net/~jrose/7023639/webrev.01/
http://cr.openjdk.java.net/~jrose/7023639/webrev.jdk.01/
— John
11 matches
Mail list logo
