Doh! crossed webrevs, thanks.
Just had a quick look, this looks like a really nice improvement to the array
setter/getter support, definitely simplified. IIUC the mh.viewAsType will now handle the
appropriate casting. I believe it might reduce the "ceremony" for array
setter/getter MHs [1].
I
On Mar 14, 2014, at 2:17 PM, Vladimir Ivanov
wrote:
> Paul,
>
> You are looking at the other fix (8037210).
> The correct link is [1].
>
Doh! crossed webrevs, thanks.
Just had a quick look, this looks like a really nice improvement to the array
setter/getter support, definitely simplified.
To get into this faster it would be nice if the new private fields (or the
existing ones for that matter) had a comment describing what they were for, e.g.
+ private final byte[] localTypes;
+ private final Class[] localClasses;
I can figure it out from the code, but it would have been a
Paul,
You are looking at the other fix (8037210).
The correct link is [1].
Best regards,
Vladimir Ivanov
[1]
http://cr.openjdk.java.net/~vlivanov/8037209/webrev.00/src/share/classes/java/lang/invoke/MethodHandleImpl.java.sdiff.html
On 3/14/14 4:38 PM, Paul Sandoz wrote:
On Mar 14, 2014, at
On Mar 14, 2014, at 1:19 PM, Vladimir Ivanov
wrote:
> FYI, this change isn't limited to only bytecode assembly improvements, but
> also contains caching of lambda forms for setters/getter of typed arrays.
>
Do you mean for MethodHandles.arrayElementGetter/Setter? If so i don't see
relevant
FYI, this change isn't limited to only bytecode assembly improvements,
but also contains caching of lambda forms for setters/getter of typed
arrays.
If there are any objections, I can back the caching logic out and
include it into one of upcoming changes.
Best regards,
Vladimir Ivanov
On 3/
http://cr.openjdk.java.net/~vlivanov/8037209/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8037209
440 lines changed: 313 ins; 67 del; 60 mod
This is a cleanup of JSR292 code to improve bytecode assembly code for
lambda forms.
Contributed-by: john.r.r...@oracle.com
Testing: jdk/java/{la
http://cr.openjdk.java.net/~vlivanov/8037210/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8037210
953 lines changed: 425 ins; 217 del; 311 mod
This is a massive cleanup of JSR292 code to replace char-based
description of basic types by numeric constants.
Contributed-by: john.r.r...@orac
