In my opinion, there are two issues here,
the first one is the extra Class.cast which is inserted and as John said
it should be interesting to try to remove them.
the second one is why when there is a Class.cast, the cast is
effectively removed but a null check stay.
regards,
Rémi
On 07/08/20
Regarding the extra cast in accessor logic that Paul picked up on: That may be
a left-over from obsolete versions of the code, or it may cover for some corner
cases, or it could possibly be a re-assurance to the JIT.
Generally speaking, we lean heavily on MH types to guarantee a priori
correct
>>> I'd like to revive review this review thread.
Updated version:
http://cr.openjdk.java.net/~vlivanov/8038261/webrev.03/
+1
A v. minor point. There is one newly added method
InvokerBytecodeGenerator.match that is not used by this patch or the other one
for 8037209. I dunno if it will be us
On Jul 8, 2014, at 12:09 PM, Vladimir Ivanov
wrote:
> I'd like to revive this review thread.
>
> Updated version:
> http://cr.openjdk.java.net/~vlivanov/8037209/webrev.04/
>
Seems ok. I don't claim to be knowledgable enough in the finer points of
conversion/casting/verification but i could se
On Jul 8, 2014, at 12:40 PM, Paul Sandoz wrote:
>
> On Jul 8, 2014, at 12:09 PM, Vladimir Ivanov
> wrote:
>
>> I'd like to revive review this review thread.
>>
>> Updated version:
>> http://cr.openjdk.java.net/~vlivanov/8038261/webrev.03/
>>
>
> +1
>
A v. minor point. There is one newly
On Jul 8, 2014, at 12:09 PM, Vladimir Ivanov
wrote:
> I'd like to revive review this review thread.
>
> Updated version:
> http://cr.openjdk.java.net/~vlivanov/8038261/webrev.03/
>
+1
Paul.
signature.asc
Description: Message signed with OpenPGP using GPGMail
__
I'd like to revive review this review thread.
Updated version:
http://cr.openjdk.java.net/~vlivanov/8038261/webrev.03/
Thanks!
Best regards,
Vladimir Ivanov
On 3/24/14 10:10 PM, Vladimir Ivanov wrote:
http://cr.openjdk.java.net/~vlivanov/8038261/webrev.00
https://bugs.openjdk.java.net/browse/
I'd like to revive this review thread.
Updated version:
http://cr.openjdk.java.net/~vlivanov/8037209/webrev.04/
Paul, I'd like to address your case (if possible) separately. Right now,
I don't see any way to avoid null check you see with your tests.
Best regards,
Vladimir Ivanov
On 3/24/14 8
