Re: [9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

2014-11-10 Thread Vladimir Ivanov
Kontantin, sorry for the late response. In general, the fix looks good. I'd move timeout computation logic to Utils: +private static final long TIMEOUT = Utils.adjustTimeout(TimeUnit.SECONDS.toMillis(120)); Default value (120s) isn't specific to the tests, but an implementation detail

Re: [9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

2014-11-10 Thread Konstantin Shefov
Vladimir, thanks for reviewing I have updated the webrev: http://cr.openjdk.java.net/~kshefov/8059070/webrev.02 I have added DEFAULT_TEST_TIMEOUT constant to Utils class. -Konstantin On 10.11.2014 14:33, Vladimir Ivanov wrote: Kontantin, sorry for the late response. In general, the fix