Re: Need to access syntactic method out of package using Bootstrap attribute

2015-06-17 Thread Remi Forax
Hi Puneet, On 06/17/2015 06:58 PM, Vladimir Ivanov wrote: Puneet, How did you end up with such bytecode? Was it generated by javac? Rejecting access to a method which is not visible from the context where invokedynamic is linked is the correct behavior. The error you describe is weird, the

[9] Review request : JDK-8067005 : Several java/lang/invoke tests fail due to exhausted code cache

2015-06-17 Thread Konstantin Shefov
Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8067005 Webrev is http://cr.openjdk.java.net/~kshefov/8067005/webrev.00/ Thanks -Konstantin ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net

Re: [9] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option

2015-06-17 Thread Konstantin Shefov
Hello, I have updated the fix once more http://cr.openjdk.java.net/~kshefov/8062904/webrev.03/ Please, review Thanks -Konstantin On 06/16/2015 02:01 PM, Konstantin Shefov wrote: Hello, Please, review the new version of the fix to this issue

Re: [9] Review request : JDK-8067005 : Several java/lang/invoke tests fail due to exhausted code cache

2015-06-17 Thread Vladimir Ivanov
Konstantin, I'd move isThrowableCausedByVME processVME from Utils to a more specific place (new shared class for JSR292 tests?). They aren't general enough to be useful for other tests. Also, processVME name is confusing. I'd introduce something like a runMHTest wrapper and process

Re: [9] Review request : JDK-8067005 : Several java/lang/invoke tests fail due to exhausted code cache

2015-06-17 Thread Vladimir Ivanov
Looks good. Best regards, Vladimir Ivanov On 6/17/15 7:23 PM, Konstantin Shefov wrote: Vladimir, I have updated the webrev: http://cr.openjdk.java.net/~kshefov/8067005/webrev.01/ -Konstantin On 06/17/2015 04:01 PM, Vladimir Ivanov wrote: Konstantin, I'd move isThrowableCausedByVME

Re: Need to access syntactic method out of package using Bootstrap attribute

2015-06-17 Thread Vladimir Ivanov
Puneet, How did you end up with such bytecode? Was it generated by javac? Rejecting access to a method which is not visible from the context where invokedynamic is linked is the correct behavior. Best regards, Vladimir Ivanov On 6/5/15 6:59 AM, Bansal, Puneet wrote: Hi All I got an

Re: [9] Review request : JDK-8067005 : Several java/lang/invoke tests fail due to exhausted code cache

2015-06-17 Thread Konstantin Shefov
Vladimir, I have updated the webrev: http://cr.openjdk.java.net/~kshefov/8067005/webrev.01/ -Konstantin On 06/17/2015 04:01 PM, Vladimir Ivanov wrote: Konstantin, I'd move isThrowableCausedByVME processVME from Utils to a more specific place (new shared class for JSR292 tests?). They