Re: Use of JDK interanl ASM vs external

2015-02-18 Thread Alan Bateman
On 18/02/2015 11:21, Remi Forax wrote: Currently, the version of ASM shipped with the JDK is a customized version compiled directly from the trunk and lightly patched to bubble up some internal methods that are not part of the public API. In jdk8 world, it's an internal API and you should

Re: [9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

2014-10-16 Thread Alan Bateman
On 16/10/2014 10:30, Paul Sandoz wrote: : 45 private static final long TIMEOUT = 30; Does jtreg define a system property for this value? and is 300s the same as what jtreg defines as the default? The online documentation (jtreg -onlineHelp) says the default is 2 minutes, but that

Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

2014-09-05 Thread Alan Bateman
On 05/09/2014 18:57, Konstantin Shefov wrote: Hello, Please review the change in testlibrary https://bugs.openjdk.java.net/browse/JDK-8057707 This change is needed for new tests for the feature Lambda Form Reduction and Caching https://bugs.openjdk.java.net/browse/JDK-8046703 Webrev of the

Re: RFR: 8022749: Convert junit tests to testng in test/java/lang/invoke

2013-09-13 Thread Alan Bateman
On 10/08/2013 01:25, Henry Jen wrote: Hi, Please review a webrev contributed by Mani Sarkar that converts junit tests in test/java/lang/invoke to testng. http://cr.openjdk.java.net/~henryjen/tl/8022749/0/webrev/ Cheers, Henry This looks good to me (but cc'ing mlvm-dev so that