Re: Coro patch

2011-11-30 Thread Lukas Stadler
On 2011-11-30 08:49, Charles Oliver Nutter wrote: Seconds after I email...A DISCOVERY... It seems like invokedynamic is causing headaches for coro. Here's the numbers with coro fibers and JRuby's invokedynamic support turned *off*: 100 fibers / 1000 passes: 0.076000 0.00 0.076000

Re: Coro patch

2011-11-30 Thread Charles Oliver Nutter
On Wed, Nov 30, 2011 at 4:17 AM, Lukas Stadler lukas.stad...@jku.at wrote: Hm, maybe... the fix was really just a tiny tiny bugfix, so that shouldn't have caused any performance regressions, although, of course, I can't say for sure. But maybe something in invokedynamic has changed so that

Re: Coro patch

2011-11-30 Thread Lukas Stadler
optimizing as well as it should. Exactly. It's still a bug in the coro patch, since it shouldn't impact performance that way. Has your usage of invokedynamic changed a lot since the last perfect performance numbers with invokedynamic? The numbers on your blog would not have been using invokedynamic

Re: Coro patch

2011-11-30 Thread Mark Roos
Hi Charles Interesting results. Is your code for the coro implementation available somewhere to look at? thanks mark___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

Re: Coro patch

2011-11-30 Thread Charles Oliver Nutter
On Wed, Nov 30, 2011 at 11:57 AM, Mark Roos mr...@roos.com wrote: Hi Charles Interesting results.  Is your code for the coro implementation available somewhere to look at? On master and jruby-1_6 branch, under src/org/jruby/ext/fiber/CoroutineFiber.java. It's Lukas's code, mostly.

Re: Coro patch

2011-11-29 Thread Lukas Stadler
...@gmail.com: Le 6 nov. 2011 à 22:12, Henri Gomezhenri.go...@gmail.com a écrit : Hi to all, I'm looking for Coro patch by Lukas Stadler, any body knows where I can find it ? More on this, I found patch here (http://hg.openjdk.java.net/mlvm/mlvm/jdk/rev/ca450b9f8b56), but wondering if it's

Re: Coro patch

2011-11-29 Thread Charles Oliver Nutter
6 nov. 2011 à 22:12, Henri Gomez henri.go...@gmail.com a écrit : Hi to all, I'm looking for Coro patch by Lukas Stadler, any body knows where I can find it ? More on this, I found patch here (http://hg.openjdk.java.net/mlvm/mlvm/jdk/rev/ca450b9f8b56), but wondering if it's allready applied

Re: Coro patch

2011-11-29 Thread Henri Gomez
Awesome, thanks Lukas! Hopefully when the next openjdk-osx-build runs, it will pick up these changes, and we'll have a working coro impl on OS X too :) Oops, forgot to tweet about it yesterday. http://openjdk-osx-build.googlecode.com/files/OpenJDK-1.8-x86_64-b11-2029-release.dmg Cheers

Re: Coro patch

2011-11-29 Thread Charles Oliver Nutter
Ok, good news and not as good news! The good news is that coro seems to be working in the latest openjdk-osx-build, and it definitely improves JRuby's coroutine performance! For running bench_fiber_ring with 100 fibers passing 1000 messages, here's numbers for the threaded impl: 100 fibers /

Re: Coro patch

2011-11-29 Thread Charles Oliver Nutter
Seconds after I email...A DISCOVERY... It seems like invokedynamic is causing headaches for coro. Here's the numbers with coro fibers and JRuby's invokedynamic support turned *off*: 100 fibers / 1000 passes: 0.076000 0.00 0.076000 ( 0.077000) 100 fibers / 1000 passes: 0.076000

Coro patch

2011-11-06 Thread Henri Gomez
Hi to all, I'm looking for Coro patch by Lukas Stadler, any body knows where I can find it ? ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

Re: Coro patch

2011-11-06 Thread Lukas Stadler
On Nov 6, 2011, at 22:12 , Henri Gomez wrote: Hi to all, I'm looking for Coro patch by Lukas Stadler, any body knows where I can find it ? ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

Re: Coro patch

2011-11-06 Thread Henri Gomez
Ok, I get them and coro is included in OpenJDK 8 from openjdk-osx-build 2011/11/6 Henri Gomez henri.go...@gmail.com: Le 6 nov. 2011 à 22:12, Henri Gomez henri.go...@gmail.com a écrit : Hi to all, I'm looking for Coro patch by Lukas Stadler, any body knows where I can find it ? More

Re: Coro patch

2011-11-06 Thread Charles Oliver Nutter
henri.go...@gmail.com: Le 6 nov. 2011 à 22:12, Henri Gomez henri.go...@gmail.com a écrit : Hi to all, I'm looking for Coro patch by Lukas Stadler, any body knows where I can find it ? More on this, I found patch here (http://hg.openjdk.java.net/mlvm/mlvm/jdk/rev/ca450b9f8b56

fyi: coro patch still won't build coroutine.o on Mac OS X

2011-01-11 Thread Stephen Bannasch
FYI: still can't compile coroutine.o on Mac OS X warning that NULL used in arithmetic. Building with guards=buildable testable coro still produces these compilation warnings (with the -Werror compiler flag being used warnings are treated as errors):

Re: coro patch issue

2010-05-12 Thread Lukas Stadler
version. Only coro patch is applied. Though it didn't apply cleanly with latest code base, the issue is minor and I fixed it by some trivial editing on the patch. The patched sources compiled fine, but generated a error when yielding to coroutine: # To suppress the following error report

Re: coro patch issue

2010-05-12 Thread Tuolin Chen
On 11.05.2010 16:45, Tuolin Chen wrote: Hi all, I'm new to mlvm and I'm trying to get Lukas' coro.patch to work. I grabbed the source and patches according to openjdk and mlvm build instructions. Everything is done on my laptop running Ubuntu 10.04 64bit version. Only coro patch is applied

coro patch issue

2010-05-11 Thread Tuolin Chen
Hi all, I'm new to mlvm and I'm trying to get Lukas' coro.patch to work. I grabbed the source and patches according to openjdk and mlvm build instructions. Everything is done on my laptop running Ubuntu 10.04 64bit version. Only coro patch is applied. Though it didn't apply cleanly with latest

Re: coro patch issue

2010-05-11 Thread Tuolin Chen
on my laptop running Ubuntu 10.04 64bit version. Only coro patch is applied. Though it didn't apply cleanly with latest code base, the issue is minor and I fixed it by some trivial editing on the patch. Unless you are attempting a forward-port, the patches should only be attempted