Re: Push invalidation + bimorphic fix

2011-08-17 Thread Charles Oliver Nutter
For depth I am using 5 as the limit, but it is just a rough guess based on empirical comparisons of chained GWT versus our inline cache. I need to reevaluate with recent patches in place. By "wipe out" I mean clear the call site's target and start over with a new GWT chain. - Charlie (mobile)

Re: Push invalidation + bimorphic fix

2011-08-17 Thread Mark Roos
>From Charlie * If we encounter a new type at a call site and have not exceeded our GWT cascade limit, we add it to the chain. * If we exceed the limit of GWT chaining, wipe out the site and switch it permanently to an inline cache Charlie, what is the depth limit you set and how did you arrive

Re: Push invalidation + bimorphic fix

2011-08-17 Thread Charles Oliver Nutter
On Tue, Aug 9, 2011 at 2:43 PM, Tom Rodriguez wrote: >> Same numbers. Is there some other patch you have applied locally? >> What's the best way for me to investigate? > > Can you collect PrintCompilation/PrintInlining output for each of these? I shall, if I can reproduce it again. I've moved on

Re: Push invalidation + bimorphic fix

2011-08-16 Thread Tom Rodriguez
On Aug 9, 2011, at 12:02 PM, Charles Oliver Nutter wrote: > On Tue, Aug 9, 2011 at 2:31 PM, Charles Oliver Nutter > wrote: >> On Tue, Aug 9, 2011 at 4:30 AM, Christian Thalinger >> wrote: >>> Hmm. I remember you were saying this is some old Ultra 20. The only box I >>> could find which is si

Re: Push invalidation + bimorphic fix

2011-08-09 Thread Charles Oliver Nutter
On Tue, Aug 9, 2011 at 2:31 PM, Charles Oliver Nutter wrote: > On Tue, Aug 9, 2011 at 4:30 AM, Christian Thalinger > wrote: >> Hmm.  I remember you were saying this is some old Ultra 20.  The only box I >> could find which is similar is a 2.0GHz Quad-core Opteron running Solaris >> and I can't

Re: Push invalidation + bimorphic fix

2011-08-09 Thread Charles Oliver Nutter
On Tue, Aug 9, 2011 at 4:30 AM, Christian Thalinger wrote: > Hmm.  I remember you were saying this is some old Ultra 20.  The only box I > could find which is similar is a 2.0GHz Quad-core Opteron running Solaris and > I can't confirm your numbers. Hmm, interesting. I'll give it another shot to

Re: Push invalidation + bimorphic fix

2011-08-09 Thread Christian Thalinger
On Aug 9, 2011, at 7:58 AM, Charles Oliver Nutter wrote: > I have set up a local build against "hsx" hotspot compiler dev branch, > thanks to Christian. I'll try to write something up with the process > tomorrow. > > Anyway, I wanted to test out Tom's patch for GWT bimorphic inlining > and Chris

Push invalidation + bimorphic fix

2011-08-08 Thread Charles Oliver Nutter
I have set up a local build against "hsx" hotspot compiler dev branch, thanks to Christian. I'll try to write something up with the process tomorrow. Anyway, I wanted to test out Tom's patch for GWT bimorphic inlining and Christian's patch for push invalidation of mutable call sites. The results w