Re: ClassValue perf?

2016-05-19 Thread Michael Haupt
Hi Christian, > Am 06.05.2016 um 22:35 schrieb Christian Thalinger > : >> Given that one concern with this issue, next to reducing footprint, was to >> optimise for the single-value case, I'm still a bit hesitant even though the >> sheer amount of code reduction is impressive. I'll evaluate fur

Re: ClassValue perf?

2016-05-19 Thread Michael Haupt
Hi Peter,thank you. As some background info, the machine I'm running the benchmarks on is a 32-core Xeon.Results of running your latest benchmarks with unmodified 9-dev and your two patches (02, 03) are attached. Overall, it seems your solution 03 is a bit slower than 02, and 02 shines especially i

Re: ClassValue perf?

2016-05-19 Thread Aleksey Shipilev
On 05/19/2016 03:32 PM, Michael Haupt wrote: > It may well be that running the bechmark so few times does not deliver a > stable enough result. I'd like Aleksey to comment on this: is adopting > Peter's code worthwhile given it improves on footprint and reduces code > size and complexity? Eh, if y

Question in understanding ClassValue better

2016-05-19 Thread Jochen Theodorou
Hi, at the beginning of this year I had an exchange with Peter Lavart about JDK-8136353 (see http://mail.openjdk.java.net/pipermail/mlvm-dev/2016-January/006563.html), and that is probably based on wrong assumptions. But I must confess I still have trouble understanding ClassValue semantics.

Re: Question in understanding ClassValue better

2016-05-19 Thread Peter Levart
Hi Jochen, I'll try to answer your questions as profoundly as I can... On 05/19/2016 04:27 PM, Jochen Theodorou wrote: Hi, at the beginning of this year I had an exchange with Peter Lavart about JDK-8136353 (see http://mail.openjdk.java.net/pipermail/mlvm-dev/2016-January/006563.html), and

Re: Question in understanding ClassValue better

2016-05-19 Thread Peter Levart
A small correction... On 05/19/2016 09:32 PM, Peter Levart wrote: // the public API public MetaClass getInstanceFor(Class type) { This should of course read: // the public API public *static* MetaClass getInstanceFor(Class type) { Regards, Peter __

Re: Question in understanding ClassValue better

2016-05-19 Thread Jochen Theodorou
On 19.05.2016 21:32, Peter Levart wrote: [...] a ClassValue instance can be thought of as a component of a compound key. Together with a Class, they form a tuple (aClass, aClassValue) that can be associated with an "associated value", AV. And yes, the AVs associated with tuple containing a partic