Re: mbm plugin gps improvements

2016-01-29 Thread Tomas Jura
On 29.1.2016 17:31, Aleksander Morgado wrote: On Fri, Jan 29, 2016 at 1:00 AM, Tomas Jura wrote: The quick open/close action after the gps unmanaged end (patch #4 "flush unmanaged GPS port after GPS is stopped") serves for draining the remaining GPS sentences from the gps port. Without the drai

Re: mbm plugin gps improvements

2016-01-29 Thread Tomas Jura
On 29.1.2016 16:25, Dan Williams wrote: The #6 - "Do not restore termios on port close" is a controversial patch. It has the wide impact and definitely can introduce nasty regressions. It is possible that some code could depend on the restore of the term setup. But such dependency is IMHO danger

Re: mbm plugin gps improvements

2016-01-29 Thread Aleksander Morgado
On Fri, Jan 29, 2016 at 1:00 AM, Tomas Jura wrote: > The quick open/close action after the gps unmanaged end (patch #4 "flush > unmanaged GPS port after GPS is stopped") serves for draining the remaining > GPS sentences from the gps port. Without the drain some gps sentences can > remain in the in

Re: mbm plugin gps improvements

2016-01-29 Thread Dan Williams
On Fri, 2016-01-29 at 01:00 +0100, Tomas Jura wrote: > Hi Alex > > Thanks for the feedback. The patches layout got broken due to my > email > client. Before I incorporate your comments I and send it in regular > for > review, I created a temporary git repo to see the patches in clear > format: