[PATCH 3/3] iface-modem-voice: port mm_iface_modem_voice_disable to use GTask

--- src/mm-iface-modem-voice.c | 89 -- 1 file changed, 47 insertions(+), 42 deletions(-) diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c index b075796b..73fb314a 100644 --- a/src/mm-iface-modem-voice.c +++ b/src/mm-iface-modem-voic

[PATCH 4/4] iface-modem-time: port update_network_timezone to use GTask

--- src/mm-iface-modem-time.c | 120 +++--- 1 file changed, 61 insertions(+), 59 deletions(-) diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c index eec340ed..41ca2f0e 100644 --- a/src/mm-iface-modem-time.c +++ b/src/mm-iface-modem-time.c

[PATCH 2/4] iface-modem-time: port mm_iface_modem_time_enable to use GTask

--- src/mm-iface-modem-time.c | 108 +- 1 file changed, 49 insertions(+), 59 deletions(-) diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c index efb8d386..74e497e7 100644 --- a/src/mm-iface-modem-time.c +++ b/src/mm-iface-modem-time.c

[PATCH 1/4] iface-modem-time: port mm_iface_modem_time_initialize to use GTask

--- src/mm-iface-modem-time.c | 93 --- 1 file changed, 40 insertions(+), 53 deletions(-) diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c index 85588d3f..efb8d386 100644 --- a/src/mm-iface-modem-time.c +++ b/src/mm-iface-modem-time.c

[PATCH 2/3] iface-modem-voice: port mm_iface_modem_voice_enable to use GTask

--- src/mm-iface-modem-voice.c | 108 - 1 file changed, 49 insertions(+), 59 deletions(-) diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c index 2a93907f..b075796b 100644 --- a/src/mm-iface-modem-voice.c +++ b/src/mm-iface-modem-voic

[PATCH 3/4] iface-modem-time: port mm_iface_modem_time_disable to use GTask

--- src/mm-iface-modem-time.c | 91 +-- 1 file changed, 48 insertions(+), 43 deletions(-) diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c index 74e497e7..eec340ed 100644 --- a/src/mm-iface-modem-time.c +++ b/src/mm-iface-modem-time.c

[PATCH 1/3] iface-modem-voice: port mm_iface_modem_voice_initialize to use GTask

--- src/mm-iface-modem-voice.c | 97 -- 1 file changed, 42 insertions(+), 55 deletions(-) diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c index ca65238b..2a93907f 100644 --- a/src/mm-iface-modem-voice.c +++ b/src/mm-iface-modem-voic

[PATCH 3/3] iface-modem-oma: port mm_iface_modem_oma_disable to use GTask

--- src/mm-iface-modem-oma.c | 87 +--- 1 file changed, 46 insertions(+), 41 deletions(-) diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c index 46aef277..8a7cc08f 100644 --- a/src/mm-iface-modem-oma.c +++ b/src/mm-iface-modem-oma.c @@ -

[PATCH 2/3] iface-modem-oma: port mm_iface_modem_oma_enable to use GTask

--- src/mm-iface-modem-oma.c | 125 ++- 1 file changed, 59 insertions(+), 66 deletions(-) diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c index 03e3deb6..46aef277 100644 --- a/src/mm-iface-modem-oma.c +++ b/src/mm-iface-modem-oma.c @@ -

[PATCH 1/3] iface-modem-oma: port mm_iface_modem_oma_initialize to use GTask

--- src/mm-iface-modem-oma.c | 99 +--- 1 file changed, 43 insertions(+), 56 deletions(-) diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c index b8c48417..03e3deb6 100644 --- a/src/mm-iface-modem-oma.c +++ b/src/mm-iface-modem-oma.c @@ -

[PATCH] mm-broadband-modem-mbim: support hot swapping

If an MBIM modem supports unsolicited notifications for subscriber ready status, we can use it to detect when SIM cards have been removed and reinserted. Upon detection we should re- probe the modem so that we can configure it for the new SIM. --- src/mm-broadband-modem-mbim.c | 16 +++

Re: [PATCH 1/1] telit: port mm-common-telit to use GTask

HI Aleksander, 2017-06-28 18:44 GMT+02:00 Aleksander Morgado : > Hey Daniele, > > See comments below. > > On 28/06/17 16:07, Daniele Palmas wrote: >> --- >> plugins/telit/mm-common-telit.c | 64 >> +++-- >> 1 file changed, 29 insertions(+), 35 deletions(-) >>

Re: [PATCH 2/3] iface-modem-3gpp-ussd: port mm_iface_modem_3gpp_ussd_enable to use GTask

On 28/06/17 18:30, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp-ussd.c | 73 > ++ > 1 file changed, 39 insertions(+), 34 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp-ussd.c b/src/mm-iface-modem-3gpp-ussd.c > inde

Re: [PATCH 3/3] iface-modem-3gpp-ussd: port mm_iface_modem_3gpp_ussd_disable to use GTask

On 28/06/17 18:30, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp-ussd.c | 73 > ++ > 1 file changed, 39 insertions(+), 34 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp-ussd.c b/src/mm-iface-modem-3gpp-ussd.c > inde

Re: [PATCH 1/3] iface-modem-3gpp-ussd: port mm_iface_modem_3gpp_ussd_initialize to use GTask

On 28/06/17 18:30, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp-ussd.c | 76 > ++ > 1 file changed, 39 insertions(+), 37 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp-ussd.c b/src/mm-iface-modem-3gpp-ussd.c > inde

Re: [PATCH 1/1] telit: port mm-common-telit to use GTask

Hey Daniele, See comments below. On 28/06/17 16:07, Daniele Palmas wrote: > --- > plugins/telit/mm-common-telit.c | 64 > +++-- > 1 file changed, 29 insertions(+), 35 deletions(-) > > diff --git a/plugins/telit/mm-common-telit.c b/plugins/telit/mm-common-tel

Re: [PATCH 1/2 v2] enums: replace Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_*

On 28/06/17 09:13, Ben Chan wrote: > 3GPP TS 36.101 Table 5.5-1 refers the E-UTRA operating bands as 1, 2, 3, > ..., etc. > --- > include/ModemManager-enums.h | 144 +++--- > plugins/altair/mm-modem-helpers-altair-lte.c | 4 +- > .../altair/tests/test-modem-he

Re: [PATCH 2/2 v4] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

On 28/06/17 17:30, Ben Chan wrote: > Those Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_* were replaced > with 1, 2, 3, ..., etc. This patch adds a compatibility header, > ModemManager-compat.h, to alias the old MM_MODEM_BAND_EUTRAN_* values to > the new values. > --- Pushed to git master, thank

[PATCH 1/3] iface-modem-3gpp-ussd: port mm_iface_modem_3gpp_ussd_initialize to use GTask

--- src/mm-iface-modem-3gpp-ussd.c | 76 ++ 1 file changed, 39 insertions(+), 37 deletions(-) diff --git a/src/mm-iface-modem-3gpp-ussd.c b/src/mm-iface-modem-3gpp-ussd.c index db62cbbc..9dd4150f 100644 --- a/src/mm-iface-modem-3gpp-ussd.c +++ b/src/mm-ifac

[PATCH 2/3] iface-modem-3gpp-ussd: port mm_iface_modem_3gpp_ussd_enable to use GTask

--- src/mm-iface-modem-3gpp-ussd.c | 73 ++ 1 file changed, 39 insertions(+), 34 deletions(-) diff --git a/src/mm-iface-modem-3gpp-ussd.c b/src/mm-iface-modem-3gpp-ussd.c index 9dd4150f..ff6168d1 100644 --- a/src/mm-iface-modem-3gpp-ussd.c +++ b/src/mm-ifac

[PATCH 3/3] iface-modem-3gpp-ussd: port mm_iface_modem_3gpp_ussd_disable to use GTask

--- src/mm-iface-modem-3gpp-ussd.c | 73 ++ 1 file changed, 39 insertions(+), 34 deletions(-) diff --git a/src/mm-iface-modem-3gpp-ussd.c b/src/mm-iface-modem-3gpp-ussd.c index ff6168d1..1da9459f 100644 --- a/src/mm-iface-modem-3gpp-ussd.c +++ b/src/mm-ifac

[PATCH 2/2 v4] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

Those Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_* were replaced with 1, 2, 3, ..., etc. This patch adds a compatibility header, ModemManager-compat.h, to alias the old MM_MODEM_BAND_EUTRAN_* values to the new values. --- docs/reference/api/ModemManager-docs.xml | 5 + docs/reference/api

Re: [PATCH 2/2 v2] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

On Wed, Jun 28, 2017 at 4:08 PM, Ben Chan wrote: > It seems to me that gtk-doc doesn't deal with `static const` > definitions. One silly workaround is to do something like this: > I'll look into supporting that in gtk-doc. > /** > * OLD_ENUM: > * > */ > G_DEPRECATED_FOR(NE

Re: [PATCH 2/2 v3] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

On Wed, Jun 28, 2017 at 5:08 PM, Ben Chan wrote: > Those Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_* were replaced > with 1, 2, 3, ..., etc. This patch adds a compatibility header, > ModemManager-compat.h, to alias the old MM_MODEM_BAND_EUTRAN_* values to > the new values. > --- Could we mak

Re: Re: Issues with modem reset

On Wed, Jun 28, 2017 at 4:42 PM, Piotr Figiel wrote: > > diff --git a/src/mm-broadband-bearer.c b/src/mm-broadband-bearer.c > index aeff2ef..db38970 100644 > --- a/src/mm-broadband-bearer.c > +++ b/src/mm-broadband-bearer.c > @@ -1586,8 +1586,10 @@ cgact_ready (MMBaseModem *modem, > if (!erro

[PATCH 2/2 v3] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

Those Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_* were replaced with 1, 2, 3, ..., etc. This patch adds a compatibility header, ModemManager-compat.h, to alias the old MM_MODEM_BAND_EUTRAN_* values to the new values. --- docs/reference/api/ModemManager-docs.xml | 5 + docs/reference/api

Re: Re: Issues with modem reset

Hi Carlo, Aleksander, 2017-06-28 15:10 GMT+02:00 Carlo Lobrano : > (...) > > Not really sure what's happening here, but I do remember a similar issue > where adding some new debug logs, it appeared that the reply sent to > PORTCFG? parser was an empty string, the thread in this mailing list is

Re: [PATCH 2/2 v2] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

On Wed, Jun 28, 2017 at 1:46 AM, Aleksander Morgado wrote: > > On Wed, Jun 28, 2017 at 9:36 AM, Ben Chan wrote: > > When adding this compat header, I noticed that __attribute__((deprecated)), > > which G_DEPRECATED_FOR is based on, can't be associated with macros. Both > > gcc and clang associat

[PATCH 1/1] telit: port mm-common-telit to use GTask

--- plugins/telit/mm-common-telit.c | 64 +++-- 1 file changed, 29 insertions(+), 35 deletions(-) diff --git a/plugins/telit/mm-common-telit.c b/plugins/telit/mm-common-telit.c index 1e43588..cfd3292 100644 --- a/plugins/telit/mm-common-telit.c +++ b/plugins/te

Re: Re: Issues with modem reset

Hi Aleksander, Piotr,> I'm checking the logs and if my understanding is correct it looks like> some logic from bearer disconnect from the connection before the modem> reset happens still executes after modem was lost and when "new" modem> is probed, it looks like it may get in the way of AT ports p

Re: Issues with modem reset

Hi, 2017-06-28 10:41 GMT+02:00 Aleksander Morgado : > Can you retry but before running the reset operation, do an explicit > disconnection and/or disable? I checked with nmcli d disconnect prior to mmcli -r and I'm not able to reproduce this. Though once mmcli -r failed because of timeout on AT c

Re: Issues with modem reset

Hi Aleksander, that's clear but as you can see in the logs the device does respond to AT commands in the problematic case. You can see that there are replies for AT#PORTCFG? on ttyACM0 and yet for some reason after a while MM decides to use mainly ttyACM3 and starts to act like ttyACM0 wasn't the

Re: Issues with modem reset

On Wed, Jun 28, 2017 at 10:54 AM, Piotr Figiel wrote: > thanks for reply. > Yes I could but I think it races with NM which tries to reestablish > connection, not sure if such testcase will help to debug this. > I've done some checks with with nmcli d disconnect ttyACM0 and it > improved (though

Re: Issues with modem reset

Hi Aleksander, thanks for reply. Yes I could but I think it races with NM which tries to reestablish connection, not sure if such testcase will help to debug this. I've done some checks with with nmcli d disconnect ttyACM0 and it improved (though I'll redo this more systematically), but the prob

Re: [PATCH 2/2 v2] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

On Wed, Jun 28, 2017 at 9:36 AM, Ben Chan wrote: > When adding this compat header, I noticed that __attribute__((deprecated)), > which G_DEPRECATED_FOR is based on, can't be associated with macros. Both > gcc and clang associated the attribute to the next identifier found after > the macro defini

Re: Issues with modem reset

On Wed, Jun 28, 2017 at 10:27 AM, Piotr Figiel wrote: > I'm debugging it now but hints would be appreciated. Can you retry but before running the reset operation, do an explicit disconnection and/or disable? E.g. mmcli --simple-disconnect mmcli --disable mmcli --reset -- Aleksander h

Re: [PATCH 2/2 v2] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

Hey, On Wed, Jun 28, 2017 at 9:13 AM, Ben Chan wrote: > Those Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_* were replaced > with 1, 2, 3, ..., etc. This patch adds a compatibility header, > ModemManager-compat.h, to alias the old MM_MODEM_BAND_EUTRAN_* values to > the new values. See comments

Issues with modem reset

Hi Aleksander, modemmanager-devel, we're encountering an issue with modem manager when used with network manager, such that sometimes the modem's secondary port becomes unusable from modem manager after modem is reset with mmcli -r. The modem responds fine to AT commands when asked directly, thou

Re: [PATCH 3/3] iface-modem-messaging: port mm_iface_modem_messaging_disable to use GTask

On Tue, Jun 27, 2017 at 5:54 PM, Ben Chan wrote: > --- > src/mm-iface-modem-messaging.c | 89 > ++ > 1 file changed, 47 insertions(+), 42 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-iface-modem-messaging.c b/src/mm-iface-modem-mess

Re: [PATCH 2/3] iface-modem-messaging: port mm_iface_modem_messaging_enable to use GTask

On Tue, Jun 27, 2017 at 5:54 PM, Ben Chan wrote: > --- > src/mm-iface-modem-messaging.c | 182 > - > 1 file changed, 91 insertions(+), 91 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-iface-modem-messaging.c b/src/mm-iface-modem-mess

Re: [PATCH 1/3] iface-modem-messaging: port mm_iface_modem_messaging_initialize to use GTask

On Tue, Jun 27, 2017 at 5:54 PM, Ben Chan wrote: > --- > src/mm-iface-modem-messaging.c | 129 > +++-- > 1 file changed, 60 insertions(+), 69 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-iface-modem-messaging.c b/src/mm-iface-modem-mess

Re: [PATCH] iface-modem-firmware: port mm_iface_modem_firmware_initialize to use GTask

On 27/06/17 16:31, Ben Chan wrote: > --- > src/mm-iface-modem-firmware.c | 95 > +++ > 1 file changed, 41 insertions(+), 54 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-iface-modem-firmware.c b/src/mm-iface-modem-firmware.c > index

Re: [PATCH 2/4 v2] iface-modem-location: port mm_iface_modem_location_enable to use GTask

On 27/06/17 10:42, Ben Chan wrote: > --- > src/mm-iface-modem-location.c | 82 > ++- > 1 file changed, 35 insertions(+), 47 deletions(-) > Pushed to git master. > diff --git a/src/mm-iface-modem-location.c b/src/mm-iface-modem-location.c > index 634de771

Re: [PATCH 1/4 v2] iface-modem-location: port mm_iface_modem_location_initialize to use GTask

On 27/06/17 10:41, Ben Chan wrote: > --- > src/mm-iface-modem-location.c | 109 > +++--- > 1 file changed, 50 insertions(+), 59 deletions(-) > Pushed to git master. > diff --git a/src/mm-iface-modem-location.c b/src/mm-iface-modem-location.c > index a49efb82

Re: [PATCH 2/2 v2] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

When adding this compat header, I noticed that __attribute__((deprecated)), which G_DEPRECATED_FOR is based on, can't be associated with macros. Both gcc and clang associated the attribute to the next identifier found after the macro definition, not the macro itself: #1 G_DEPRECATED_FOR(NEW_E

[PATCH 2/2 v2] compat: add compatibility definitions for old MM_MODEM_BAND_EUTRAN_* values

Those Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_* were replaced with 1, 2, 3, ..., etc. This patch adds a compatibility header, ModemManager-compat.h, to alias the old MM_MODEM_BAND_EUTRAN_* values to the new values. --- include/Makefile.am | 1 + include/ModemManager-compat.h | 4

[PATCH 1/2 v2] enums: replace Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_*

3GPP TS 36.101 Table 5.5-1 refers the E-UTRA operating bands as 1, 2, 3, ..., etc. --- include/ModemManager-enums.h | 144 +++--- plugins/altair/mm-modem-helpers-altair-lte.c | 4 +- .../altair/tests/test-modem-helpers-altair-lte.c | 8 +- plugins/telit/mm