Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

Thanks for taking a look at this! On Thu, Jun 29, 2017 at 3:22 AM, Carlo Lobrano wrote: > Hi, > >> If I'm not mistaken, whenever a sim insert/removal event is detected, we >> should just call >> mm_broadband_modem_update_sim_hot_swap_detected(), which will trigger a >> full modem re-probe. I had

Re: huawei: duplicated DTMF tone

Hi Dan, have you any feedback about this patch ? I've made a lot of test and seems to fix CPU leak and duplicated DTMF. Thanks, Riccardo Hi Dan, I take a look to the code and I came up to this patch. It saves the device name at the voice call connection start (^CONN) and use it for DTMF until

Re: Re: Issues with modem reset

// sorry, re-sending to the group Hi Aleksander, 2017-06-28 17:20 GMT+02:00 Aleksander Morgado : > The key point is the kind of error to consider the action fatal and > abort right away. If the device is removed, we should definitely take > it as a fatal error and abort any other action; for othe

[PATCH 3/5] iface-modem-cdma: port mm_iface_modem_cdma_disable to use GTask

--- src/mm-iface-modem-cdma.c | 82 +-- 1 file changed, 44 insertions(+), 38 deletions(-) diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c index d7c6cf12..f35d6aa1 100644 --- a/src/mm-iface-modem-cdma.c +++ b/src/mm-iface-modem-cdma.c

[PATCH 3/4] iface-modem-3gpp: port mm_iface_modem_3gpp_disable to use GTask

--- src/mm-iface-modem-3gpp.c | 103 -- 1 file changed, 53 insertions(+), 50 deletions(-) diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c index b9446507..772d3609 100644 --- a/src/mm-iface-modem-3gpp.c +++ b/src/mm-iface-modem-3gpp.c

[PATCH 1/4] iface-modem-3gpp: port mm_iface_modem_3gpp_initialize to use GTask

--- src/mm-iface-modem-3gpp.c | 95 +-- 1 file changed, 43 insertions(+), 52 deletions(-) diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c index bcd12e85..e06e36cf 100644 --- a/src/mm-iface-modem-3gpp.c +++ b/src/mm-iface-modem-3gpp.c

[PATCH 2/5] iface-modem-cdma: port mm_iface_modem_cdma_enable to use GTask

--- src/mm-iface-modem-cdma.c | 102 +- 1 file changed, 46 insertions(+), 56 deletions(-) diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c index 6340b031..d7c6cf12 100644 --- a/src/mm-iface-modem-cdma.c +++ b/src/mm-iface-modem-cdma.c

[PATCH 4/4] iface-modem-3gpp: port mm_iface_modem_3gpp_reload_current_registration_info to use GTask

--- src/mm-iface-modem-3gpp.c | 83 ++- 1 file changed, 46 insertions(+), 37 deletions(-) diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c index 772d3609..255e75f4 100644 --- a/src/mm-iface-modem-3gpp.c +++ b/src/mm-iface-modem-3gpp.c

[PATCH 4/5] iface-modem-cdma: port mm_iface_modem_cdma_register_in_network to use GTask

--- src/mm-iface-modem-cdma.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c index f35d6aa1..6bf7bb17 100644 --- a/src/mm-iface-modem-cdma.c +++ b/src/mm-iface-modem-cdma.c @@ -396,22 +396,21 @@ mm_if

[PATCH 2/4] iface-modem-3gpp: port mm_iface_modem_3gpp_enable to use GTask

--- src/mm-iface-modem-3gpp.c | 144 ++ 1 file changed, 70 insertions(+), 74 deletions(-) diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c index e06e36cf..b9446507 100644 --- a/src/mm-iface-modem-3gpp.c +++ b/src/mm-iface-modem-3gpp.c

[PATCH 5/5] iface-modem-cdma: port mm_iface_modem_cdma_run_registration_checks to use GTask

--- src/mm-iface-modem-cdma.c | 207 +- 1 file changed, 112 insertions(+), 95 deletions(-) diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c index 6bf7bb17..1d460389 100644 --- a/src/mm-iface-modem-cdma.c +++ b/src/mm-iface-modem-cdma.c

[PATCH 1/5] iface-modem-cdma: port mm_iface_modem_cdma_initialize to use GTask

--- src/mm-iface-modem-cdma.c | 105 +- 1 file changed, 48 insertions(+), 57 deletions(-) diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c index 771bffd7..6340b031 100644 --- a/src/mm-iface-modem-cdma.c +++ b/src/mm-iface-modem-cdma.c

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

Hi, > If I'm not mistaken, whenever a sim insert/removal event is detected, we should just call > mm_broadband_modem_update_sim_hot_swap_detected(), which will trigger a full modem re-probe. yes, I confirm this. *mm_broadband_modem_update_sim_hot_swap_detected* will trigger full re-probe and disa

Re: [PATCH v2 1/1] telit: port mm-common-telit to use GTask

On 29/06/17 11:09, Daniele Palmas wrote: > --- > v2: address GTask cancellation issues highlighted by Aleksander > --- > plugins/telit/mm-common-telit.c | 65 > +++-- > 1 file changed, 30 insertions(+), 35 deletions(-) > Pushed to git master, thanks. > diff

[PATCH v2 1/1] telit: port mm-common-telit to use GTask

--- v2: address GTask cancellation issues highlighted by Aleksander --- plugins/telit/mm-common-telit.c | 65 +++-- 1 file changed, 30 insertions(+), 35 deletions(-) diff --git a/plugins/telit/mm-common-telit.c b/plugins/telit/mm-common-telit.c index 1e43588..f

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

On 29/06/17 10:51, Aleksander Morgado wrote: >> +if (self->priv->last_ready_state != >> MBIM_SUBSCRIBER_READY_STATE_SIM_NOT_INSERTED && >> +ready_state == MBIM_SUBSCRIBER_READY_STATE_SIM_NOT_INSERTED) { >> +/* SIM has been removed */ >> +mm_iface_modem_update_failed_sta

Re: [PATCH 4/4] iface-modem-time: port update_network_timezone to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-time.c | 120 > +++--- > 1 file changed, 61 insertions(+), 59 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c > index eec340ed

Re: [PATCH 1/4] iface-modem-time: port mm_iface_modem_time_initialize to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-time.c | 93 > --- > 1 file changed, 40 insertions(+), 53 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c > index 85588d3f

Re: [PATCH 2/4] iface-modem-time: port mm_iface_modem_time_enable to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-time.c | 108 > +- > 1 file changed, 49 insertions(+), 59 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c > index efb8d386

Re: [PATCH 3/4] iface-modem-time: port mm_iface_modem_time_disable to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-time.c | 91 > +-- > 1 file changed, 48 insertions(+), 43 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c > index 74e497e7

Re: [PATCH 3/3] iface-modem-voice: port mm_iface_modem_voice_disable to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-voice.c | 89 > -- > 1 file changed, 47 insertions(+), 42 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c > index b07579

Re: [PATCH 2/3] iface-modem-voice: port mm_iface_modem_voice_enable to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-voice.c | 108 > - > 1 file changed, 49 insertions(+), 59 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c > index 2a9390

Re: [PATCH 3/3] iface-modem-oma: port mm_iface_modem_oma_disable to use GTask

On 29/06/17 06:43, Ben Chan wrote: > --- > src/mm-iface-modem-oma.c | 87 > +--- > 1 file changed, 46 insertions(+), 41 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c > index 46aef277..

Re: [PATCH 2/3] iface-modem-oma: port mm_iface_modem_oma_enable to use GTask

On 29/06/17 06:43, Ben Chan wrote: > --- > src/mm-iface-modem-oma.c | 125 > ++- > 1 file changed, 59 insertions(+), 66 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c > index 03e3deb6..

Re: [PATCH 1/3] iface-modem-voice: port mm_iface_modem_voice_initialize to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-voice.c | 97 > -- > 1 file changed, 42 insertions(+), 55 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c > index ca6523

Re: [PATCH 1/3] iface-modem-oma: port mm_iface_modem_oma_initialize to use GTask

On 29/06/17 06:43, Ben Chan wrote: > --- > src/mm-iface-modem-oma.c | 99 > +--- > 1 file changed, 43 insertions(+), 56 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c > index b8c48417..

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

Hey Eric, +Carlo in CC Carlo, would also like your opinion on this. On 28/06/17 23:46, Eric Caruso wrote: > If an MBIM modem supports unsolicited notifications for > subscriber ready status, we can use it to detect when SIM cards > have been removed and reinserted. Upon detection we should re- >

[PATCH] mm-broadband-modem-mbim: support hot swapping

If an MBIM modem supports unsolicited notifications for subscriber ready status, we can use it to detect when SIM cards have been removed and reinserted. Upon detection we should re- probe the modem so that we can configure it for the new SIM. --- src/mm-broadband-modem-mbim.c | 16 +++