[PATCH] bearer-mbim: avoid calling mbim_message_unref on NULL MbimMessage

2017-07-26 Thread Ben Chan
--- src/mm-bearer-mbim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mm-bearer-mbim.c b/src/mm-bearer-mbim.c index 439de812..63bb0579 100644 --- a/src/mm-bearer-mbim.c +++ b/src/mm-bearer-mbim.c @@ -173,7 +173,9 @@ packet_statistics_query_ready (MbimDevice *device,

Re: [PATCH] broadband-bearer: run init sequence after flashing in disconnection

2017-07-26 Thread Aleksander Morgado
> > Incidentally, a similar thing goes for RTS/CTS, these aren't always > connected up, but the flow control setup logic currently says "if the > host supports RTS/CTS and the modem supports RTS/CTS, then turn it on", > which might not be the right thing to do since they might not actually > be con

Re: ATZ in enabling_modem_init() step

2017-07-26 Thread Aleksander Morgado
On Wed, Jul 26, 2017 at 4:32 PM, Tim Small wrote: > On 25/07/17 12:47, Aleksander Morgado wrote: >> A quick solution would be to subclass the enabling_modem_init() step >> and after running the parent method, run a Telit specific setup to >> check #CSS? and if disabled due to the ATZ, re-set it, w

Re: Modem index increment

2017-07-26 Thread Aleksander Morgado
On Wed, Jul 26, 2017 at 4:57 PM, José wrote: > I have noticed that when unplugging and plugging a modem, ModemManager > increases its index by one. This can be annoying when you are trying > to script something. > > Would it make sense to assign the same index to the same modem? Maybe > something

Modem index increment

2017-07-26 Thread José
I have noticed that when unplugging and plugging a modem, ModemManager increases its index by one. This can be annoying when you are trying to script something. Would it make sense to assign the same index to the same modem? Maybe something like using the "equipment id" field to detect a plugged

ATZ in enabling_modem_init() step

2017-07-26 Thread Tim Small
On 25/07/17 12:47, Aleksander Morgado wrote: > A quick solution would be to subclass the enabling_modem_init() step > and after running the parent method, run a Telit specific setup to > check #CSS? and if disabled due to the ATZ, re-set it, would that > work? I wonder if issuing ATZ is the right

Re: [PATCH] sim hot swap: improved error management

2017-07-26 Thread Tim Small
On 25/07/17 13:05, Carlo Lobrano wrote: > I can't reproduce this issue. I see the ATZ command, but I still receive > each QSS notification. OK. Do you have separate data and command ports? Is so, then perhaps the reason which you can't reproduce the issue is that the ATZ command only acts locall

Re: [PATCH] broadband-bearer: run init sequence after flashing in disconnection

2017-07-26 Thread Tim Small
On 25/07/17 16:46, Dan Williams wrote: > There's a couple more things we could do with the disconnect code too. > > As you suggest, we could set AT&D by default and if the > modem allows that, hope that dropping DTR does the right thing. A potential problem here is badly implemented hardware wher

[PATCH v2] telit-plugin: ignore QSS when SIM-ME interface is locked

2017-07-26 Thread Carlo Lobrano
With some modems, the lock/unlock of the SIM-ME interface with +CSIM=1/0 command is followed by #QSS unsolicited messages. With the current implementation, this messages are mistaken for SIM swap events and so the modem is first dropped and then re-probed. With this patch, the plugin takes into ac

Re: [PATCH] telit-plugin: ignore QSS when SIM-ME interface is locked

2017-07-26 Thread Carlo Lobrano
That's right, thank you On Wed, 26 Jul 2017 at 12:21 Aleksander Morgado wrote: > On Wed, Jul 26, 2017 at 10:36 AM, Carlo Lobrano > wrote: > >>> +csim_unlock_complete (self->priv->csim_lock_task); > >> Reset the csim_lock_task pointer here to NULL, please. > > > > Can I do this insid

Re: [PATCH] telit-plugin: ignore QSS when SIM-ME interface is locked

2017-07-26 Thread Aleksander Morgado
On Wed, Jul 26, 2017 at 10:36 AM, Carlo Lobrano wrote: >>> +csim_unlock_complete (self->priv->csim_lock_task); >> Reset the csim_lock_task pointer here to NULL, please. > > Can I do this inside csim_unlock_complete or there is a reason to do it > outside this function? > If you do it

Re: [PATCH] telit-plugin: ignore QSS when SIM-ME interface is locked

2017-07-26 Thread Carlo Lobrano
>> +csim_unlock_complete (self->priv->csim_lock_task); > Reset the csim_lock_task pointer here to NULL, please. Can I do this inside csim_unlock_complete or there is a reason to do it outside this function? On Tue, 25 Jul 2017 at 14:28 Carlo Lobrano wrote: > > Not sure you need to r