[PATCH] broadband-modem-mbim: add missing guard for shared_qmi_init()

2018-08-21 Thread Ben Chan
Fixes: 9e42a19742de55cf5c0ba4d68069c1845e9392e6 --- src/mm-broadband-modem-mbim.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c index 1559ab5b..eb9e723b 100644 --- a/src/mm-broadband-modem-mbim.c +++ b/src/mm-broadband-modem-m

[PATCH] port-mbim: add missing guard for try_qmi_over_mbim in mm_port_mbim_open()

2018-08-21 Thread Ben Chan
Fixes: c0cc694c67d9e71f200fb23e20473cc9b31d9ec0 --- src/mm-port-mbim.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mm-port-mbim.c b/src/mm-port-mbim.c index f48ebd8f..cd6d9f22 100644 --- a/src/mm-port-mbim.c +++ b/src/mm-port-mbim.c @@ -335,9 +335,11 @@ mm_port_mbim_open (MMPortMbim

Re: [PATCH] shared-qmi: include string.h for memset()

2018-08-21 Thread Aleksander Morgado
On 21/08/18 23:02, Ben Chan wrote: > This patch fixes the following compiler warning: > > mm-shared-qmi.c:447:9: error: implicitly declaring library function 'memset' > with type 'void *(void *, int, unsigned long)' > [-Werror,-Wimplicit-function-declaration] > memset (buf, 0, sizeof (bu

Re: [PATCH] xmm: include string.h for strlen()

2018-08-21 Thread Aleksander Morgado
On 21/08/18 23:03, Ben Chan wrote: > This patch fixes the following compiler warning: > > xmm/mm-modem-helpers-xmm.c:388:38: error: implicitly declaring library > function 'strlen' with type 'unsigned long (const char *)' > [-Werror,-Wimplicit-function-declaration] > g_regex_match_full (r, r

[PATCH] xmm: include string.h for strlen()

2018-08-21 Thread Ben Chan
This patch fixes the following compiler warning: xmm/mm-modem-helpers-xmm.c:388:38: error: implicitly declaring library function 'strlen' with type 'unsigned long (const char *)' [-Werror,-Wimplicit-function-declaration] g_regex_match_full (r, response, strlen (response), 0, 0, &match_info,

[PATCH] shared-qmi: include string.h for memset()

2018-08-21 Thread Ben Chan
This patch fixes the following compiler warning: mm-shared-qmi.c:447:9: error: implicitly declaring library function 'memset' with type 'void *(void *, int, unsigned long)' [-Werror,-Wimplicit-function-declaration] memset (buf, 0, sizeof (buf)); ^ --- src/mm-shared-qmi.c | 1 +

[review] Reset, Capabilities/Modes and Bands management in shared QMI logic

2018-08-21 Thread Aleksander Morgado
Hey, The following MR includes support for reset actions (reset, factory reset), modes/capabilities management and bands management in the shared QMI logic, so reused by both QMI and QMI-over-MBIM capable devices. https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/30 The

Re: Sierra MC7354: Drowning in "bearer verbose call end reason (6,36): [3gpp] regular-deactivation"

2018-08-21 Thread Einar Jón
Thanks for that. Info below On Mon, 20 Aug 2018 at 23:31, Aleksander Morgado wrote: > > Hey, > > > > > I am using the Sierra MC7354 modem, and we are getting unusual > > disconnects on AT&T in the US. Vodafone is fine on the same modems, > > and this only seems to happen on 4G. AT&T 3G seems to

Re: [review v2] New 'fibocom' plugin (with a new Intel XMM modem class)

2018-08-21 Thread Dan Williams
On Wed, 2018-08-08 at 17:14 +0200, Aleksander Morgado wrote: > > > > > > I've now pushed an updated MR to suggest the Fibocom plugin, this > > > time > > > including a new "Icera-like" Intel XMM chipset detection. If the > > > modem > > > is found to be based on Intel XMM, supporting the "AT+X.."

Re: [review] USSD support for MBIM

2018-08-21 Thread Dan Williams
On Wed, 2018-08-08 at 17:18 +0200, Aleksander Morgado wrote: > Hey, > > This MR adds USSD support for MBIM devices, and while at it, also > ported the original MMBroadbandModem USSD support to GTask: > > https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_re > quests/23 > > The MB

Re: [review] MBIM ATDS service based 3GPP location and extended Signal interface support

2018-08-21 Thread Dan Williams
On Thu, 2018-08-09 at 13:45 +0200, Aleksander Morgado wrote: > Hey, > > The following MR introduces support for using the MBIM ATDS service > extensions to query for 3GPP location (LAC/TAC/CID) as well as > extended signal information (RSRP, RSRQ, RSSI...). > > The MR contains 3 commits but only

Re: [review] New 'MMSharedCinterion' interface

2018-08-21 Thread Dan Williams
On Mon, 2018-08-13 at 19:25 +0200, Aleksander Morgado wrote: > Hey, > > See this MR: > https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_re > quests/26 > > It implements a new shared interface containing the code shared > between the Cinterion modem objects, similar to what's bee

Re: [review] QMI LOC based GPS positioning for QMI and Qualcomm-based MBIM devices

2018-08-21 Thread Dan Williams
On Mon, 2018-08-13 at 15:06 +0200, Aleksander Morgado wrote: > Hey all, > > > > > See https://gitlab.freedesktop.org/mobile-broadband/ModemManager/me > > rge_requests/10 > > > > The MR implements QMI LOC based GPS positioning, including SUPL- > > server > > based A-GPS and some new support for i

Re: [review] ICCID related improvements

2018-08-21 Thread Dan Williams
On Tue, 2018-08-21 at 16:41 +0200, Aleksander Morgado wrote: > Hey all, > > This MR includes some improvements for ICCID reporting: > https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_re > quests/29 > > Fixes several things found recently with China Mobile ICCIDs. Do we need tes

[review] ICCID related improvements

2018-08-21 Thread Aleksander Morgado
Hey all, This MR includes some improvements for ICCID reporting: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/29 Fixes several things found recently with China Mobile ICCIDs. Cheers -- Aleksander https://aleksander.es _