Re: [PATCH 1/2] modem-helpers: remove useless checks on always true condition

2018-10-27 Thread Aleksander Morgado
On 10/27/18 8:00 AM, Ben Chan wrote: > mm-modem-helpers.c:3075:31: error: comparison of unsigned expression >= 0 is > always true [-Werror=type-limits] > g_return_val_if_fail (idx >= 0, NULL); > Pushed, thanks. ^ > --- > src/mm-modem-helpers.c | 1 - > 1 fil

Re: recipe for target 'mbim-enum-types.h' failed openwrt

2018-10-26 Thread Aleksander Morgado
On Wed, Oct 24, 2018 at 6:52 PM Russ Westrem wrote: > > Trying to compile modemmanager for openwrt and failing here. > > > make[8]: Entering directory > '/home/russ/openwrt/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/libmbim-1.16.2/src/libmbim-glib/generated' > GEN mbim-basic-conn

Re: Infinite connection loop

2018-10-26 Thread Aleksander Morgado
Hey, > After looking into this a lot more, I’m still not closer to a solution or a > root cause. For a while, I thought enabling debug logging for pppd (via the > NM_PPP_DEBUG environment variable for NetworkManager) resolved the issue. > However, it didn’t reliably. For the debug and non-debug

Re: Infinite connection loop

2018-10-26 Thread Aleksander Morgado
Hey, > It looks like I celebrated prematurely. As soon as I disabled the debug-level > logging for NetworkManager and ModemManager, the issue started to appear > again. This tells me that there is some sort of race condition. I’ll look > into this more but I’d appreciate if one of the maintaine

Re: Openwrt with modemmanager

2018-10-22 Thread Aleksander Morgado
On 10/20/18 8:18 PM, Russ Westrem wrote: > I've compiled and had working modemmanager with lede. Now when trying to > use it with openwrt it never establishes a connection. Does something > need to be done to use it with openwrt? > Given that I've never used it with Lede and only used it with

Re: [PATCH] broadband-bearer: remove unused 'self' variables

2018-10-22 Thread Aleksander Morgado
On 10/20/18 8:15 PM, Ben Chan wrote: > --- > src/mm-broadband-bearer.c | 5 - > 1 file changed, 5 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-broadband-bearer.c b/src/mm-broadband-bearer.c > index 1b13921a..b5692d43 100644 > --- a/src/mm-broadband-bearer.c > +++ b/src

Re: [PATCH] sierra: remove unused 'self' variable in scact_periodic_query_ready()

2018-10-22 Thread Aleksander Morgado
On 10/20/18 8:15 PM, Ben Chan wrote: > --- > plugins/sierra/mm-broadband-bearer-sierra.c | 2 -- > 1 file changed, 2 deletions(-) > Pushed to git master, thanks. > diff --git a/plugins/sierra/mm-broadband-bearer-sierra.c > b/plugins/sierra/mm-broadband-bearer-sierra.c > index 1943d1ac..3a88149

Re: [PATCH] xmm: remove unused 'priv' variable in xact_query_bands_ready()

2018-10-20 Thread Aleksander Morgado
On 10/20/18 9:47 AM, Ben Chan wrote: > --- > plugins/xmm/mm-shared-xmm.c | 3 --- > 1 file changed, 3 deletions(-) > Merged to git master, thanks. > diff --git a/plugins/xmm/mm-shared-xmm.c b/plugins/xmm/mm-shared-xmm.c > index fcddee10..cbc7c7b4 100644 > --- a/plugins/xmm/mm-shared-xmm.c > +++

Re: [PATCH] base-call: remove unused 'self' variables

2018-10-20 Thread Aleksander Morgado
On 10/20/18 9:46 AM, Ben Chan wrote: > --- > src/mm-base-call.c | 9 - > 1 file changed, 9 deletions(-) > Merged to git master, thanks. > diff --git a/src/mm-base-call.c b/src/mm-base-call.c > index c128b601..79d296d9 100644 > --- a/src/mm-base-call.c > +++ b/src/mm-base-call.c > @@ -87

Re: Infinite connection loop

2018-10-20 Thread Aleksander Morgado
Hey, > I am running an embedded system with a u-blox SARA-U270 modem and > NetworkManager 1.12.2 / ModemManager 1.8.0. For some reason, the modem > connection seems to break over time. I am not quite sure why that’s the case, > but when I look into the journal, I see NetworkManager and ModemMan

Re: [PATCH 3/3] core: use g_clear_pointer() to avoid explicitly checking and resetting pointers

2018-10-18 Thread Aleksander Morgado
On 10/18/18 8:06 AM, Ben Chan wrote: > --- > src/mm-base-sms.c | 10 ++ > src/mm-broadband-modem-mbim.c | 10 ++ > 2 files changed, 4 insertions(+), 16 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-base-sms.c b/src/mm-base-sms.c > index e117bef7.

Re: [PATCH 2/3] core: remove unnecessary NULL checks for g_match_info_free()

2018-10-18 Thread Aleksander Morgado
On 10/18/18 8:06 AM, Ben Chan wrote: > g_match_info_free() already check if the given pointer is NULL and does > nothing on a NULL pointer. > --- Pushed to git master, thanks. > .../cinterion/mm-modem-helpers-cinterion.c| 12 -- > plugins/huawei/mm-modem-helpers-huawei.c | 21 ++

Re: [PATCH 1/3] core: remove unnecessary NULL checks for g_free()

2018-10-18 Thread Aleksander Morgado
On 10/18/18 8:06 AM, Ben Chan wrote: > g_free() already check if the given pointer is NULL and does nothing on > a NULL pointer. > --- Pushed to git master, thanks. > libmm-glib/mm-location-gps-raw.c | 3 +-- > src/mm-base-sms.c| 6 ++ > src/mm-broadband-bearer.c| 3 +

Re: [PATCH] modem-helpers-qmi: include string.h for memset()

2018-10-17 Thread Aleksander Morgado
-qmi.c b/src/mm-modem-helpers-qmi.c > index e48d2eb7..e5e3243c 100644 > --- a/src/mm-modem-helpers-qmi.c > +++ b/src/mm-modem-helpers-qmi.c > @@ -14,6 +14,8 @@ > * Copyright (C) 2018 Aleksander Morgado > */ > > +#include > + > #include

Re: ModemManager PPA for Ubuntu

2018-10-16 Thread Aleksander Morgado
Hey, > Could you check > https://launchpad.net/~aleksander-m/+archive/ubuntu/modemmanager-bionic > - it doesn't seem to have triggered a new build and thus still only > has packages for amd64/i386. > I should push the latest stable releases to all those PPAs, that should trigger the new build. Wi

Re: Resetting Bearer on OpenWRT

2018-10-15 Thread Aleksander Morgado
Hey! > I'm running modemmanager on OpenWRT and am getting this error fairly > regularly such as when I use AT commands to manually change LTE > bands(is there a better way to change/lock bands than using AT > commands?): "Bearer not allowed to connect, not registered in 3GPP > network" > If you'r

Re: MC7750 missing SIM until ModemManager restart

2018-10-10 Thread Aleksander Morgado
On Thu, Oct 11, 2018 at 12:32 AM Bowden, Brendan wrote: > > > > >Out of curiosity, have you tried different SIM cards? > >Also, is the firmware you're using the latest one available for the > > MC7750? > > > > Multiple SIM cards on multiple machines are acting the same way. We were > ori

Re: MC7750 missing SIM until ModemManager restart

2018-10-10 Thread Aleksander Morgado
> Any way to have MM delay its initialization -- either by detecting "Absent" > and not-initialized SIM, or just waiting 15 seconds? Or increase number of > retries so it'll keep trying a while longer until it works? > We have a loop like that for MBIM modems. We query "Subscriber Ready Status"

[review] XLCSLSR based GPS management for XMM-based devices

2018-10-10 Thread Aleksander Morgado
Hey, See https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/46 -- Aleksander https://aleksander.es ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mod

Re: Re: bearer mbim: ipv6_config set to dhcp when no ipv6 is available

2018-10-10 Thread Aleksander Morgado
> > On Tue, Oct 09, 2018 at 10:27:41PM +0200, Reinhard Speyerer wrote: > > for IPType IPv4v6 the IPType returned may be IPv4 or IPv6 instead of IPv4v6 > > in the case where PDP context activation is accepted by the network but it > > returns a SM Cause 2 IE like this: > > ... > > Yes, thank you. I

Re: MC7750 missing SIM until ModemManager restart

2018-10-10 Thread Aleksander Morgado
Hey, > Having an odd issue where ModemManager has trouble reading SIM PIN status > from Sierra MC7750 (Verizon US, LTE+CDMA, QMI interface) modules after a > modem reset. > > > At first system boot, MM has no issue detecting the modem and activating a > connection. These are in mobile devices,

Re: The loading order of plugins

2018-10-09 Thread Aleksander Morgado
>> BUT, why is it that the modem cannot be supported by the Cinterion >> plugin? Which are the commands that are different? Can the Cinterion >> plugin not be updated to support this new model as well? >> > Then AT command such as "AT^SQPORT?" is not supported by "Cinterion Gemalto > ELS61". And T

Re: [review] Support connection checks in DirectIP (sierra-legacy plugin)

2018-10-09 Thread Aleksander Morgado
Hey! > > Devices like the AC313U require explicit context monitoring with !SCACT?. > > Otherwise, we may end up with the modem reported as connected in MM, with > > IP settings in the network interface and all, but without a real connection > > inside the modem. > > Really? I must admit that it's

[review] Support connection checks in DirectIP (sierra-legacy plugin)

2018-10-09 Thread Aleksander Morgado
Hey, Devices like the AC313U require explicit context monitoring with !SCACT?. Otherwise, we may end up with the modem reported as connected in MM, with IP settings in the network interface and all, but without a real connection inside the modem. This MR implements the support for this periodic !

Re: The loading order of plugins

2018-10-08 Thread Aleksander Morgado
Hey, > I'm now working on a modem "Cinterion Gemalto ELS61". And I tried to use it > with ModemManager. > ModemManager suggests the "Cinterion" plugin. But somehow, the AT command set > and some response message format of "Cinterion Gemalto ELS61" is different > from other modems supported by t

Re: [PATCH] base-modem: remove explicit GDestroyNotify cast on g_object_unref

2018-10-06 Thread Aleksander Morgado
On 10/5/18 7:49 PM, Ben Chan wrote: > g_object_unref is in form of `void (*)(gpointer)`, which matches the > GDestroyNotify signature. An explicit GDestroyNotify cast on > g_object_unref is thus not needed. > --- Pushed to git master, thanks > src/mm-base-modem.c | 4 ++-- > 1 file changed, 2 i

Re: bearer mbim: ipv6_config set to dhcp when no ipv6 is available

2018-10-06 Thread Aleksander Morgado
On 10/5/18 8:51 PM, Dan Williams wrote: >> I noticed, that in ip_configuration_query_ready() ipv6_config will be >> allocated and method will be set to MM_BEARER_IP_METHOD_DHCP even >> when >> ipv6configurationavailable is false, just based on the value of >> ctx->ip_type. >> >> So essentially ever

[review] Support for extended band list in QMI

2018-10-06 Thread Aleksander Morgado
Hey, The following MR implements support for handling E-UTRAN bands that are only managed via the "extended LTE band" TLV in the QMI protocol. https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/44 Comments welcome. -- Aleksander https://aleksander.es __

Re: [PATCH 1/2 v2] libmm-glib: use helper function to convert enum/flags from string

2018-10-04 Thread Aleksander Morgado
On 10/4/18 9:30 AM, Thomas Haller wrote: > --- > v2: always don't do g_type_class_peek(). > > libmm-glib/mm-common-helpers.c | 284 +++-- > 1 file changed, 92 insertions(+), 192 deletions(-) > Pushed to git master, thanks! > diff --git a/libmm-glib/mm-common-helpers

Re: [PATCH 1/2] libmm-glib, modem-helpers: unref enum/flags GType classes in enum getters

2018-10-04 Thread Aleksander Morgado
On 10/4/18 1:09 AM, Thomas Haller wrote: > --- > libmm-glib/mm-common-helpers.c | 60 -- > src/mm-modem-helpers.c | 10 -- > 2 files changed, 58 insertions(+), 12 deletions(-) > Pushed to git master, thanks! > diff --git a/libmm-glib/mm-common-helpers

Re: [PATCH 2/2] libmm-glib: use helper function to convert enum/flags from string

2018-10-04 Thread Aleksander Morgado
On 10/4/18 1:09 AM, Thomas Haller wrote: > --- > libmm-glib/mm-common-helpers.c | 298 - > 1 file changed, 106 insertions(+), 192 deletions(-) > These 2 patches are a nice cleanup, thanks :) See a minor comment below. > diff --git a/libmm-glib/mm-common-helpers.c

Re: [PATCH 1/2] port-serial: port mm_port_serial_reopen to use GTask

2018-10-04 Thread Aleksander Morgado
On 9/27/18 9:27 AM, Ben Chan wrote: > --- > src/mm-port-serial.c | 84 +--- > 1 file changed, 40 insertions(+), 44 deletions(-) > Pushed to git master, thanks > diff --git a/src/mm-port-serial.c b/src/mm-port-serial.c > index 38d4e477..c4fee187 100644 > -

Re: [PATCH 2/2] port-serial: port mm_port_serial_flash to use GTask

2018-10-04 Thread Aleksander Morgado
On 9/27/18 9:27 AM, Ben Chan wrote: > --- > src/mm-port-serial.c | 92 +--- > 1 file changed, 44 insertions(+), 48 deletions(-) > Pushed to git master, thanks > diff --git a/src/mm-port-serial.c b/src/mm-port-serial.c > index c4fee187..41a5fc27 100644 > -

Re: Openwrt with EM7455 connecting issue

2018-10-03 Thread Aleksander Morgado
Hey, > > maybe that is the problem. Now this might be dumb question. How do I find > which usb is in use? > Thanks again for your help > Run this to get the sysfs path of the wwan0 interface of the modem: $ realpath /sys/class/net/wwan0/device /sys/devices/pci:00/:00:14.0/usb2/2-3/2-3:2.

Re: Openwrt with EM7455 connecting issue

2018-10-03 Thread Aleksander Morgado
Hey, > Here is my netifd integration. This is the only one I created,nothing else. > > config interface 'wwan' > >option device > '/sys/devices/platform/soc/f1058000.usb/usb1/1-1/1-1.2/1-1.2.1' > >option proto'modemmanager' > >option apn 'Broadband' > Does that

Re: Openwrt with EM7455 connecting issue

2018-10-03 Thread Aleksander Morgado
Hey, > The very first thing I do is follow your instructions. otherwise I don't even > know where to start. Thanks for getting back to me. > Here are the issues so far. > 1. during the make menuconfig ,I am getting some warning. Does that matter? > WARNING: Makefile 'package/utils/busybox/Makefi

Re: Openwrt with EM7455 connecting issue

2018-10-03 Thread Aleksander Morgado
>I am using OpenWrt 18.06.1 r7258-5eb055306f on linksys AC1900V2 > router. EM7455 Generic firmware with M.2 usb enclosure and modemmanager > 1.8.2. I followed instruction on your website to compile the package. But I > can't get any connection. I have to issue 3 commands in order to get

Re: Preferred way to get signal information

2018-10-03 Thread Aleksander Morgado
Hey! > If your using c/c++ consider looking into the library ModemManager > exposes, this is how mmcli works > (https://cgit.freedesktop.org/ModemManager/ModemManager/tree/libmm-glib). > It handles the dbus calls for you and just exposes some nice c code > wrappers. In your case you should look at

Re: Preferred way to get signal information

2018-10-03 Thread Aleksander Morgado
Hey Nick, > Is there a preferred way to get the signal information from modem manager > periodically for the purposes of illuminating some LED’s? Currently I am > running mmcli -m 0 and using grep to strip it down to just the number and > taking action based on that value. (—signal-get is not

Re: Problems to get valid location data with Sierra Wireless MC7455

2018-09-26 Thread Aleksander Morgado
Hey, > >> >> > [...] Do you have the GPS specific antenna connected to the module? Do > >> >> > you have good satellite coverage? > >> >> > >> >> The GPS specific antenna is connected to the module and hopefully the > >> >> satellite coverage is sufficient (my mobile phone tells me that it sees >

Re: SIM hot swapping - what is the expected behavior?

2018-09-25 Thread Aleksander Morgado
> I have a dual SIM hardware setup with a MC7430 in QMI mode where both SIMs > are attached to the SIM 1 & SIM 2 pins on the modem. I do not have any > ability to switch SIMs using GPIO or anything in between. > > I have been playing with modem manager to switch the SIMs using the —command > pa

Re: Problems to get valid location data with Sierra Wireless MC7455

2018-09-24 Thread Aleksander Morgado
> >> > [...] Do you have the GPS specific antenna connected to the module? Do > >> > you have good satellite coverage? > >> > >> The GPS specific antenna is connected to the module and hopefully the > >> satellite coverage is sufficient (my mobile phone tells me that it sees > >> 10/27 satellites i

Re: [review v2] Voice implementation fixes (with audio channel setup handlers)

2018-09-22 Thread Aleksander Morgado
Hey, On Wed, Sep 19, 2018 at 6:29 PM Bob Ham wrote: > > On 16/08/18 17:30, Bob Ham wrote: > > > Possibly, yes. The SimTech (== SIMCom) plugin is using the > > MMBroadbandModemQmi class which means I either need to (1) subclass > > MMBroadbandModemQmi and mix in AT commands, or (2) use the plugin

ANN: ModemManager 1.8.2

2018-09-22 Thread Aleksander Morgado
Hey hey, This is the first bugfix release in the ModemManager 1.8.x series. Overview of changes in ModemManager 1.8.2 --- * Docs: ** Fix explanation of MM_CALL_STATE_RINGING_{IN|OUT}. ** Fix documentation of mm_modem_get_equipment_identifier(). *

Re: [PATCH] mmcli,location: fix doubled variable declaration

2018-09-21 Thread Aleksander Morgado
On Fri, Sep 21, 2018 at 12:21 PM Ulrich Ölmann wrote: > > Remove the redundant declaration of which slipped into the code in commit > 091bf4dbd811 ("api: support location assistance data"). > > Signed-off-by: Ulrich Ölmann Pushed, thanks! > --- > cli/mmcli-modem-location.c | 1 - > 1 file chan

Re: Problems to get valid location data with Sierra Wireless MC7455

2018-09-21 Thread Aleksander Morgado
> > [...] Do you have the GPS specific antenna connected to the module? Do > > you have good satellite coverage? > > The GPS specific antenna is connected to the module and hopefully the > satellite coverage is sufficient (my mobile phone tells me that it sees > 10/27 satellites if it is held next

Re: Problems to get valid location data with Sierra Wireless MC7455

2018-09-20 Thread Aleksander Morgado
Hey Ulrich, > I have a customer's i.MX6 based board that runs under a current Linux > kernel and is equipped with a Sierra Wireless MC7455 LTE modem which is > connected to an invalid SIM card (contract expired). Nevertheless I am > of course able to successfully scan for available 3GPP networks a

Re: HP lt4120 failing to make single-stack connections on LTE using MM

2018-09-06 Thread Aleksander Morgado
On Thu, Sep 6, 2018 at 11:29 AM, Tore Anderson wrote: > * Aleksander Morgado > >> Oh wait, this is a Intel based MBIM modem, right? If so, we need >> AT-based reset operations. I believe I still have the HPlt4120 around >> here, will try to implement that. Tr

Re: HP lt4120 failing to make single-stack connections on LTE using MM

2018-09-06 Thread Aleksander Morgado
On Thu, Sep 6, 2018 at 10:46 AM, Bjørn Mork wrote: > Aleksander Morgado writes: > >> Oh wait, this is a Intel based MBIM modem, right? If so, we need >> AT-based reset operations. I believe I still have the HPlt4120 around >> here, will try to implement that. Tr

Re: Sierra EM7355 - Cannot connect

2018-09-06 Thread Aleksander Morgado
> Interesting I did try this, even a few times, in the past. But I just > tried again, and it works! Ok, so that means we may need to tweak the probing phase to try longer for the cdc-wdm port. -- Aleksander https://aleksander.es ___ ModemManager-d

Re: HP lt4120 failing to make single-stack connections on LTE using MM

2018-09-06 Thread Aleksander Morgado
> $ sudo mmcli -m 0 --reset Thanks - I had overlooked that one, but it doesn't quite work: error: couldn't reset the modem: 'GDBus.Error:org.freedesktop.ModemManager1.Error.Core.Unsupported: Cannot reset the modem: operation not supported' >>> >>> Oh wow, whi

Re: [SOLVED] Quectel EC21, Debian Jessie, kernel 4.4 (patched)

2018-09-06 Thread Aleksander Morgado
On Wed, Sep 5, 2018 at 2:28 PM, Brendan Simon (eTRIX) wrote: > >> Date: Fri, 31 Aug 2018 11:28:47 +0200 >> From: Aleksander Morgado >> Subject: Re: Quectel EC21, Debian Jessie, kernel 4.4 (patched) >> >> On Fri, Aug 31, 2018 at 9:24 AM, Brendan Simon (SEPL) >

Re: Sierra EM7355 - Cannot connect

2018-09-06 Thread Aleksander Morgado
Hey, On Mon, Aug 27, 2018 at 11:48 AM, Yevgeny Bar Lev wrote: > Hello, > Thank you for the prompt response, > I am using, > /usr/lib/libmbim-glib.so -> libmbim-glib.so.4.3.0 > and > ModemManager (version 1.8.0) > Kernel 4.17.14 This is strange. Could it be maybe a timing issue? Have you tried to

Re: HP lt4120 failing to make single-stack connections on LTE using MM

2018-09-05 Thread Aleksander Morgado
> >> $ sudo mmcli -m 0 --reset > > Thanks - I had overlooked that one, but it doesn't quite work: > > error: couldn't reset the modem: > 'GDBus.Error:org.freedesktop.ModemManager1.Error.Core.Unsupported: Cannot > reset the modem: operation not supported' > Oh wow, which MM are you using? Thi

Re: HP lt4120 failing to make single-stack connections on LTE using MM

2018-09-04 Thread Aleksander Morgado
Hey, > > I have an 'HP lt4120 Snapdragon X5 LTE' WWAN module running firmware > revision 'T77W595.F0.0.0.6.6.GC.029 1 [Jul 06 2016 23:00:00' (latest > available on HP's web site). > > It tends to frequently get to a state where MM fails to establish single- > stack connections while in LTE cover

Re: Quectel EC21, Debian Jessie, kernel 4.4 (patched)

2018-08-31 Thread Aleksander Morgado
Hey! On Fri, Aug 31, 2018 at 12:00 PM, W. Martin Borgert wrote: > On 2018-08-31 11:28, Aleksander Morgado wrote: >> I believe that is just because you're using an ancient modemmanager >> version, and the new "UIM" support isn't implemented in MM 1.4.0. >&g

Re: Quectel EC21, Debian Jessie, kernel 4.4 (patched)

2018-08-31 Thread Aleksander Morgado
On Fri, Aug 31, 2018 at 9:24 AM, Brendan Simon (SEPL) wrote: > I have a embedded linux system, which has been used with a Quectel UC20 > device without any issues, but moving to the Quectel EC21 is proving > problematic. > > Setup is: > > Zynq 7000 ARM SOC > EC21 dev-kit (connected via USB) > Anal

Re: Initial EPS bearer on u-blox TOBY-L210

2018-08-31 Thread Aleksander Morgado
>> Ideally, and I'm going to work on that in the following weeks, we >> should have an API to allow configuring that default LTE attach APN, >> and of course that requires the device to be fully unregistered from >> the network (so the CFUN=4 comment above makes sense). This should be >> some API t

Re: Initial EPS bearer on u-blox TOBY-L210

2018-08-30 Thread Aleksander Morgado
Hey, > > When using ModemManager with a u-blox TOBY-L210 module (router mode) to > connect to a LTE network, I face some problems. > > > What I see: > When the modem attaches to the network, it creates and activates a default > EPS bearer (with CID=4). The APN resulting for this PDP Context depend

Re: [PATCH] test, modem-helpers: remove unnecessary NULL check for g_free()

2018-08-28 Thread Aleksander Morgado
On Tue, Aug 28, 2018 at 10:10 PM, Ben Chan wrote: > g_free() handles a NULL pointer properly, so there is no need to have a > NULL check before calling g_free(). > --- Pushed, thanks > src/tests/test-modem-helpers.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/

Re: [PATCH] libmm-glib,pco: add missing documentation for MMPco

2018-08-28 Thread Aleksander Morgado
On Mon, Aug 27, 2018 at 9:55 PM, Ben Chan wrote: > --- > libmm-glib/mm-modem-3gpp.c | 2 +- > libmm-glib/mm-pco.c| 25 + > 2 files changed, 26 insertions(+), 1 deletion(-) > Pushed it to git master, and an additional follow up patch to fix several missing things.

[review] SUPL server address validation

2018-08-28 Thread Aleksander Morgado
Hey, Most devices allow specifying the SUPL server in two different ways; either as "IP and PORT" or "FQDN and PORT". Our API had support for "IP and PORT" but then we would just fallback to a generic "URL" string, which never wasn't really a valid URL. This patch introduces some minor validation

[review] Print LAC/TAC/CID in hex in mmcli output

2018-08-28 Thread Aleksander Morgado
Hey, How about this? https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/33 Cheers -- Aleksander https://aleksander.es ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/m

Re: [review] New 'Pco' property in Modem3gpp interface

2018-08-27 Thread Aleksander Morgado
Hey Ben, > > See > https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/27 > > This MR adds a 'Pco' property to the Modem3gpp interface for reporting > raw PCO values received from the network as we discussed in > https://lists.freedesktop.org/archives/modemmanager-devel/20

Re: Sierra Wireless em7345 disconnects from USB Bus

2018-08-27 Thread Aleksander Morgado
Hey, > > recently we got reports from customers in the Netherlands and some parts > of Germany that their Sierra Wireless EM7345 modems (all build into > various Lenovo laptops) stopped working. > > In Germany this has so far only be the case for Deutsche Telekom SIM > cards. I strongly suspect th

Re: Sierra EM7355 - Cannot connect

2018-08-27 Thread Aleksander Morgado
Hey, On Sat, Aug 25, 2018 at 2:03 PM, Yevgeny Bar Lev wrote: > Hello, > ModemManager is not able to connect to the port. Tried the solution > described here > https://www.freedesktop.org/software/ModemManager/api/1.8.0/ref-overview-modem-filter.html, > and it didn't help. > Help will be appreciat

Re: USB Modem 'PolicyMismatch' after USB cable disconnection

2018-08-27 Thread Aleksander Morgado
Hoola Ana, > Modem: PHS8-P MC1213690-TERM-GPS Rel. 3.001 > > Testing versions: > > network-manager 1.6.2-3 amd64 > modemmanager 1.6.4-1 amd6 > > The problem was not present with network-manager 0.8.6 and modemmanager > 0.6.0. > > > The modem is Activated at the beginning. I disconnect the USB cabl

[review] Unmanaged GPS support for the Dell DW5821e

2018-08-27 Thread Aleksander Morgado
Hey, The following MR implements support for enabling/disabling "unmanaged GPS" support in the Dell DW5821e. This allows us to enable or disable the NMEA traces output in a TTY, so that other applications like gpsd can make use of that information. https://gitlab.freedesktop.org/mobile-broadband/

Re: [PATCH] mbim: fix inconsistency in WITH_QMI guards

2018-08-23 Thread Aleksander Morgado
On 22/08/18 22:26, Ben Chan wrote: > --- > src/mm-broadband-modem-mbim.c | 4 ++-- > src/mm-port-mbim.c| 4 ++-- > src/mm-port-mbim.h| 2 +- > src/mm-port-probe.c | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > Pushed, thanks > diff --git a/src/mm-

Re: [PATCH] broadband-modem-mbim: add missing guard for shared_qmi_init()

2018-08-22 Thread Aleksander Morgado
On 22/08/18 02:38, Ben Chan wrote: > Fixes: 9e42a19742de55cf5c0ba4d68069c1845e9392e6 > --- Pushed, thanks > src/mm-broadband-modem-mbim.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c > index 1559ab5b..eb9e723b 100644

Re: [PATCH] port-mbim: add missing guard for try_qmi_over_mbim in mm_port_mbim_open()

2018-08-22 Thread Aleksander Morgado
On 22/08/18 02:27, Ben Chan wrote: > Fixes: c0cc694c67d9e71f200fb23e20473cc9b31d9ec0 > --- Pushed, thanks > src/mm-port-mbim.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mm-port-mbim.c b/src/mm-port-mbim.c > index f48ebd8f..cd6d9f22 100644 > --- a/src/mm-port-mbim.c > +++ b/

Re: [PATCH] shared-qmi: include string.h for memset()

2018-08-21 Thread Aleksander Morgado
On 21/08/18 23:02, Ben Chan wrote: > This patch fixes the following compiler warning: > > mm-shared-qmi.c:447:9: error: implicitly declaring library function 'memset' > with type 'void *(void *, int, unsigned long)' > [-Werror,-Wimplicit-function-declaration] > memset (buf, 0, sizeof (bu

Re: [PATCH] xmm: include string.h for strlen()

2018-08-21 Thread Aleksander Morgado
lugins/xmm/mm-modem-helpers-xmm.c > b/plugins/xmm/mm-modem-helpers-xmm.c > index a8ede4cf..1c2280af 100644 > --- a/plugins/xmm/mm-modem-helpers-xmm.c > +++ b/plugins/xmm/mm-modem-helpers-xmm.c > @@ -13,6 +13,8 @@ > * Copyright (C) 2018 Aleksander Morgado > */ > >

[review] Reset, Capabilities/Modes and Bands management in shared QMI logic

2018-08-21 Thread Aleksander Morgado
Hey, The following MR includes support for reset actions (reset, factory reset), modes/capabilities management and bands management in the shared QMI logic, so reused by both QMI and QMI-over-MBIM capable devices. https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/30 The

[review] ICCID related improvements

2018-08-21 Thread Aleksander Morgado
Hey all, This MR includes some improvements for ICCID reporting: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/29 Fixes several things found recently with China Mobile ICCIDs. Cheers -- Aleksander https://aleksander.es _

Re: ModemManager can't open serial port after previously opening it successfully

2018-08-20 Thread Aleksander Morgado
Hey, +thaller >> > I did some further testing and while ModemManager is continually >> reporting the serial port can't be opened, I was able to connect to the port >> and send AT commands to the modem and the modem responded. This >> means there is something in ModemManager that is triggering th

Re: ModemManager can't open serial port after previously opening it successfully

2018-08-20 Thread Aleksander Morgado
> I did some further testing and while ModemManager is continually reporting > the serial port can't be opened, I was able to connect to the port and send > AT commands to the modem and the modem responded. This means there is > something in ModemManager that is triggering these messages and no

Re: Sierra MC7354: Drowning in "bearer verbose call end reason (6,36): [3gpp] regular-deactivation"

2018-08-20 Thread Aleksander Morgado
Hey, > > I am using the Sierra MC7354 modem, and we are getting unusual > disconnects on AT&T in the US. Vodafone is fine on the same modems, > and this only seems to happen on 4G. AT&T 3G seems to work. > > We start out connected, but after a bit of time we hit > "gsm-wcdma-regular-deactivation

Re: [review v2] Voice implementation fixes (with audio channel setup handlers)

2018-08-16 Thread Aleksander Morgado
> > > > > > The Huawei USB dongles that support voice require a command > > > (AT^DDSETEX=2) to be executed when the call is established, and > > > also > > > need to report which port is being used for audio. In order to > > > support > > > that, instead of subclassing all start/accept/hangup meth

Re: Fibocom L850-GL hangs upon connect.

2018-08-16 Thread Aleksander Morgado
>>> If this modem is going to end up stuck with pure PPP and therefore maxing >>> out at 25Mbps, then I'm not too concerned anyways since its use is rather >>> limited. I just wish I could figure out how to switch this thing to MBIM >>> (Tried everything listed in the AT Command reference guide, in

Re: [PATCH] libmm-glib: add MMPco for handling raw PCO data

2018-08-14 Thread Aleksander Morgado
Hey, > > Before submitting further patches, I just want to make sure the MMPco > gobject implemented in this patch is what you're looking for. MMPco will > be mostly kept in GList (unless you prefer another gobject). > > If this is the right API to be in libmm-glib, I'll submit a few > follow-up p

Re: Fibocom L850-GL hangs upon connect.

2018-08-13 Thread Aleksander Morgado
Hey, > However, once ttyACM0 gets tied up and times out after 10 command retries, > ModemManager removes the modem: > ModemManager[13213]: [1533754896.224557] (tty/ttyACM0) at port timed > out 10 consecutive times, marking modem > '/org/freedesktop/ModemManager1/Modem/0' as invalid > ModemManager

[review] New 'MMSharedCinterion' interface

2018-08-13 Thread Aleksander Morgado
Hey, See this MR: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/26 It implements a new shared interface containing the code shared between the Cinterion modem objects, similar to what's been suggested for Qmi and Xmm in other MRs. It also fixes the logic behind the

Re: [review] QMI LOC based GPS positioning for QMI and Qualcomm-based MBIM devices

2018-08-13 Thread Aleksander Morgado
Hey all, > > See > https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/10 > > The MR implements QMI LOC based GPS positioning, including SUPL-server > based A-GPS and some new support for injecting "assistance data" (e.g. > Qualcomm gpsOneXtra files), useful when the devic

[review v2] Voice implementation fixes (with audio channel setup handlers)

2018-08-10 Thread Aleksander Morgado
Hey Dan, Bob & all, I've updated the "aleksander/voice-fixes" branch to include the "AT^CVOICE based support for Huawei modems that Dan worked on a while ago in his "dcbw/huawei-voice" branch. https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/2 The Huawei USB dongles th

Re: [PATCH] broadband-modem: initialize 'tac' in registration_status_check_ready()

2018-08-10 Thread Aleksander Morgado
On 10/08/18 02:00, Ben Chan wrote: > mm-broadband-modem.c:4395:13: error: variable 'tac' is used uninitialized > whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > if (act == MM_MODEM_ACCESS_TECHNOLOGY_LTE) { > ^ > mm-broa

Re: Adding AT commands to activate call audio over USB endpoint

2018-08-09 Thread Aleksander Morgado
Hey We're using a SIMCom SIM7100 modem which has the ability to exchange call audio data over a USB serial endpoint⁰. To enable this, the modem needs an AT command after the call has connected, AT+CPCMREG=1, and a command after call has disconnected, AT+CPCMREG=0. >>> >>>

Re: [review] Use AT+CESQ for signal interface in MBIM modems if TTY available

2018-08-09 Thread Aleksander Morgado
On Thu, Aug 9, 2018 at 4:39 PM, Aleksander Morgado wrote: >>> > This MR enables support for the "Signal" interface in MBIM modems >>> > if >>> > they expose an AT-capable TTY port and AT+CESQ is supported. If no >>> > AT >>> &

Re: [review] Use AT+CESQ for signal interface in MBIM modems if TTY available

2018-08-09 Thread Aleksander Morgado
>> > This MR enables support for the "Signal" interface in MBIM modems >> > if >> > they expose an AT-capable TTY port and AT+CESQ is supported. If no >> > AT >> > port is available in the device, the modem will report no extended >> > signal capabilities, as it was doing until now for all MBIM mod

Re: [review] Use AT+CESQ for signal interface in MBIM modems if TTY available

2018-08-09 Thread Aleksander Morgado
Hey, > > This MR enables support for the "Signal" interface in MBIM modems if > they expose an AT-capable TTY port and AT+CESQ is supported. If no AT > port is available in the device, the modem will report no extended > signal capabilities, as it was doing until now for all MBIM modems. > > https

[review] MBIM ATDS service based 3GPP location and extended Signal interface support

2018-08-09 Thread Aleksander Morgado
Hey, The following MR introduces support for using the MBIM ATDS service extensions to query for 3GPP location (LAC/TAC/CID) as well as extended signal information (RSRP, RSRQ, RSSI...). The MR contains 3 commits but only the last 2 are relevant. The first one is a commit cherry-picked from the a

Re: [PATCH] build: require libmbim 1.17.3

2018-08-09 Thread Aleksander Morgado
On 08/08/18 22:27, Ben Chan wrote: > libmbim 1.17.3 adds the support for MBIM_CID_PCO, which is used by > commit d68078b2ce0f ("broadband-modem-mbim: check if modem implements > MBIM_CID_PCO"). > --- Oops, this should have gone with the commit that introduced the new requirement. Thanks for fixin

[review] Fix MM_SIGNAL_UNKNOWN usage

2018-08-09 Thread Aleksander Morgado
Hey, The following MR fixes how MM_SIGNAL_UNKNOWN is used to report unset values: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/24 I thought of deprecating the symbol and adding a new one instead, given that we're changing the actual value of the symbol, but that wo

[review] USSD support for MBIM

2018-08-08 Thread Aleksander Morgado
Hey, This MR adds USSD support for MBIM devices, and while at it, also ported the original MMBroadbandModem USSD support to GTask: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/23 The MBIM USSD logic basically matches what we had for the AT+CUSD based logic. The mai

Re: [review v2] New 'fibocom' plugin (with a new Intel XMM modem class)

2018-08-08 Thread Aleksander Morgado
>> >> I've now pushed an updated MR to suggest the Fibocom plugin, this time >> including a new "Icera-like" Intel XMM chipset detection. If the modem >> is found to be based on Intel XMM, supporting the "AT+X.." commands, >> then we will use them for things like mode switching. This updated MR >>

Re: [PATCH 2/2] broadband-modem-mbim: subscribe to MBIM_CID_PCO notifications

2018-08-08 Thread Aleksander Morgado
On Wed, Aug 8, 2018 at 1:52 PM, Aleksander Morgado wrote: > On Wed, Aug 8, 2018 at 12:16 AM, Ben Chan wrote: >> This patch changes MMBroadbandModem to subscribe to MBIM_CID_PCO >> notifications if the modem supports that. >> --- > > LGTM, please merge > Also merged

Re: [PATCH 1/2] broadband-modem-mbim: check if modem implements MBIM_CID_PCO

2018-08-08 Thread Aleksander Morgado
> On Wed, Aug 8, 2018 at 12:16 AM, Ben Chan wrote: >> Being a part of a series that adds PCO support for MBIM modems that >> implement the MBIM_CID_PCO extension, this patch issues a >> MBIM_CID_DEVICE_SERVICES query during the modem initialization to check >> if a modem implements MBIM_CID_PCO. I

[review] Provide TAC in addition to LAC in Location interface

2018-08-08 Thread Aleksander Morgado
Hey all, This MR updates the Location interface to provide a separate Tracking Area Code value (TAC) in addition to the Location Area Code (LAC). https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/22 The generic AT-based modem implementation is updated so that the CEREG

[review v2] New 'fibocom' plugin (with a new Intel XMM modem class)

2018-08-08 Thread Aleksander Morgado
Hey all, I've now pushed an updated MR to suggest the Fibocom plugin, this time including a new "Icera-like" Intel XMM chipset detection. If the modem is found to be based on Intel XMM, supporting the "AT+X.." commands, then we will use them for things like mode switching. This updated MR includes

Re: [PATCH 2/2] broadband-modem-mbim: subscribe to MBIM_CID_PCO notifications

2018-08-08 Thread Aleksander Morgado
On Wed, Aug 8, 2018 at 12:16 AM, Ben Chan wrote: > This patch changes MMBroadbandModem to subscribe to MBIM_CID_PCO > notifications if the modem supports that. > --- LGTM, please merge > src/mm-broadband-modem-mbim.c | 76 --- > 1 file changed, 71 insertions(+),

<    7   8   9   10   11   12   13   14   15   16   >