Access MMBroadbandModemPrivate from plugin

2015-12-02 Thread Carlo Lobrano
all messaging interface for this and it is not clear to me how access to "current_sms_mem1_storage" parameter in MMBroadbandModemPrivate. Is it even possible? Thanks in advance for any help Best regards, Carlo Lobrano ___

Re: Access MMBroadbandModemPrivate from plugin

2015-12-03 Thread Carlo Lobrano
I though to keep changes confined to only one plugin from the beginning, but adding a new interface to MMBroadbandModemClass does make sense to me. On 2 December 2015 at 19:40, Aleksander Morgado wrote: > On Wed, Dec 2, 2015 at 5:50 PM, Carlo Lobrano wrote: > > I am trying to solve

[PATCH] telit plugin: add modem_power_down

2015-12-03 Thread Carlo Lobrano
Hi, this patch add modem_power_down feature for telit plugin. The change is quite simple, it sends +CFUN=4 to the modem in order to let it go to low power state. Best regards, Carlo Lobrano diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c index

[PATCH] Telit plugin: Add modem_power_down

2015-12-04 Thread Carlo Lobrano
Hi, as requested, sending again the patch in a proper way, I hope it is now right, sorry for the mistake. This patch let Telit plugin send AT+CFUN=4 when modem_power_down is called, letting the modem going in low power state. Best regards, Carlo Lobrano Carlo Lobrano (1): Add

[PATCH] Add modem_power_down to telit plugin

2015-12-04 Thread Carlo Lobrano
--- plugins/telit/mm-broadband-modem-telit.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c index 971e85e..f4fe03c 100644 --- a/plugins/telit/mm-broadband-modem-telit.c +++ b/plugi

Re: [PATCH] Telit plugin: Add modem_power_down

2015-12-04 Thread Carlo Lobrano
Great! Thank you Carlo Il giorno ven 4 dic 2015 11:03 AM Aleksander Morgado < aleksan...@aleksander.es> ha scritto: > On Fri, Dec 4, 2015 at 9:06 AM, Carlo Lobrano wrote: > > Hi, > > > > as requested, sending again the patch in a proper way, I hope it is now >

Telit plugin: question about mm-broadband-modem reset interface

2015-12-09 Thread Carlo Lobrano
the reset against a AT#REBOOT command, so just a reboot, without any kind of reconfiguration, is this the right way to use this interface? Best regards, Carlo Lobrano ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org http

Re: Telit plugin: question about mm-broadband-modem reset interface

2015-12-09 Thread Carlo Lobrano
Perfect, thank you Carlo On 9 December 2015 at 16:48, Dan Williams wrote: > On Wed, 2015-12-09 at 11:13 +0100, Carlo Lobrano wrote: > > Hi, > > > > I would like to know if there is any convention about what the > > mm-broadband-modem reset interface should do an

[PATCH 1/2] telit: add modem_reset to telit plugin

2015-12-09 Thread Carlo Lobrano
--- plugins/telit/mm-broadband-modem-telit.c | 25 + 1 file changed, 25 insertions(+) diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c index f4fe03c..925face 100644 --- a/plugins/telit/mm-broadband-modem-telit.c +++ b/plugin

[PATCH 0/2] telit: add modem_reset to telit plugin

2015-12-09 Thread Carlo Lobrano
Hello, this patch is intended to implement modem_reset interface for Telit modules. Best regards, Carlo Lobrano Carlo Lobrano (2): telit: add modem_reset to telit plugin Fix function names plugins/telit/mm-broadband-modem-telit.c | 25 + 1 file changed, 25

[PATCH 2/2] Fix function names

2015-12-09 Thread Carlo Lobrano
--- plugins/telit/mm-broadband-modem-telit.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c index 925face..104b4c1 100644 --- a/plugins/telit/mm-broadband-modem-telit.c +++ b/plugins/t

Re: [PATCH 0/2] telit: add modem_reset to telit plugin

2015-12-10 Thread Carlo Lobrano
no reason actually, you can squash them Thank you, Carlo Lobrano On 10 December 2015 at 23:17, Aleksander Morgado wrote: > On 09/12/15 18:06, Carlo Lobrano wrote: > > Carlo Lobrano (2): > > telit: add modem_reset to telit plugin > > Fix function names > > Any

[PATCH] Telit plugin: add load_unlock_retries

2015-12-14 Thread Carlo Lobrano
Hi, this patch add the implementation of load_unlock_retries to Telit plugin. Please let me know if it is ok like this or it needs changes. Best regards Carlo Carlo Lobrano (1): Telit plugin: add load_unlock_retries interface plugins/telit/mm-broadband-modem-telit.c | 169

[PATCH] Telit plugin: add load_unlock_retries interface

2015-12-14 Thread Carlo Lobrano
--- plugins/telit/mm-broadband-modem-telit.c | 169 +++ plugins/telit/mm-broadband-modem-telit.h | 2 + 2 files changed, 171 insertions(+) diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c index 0f77231..b34503d 100644

Re: [PATCH] Telit plugin: add load_unlock_retries interface

2015-12-14 Thread Carlo Lobrano
Hi, thank you for the quick and useful reply. I will submit a new patch with the changes you suggested Best regards, Carlo On 14 December 2015 at 15:19, Aleksander Morgado wrote: > Hey! > > See comments below. > > On Mon, Dec 14, 2015 at 12:51 PM, Carlo Lobrano > wrote: &g

[PATCH] Telit plugin: add load_unlock_retries interface

2015-12-15 Thread Carlo Lobrano
From: Carlo Lobrano --- plugins/Makefile.am | 18 +- plugins/telit/mm-broadband-modem-telit.c | 192 ++ plugins/telit/mm-modem-helpers-telit.c| 77 + plugins/telit/mm-modem-helpers-telit.h| 25

[PATCH] Telit plugin: add load_unlock_retries (2nd attempt)

2015-12-15 Thread Carlo Lobrano
From: Carlo Lobrano Hi, here's my new version of the patch, according to the previous code review: - it uses context in place of the plugin's private structure - response parser in a separate helper file (with tests) - errors are handled - I replaced the at_sequence with a state mach

Re: [PATCH] Telit plugin: add load_unlock_retries interface

2015-12-15 Thread Carlo Lobrano
Hi, thanks for the feedback, I'll apply the changes suggested. > And I just realized after submitting that all errors are ignored > during all the steps... I think the logic I suggested still applies, > though, to keep clear who owns the 'retries' object. > > But now, shouldn't we fail with an err

[PATCH v3] Telit plugin: add load_unlock_retries interface

2015-12-16 Thread Carlo Lobrano
From: Carlo Lobrano Hi, version 3 of the patch, with the fixes according to the previous coding review - memory management of Context's MMUlockRetries instance - error propagation in case of failure of all 4 requests - code style Thank you, Carlo Carlo Lobrano (1): Telit plugin

[PATCH v3] Telit plugin: add load_unlock_retries interface

2015-12-16 Thread Carlo Lobrano
From: Carlo Lobrano --- plugins/Makefile.am | 18 ++- plugins/telit/mm-broadband-modem-telit.c | 183 ++ plugins/telit/mm-modem-helpers-telit.c| 75 + plugins/telit/mm-modem-helpers-telit.h| 25

Re: [PATCH v3] Telit plugin: add load_unlock_retries interface

2015-12-19 Thread Carlo Lobrano
Awesome, thanks a lot! Il giorno sab 19 dic 2015 11:58 AM Aleksander Morgado < aleksan...@aleksander.es> ha scritto: > Hey Carlo, > > On Wed, Dec 16, 2015 at 3:38 PM, Carlo Lobrano > wrote: > > > > version 3 of the patch, with the fixes according to the previous co

[no subject]

2015-12-22 Thread Carlo Lobrano
Hi all, I am using cinterion and other plugins as reference to implement load_supported_bands for Telit plugin, but there is a point which is not clear for me. In my reference plugins I've always seen this kind of result assignement supported_bands_ready (...) { /* get the results */

Re:

2015-12-22 Thread Carlo Lobrano
​Got it, thanks a lot! Carlo​ On 22 December 2015 at 18:34, Aleksander Morgado wrote: > Hey! > > On Tue, Dec 22, 2015 at 5:27 PM, Carlo Lobrano > wrote: > > I am using cinterion and other plugins as reference to implement > > load_supported_bands for Telit plugin, bu

[PATCH] Telit plugin: add load_supported_bands interface

2016-01-13 Thread Carlo Lobrano
Hi, this patch implements `load_supported_bands` for the following Telit's modems: - HE910 EU* - HE910 NA* - LE910 EU V2 - LE910 NA V2 - LE910 SV V2 Carlo Lobrano (1): [Telit Plugin] Add load_supported_bands for some Telit modem models plugins/telit/77-mm-telit-port-types.rules

[PATCH] [Telit Plugin] Add load_supported_bands for some Telit modem models

2016-01-13 Thread Carlo Lobrano
From: Carlo Lobrano Supported models: - HE910 EU* - HE910 NA* - LE910 EU V2 - LE910 NA V2 - LE910 SV V2 --- plugins/telit/77-mm-telit-port-types.rules| 4 + plugins/telit/mm-broadband-modem-telit.c | 59 +++ plugins/telit/mm-modem-helpers-telit.c| 129

Re: [PATCH] Telit plugin: add load_supported_bands interface

2016-01-13 Thread Carlo Lobrano
Wed, 2016-01-13 at 11:55 +0100, Carlo Lobrano wrote: > > Hi, > > > > this patch implements `load_supported_bands` for the following > > Telit's modems: > > Does AT#BND=? not work on these devices, or does it not return accurate > results? Maybe I miss

Re: [PATCH] Telit plugin: add load_supported_bands interface

2016-01-14 Thread Carlo Lobrano
supported bands, that I did not consider it as a solution. Now I made some design and it should be feasible. Sorry for the mess, I will propose another patch. On 14 January 2016 at 09:44, Aleksander Morgado wrote: > On Thu, Jan 14, 2016 at 8:51 AM, Carlo Lobrano > wrote: > > AT#BND does ret

[PATCH] [Telit plugin] add load_supported_bands interface

2016-01-18 Thread Carlo Lobrano
Hi, here is a new proposal implementation for load_supported_bands interface for Telit modems. Best regards, Carlo Carlo Lobrano (1): [Telit plugin] add load_supported_bands interface plugins/telit/77-mm-telit-port-types.rules| 4 + plugins/telit/mm-broadband-modem-telit.c

[PATCH] [Telit plugin] add load_supported_bands interface

2016-01-18 Thread Carlo Lobrano
--- plugins/telit/77-mm-telit-port-types.rules| 4 + plugins/telit/mm-broadband-modem-telit.c | 86 + plugins/telit/mm-modem-helpers-telit.c| 372 +- plugins/telit/mm-modem-helpers-telit.h| 58 plugins/telit/tests/test-mm-mo

Re: [PATCH] [Telit plugin] Add load_supported_bands interface

2016-01-25 Thread Carlo Lobrano
Thank you! Carlo On Mon, 25 Jan 2016 at 14:02 Aleksander Morgado wrote: > On 25/01/16 11:02, c.lobr...@gmail.com wrote: > > From: Carlo Lobrano > > > > --- > > plugins/telit/mm-broadband-modem-telit.c | 86 + > > plugins/telit/mm-modem

Re: [PATCH] [Telit plugin] Add load_current_bands interface

2016-02-08 Thread Carlo Lobrano
Hello guys, any news about this patch? Is there something I need to fix? Thanks, Carlo On Thu, 28 Jan 2016 at 17:30 wrote: > From: Carlo Lobrano > > --- > plugins/telit/mm-broadband-modem-telit.c | 78 +- > plugins/telit/mm-modem-helpers-telit.c

Re: [PATCH] [Telit plugin] Add load_current_bands interface

2016-02-08 Thread Carlo Lobrano
Thank you! Carlo On Mon, 8 Feb 2016 at 13:44 Aleksander Morgado wrote: > On Mon, Feb 8, 2016 at 1:38 PM, Carlo Lobrano wrote: > > Hello guys, > > any news about this patch? Is there something I need to fix? > > > > It's in my backlog for review, along with so

Fixing bug 93135 (AT+CPMS error with Telit modems)

2016-03-07 Thread Carlo Lobrano
o use the value of "current_sms_mem1_storage" when the local value of mem1 in mm_broadband_modem_lock_sms_storages is UNKNOWN Best regards, Carlo Lobrano ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: [PATCH] Fix Bug 93135 +CPMS emtpy parameter not always supported

2016-03-07 Thread Carlo Lobrano
ed to rework this patch for that, > just take it into consideration for future patches :) > ​I will ​ > > See comments below. > > On Mon, Mar 7, 2016 at 3:04 PM, wrote: > > From: Carlo Lobrano > > > > - Add new async virtual method load_current_storages t

Re: [PATCH v3] Fix Bug 93135 +CPMS emtpy parameter support

2016-03-09 Thread Carlo Lobrano
Great! Thanks Carlo On 9 March 2016 at 14:46, Aleksander Morgado wrote: > On 09/03/16 11:27, c.lobr...@gmail.com wrote: > > From: Carlo Lobrano > > > > * Add new async virtual method init_current_storages to > > MMIfaceModemMessaging > > * Add

[PATCH] [PATCH v2] [TELIT] implemented set current bands

2016-03-10 Thread Carlo Lobrano
--- Hello, I fixed the usage of mm_base_at_command_finish and the other changes required in the previous code review. Hope everything is fine now. Thanks, Carlo --- data/ModemManager.service.in | 2 +- plugins/telit/mm-broadband-modem-telit.c | 294 +

Re: [PATCH] [PATCH v2] [TELIT] implemented set current bands

2016-03-10 Thread Carlo Lobrano
Oh, really sorry for that, I didn't realize it. Fixing it and re-submitting Carlo On 10 March 2016 at 14:19, Aleksander Morgado wrote: > On Thu, Mar 10, 2016 at 12:41 PM, Carlo Lobrano > wrote: > > --- > > > > Hello, > > > > I fixed the usage of mm_bas

[PATCH v2] [TELIT] implemented set current bands

2016-03-10 Thread Carlo Lobrano
--- Hi, this is the same patch version 2 without the unrelated reindentation, sorry again for the waste of time. Carlo --- plugins/telit/mm-broadband-modem-telit.c | 117 + plugins/telit/mm-modem-helpers-telit.c| 85 ++ plugins/telit/mm-modem-helpers-t

Update SIM related data according to an event

2016-03-11 Thread Carlo Lobrano
Hi all, I'm trying to update some modem data according to an unsolicited event. Telit modems have an unsolicited indication #QSS (Query SIM Status) which is emitted when the SIM status changes (e.g. SIM removed/inserted). My intention is to register an handler to this notification and somehow tr

Re: Update SIM related data according to an event

2016-03-13 Thread Carlo Lobrano
from the start, the modem is not initialized at all, so I cannot even set an handler to watch for unsolicited events. Do you think that is something that can be changed? Carlo On Sat, 12 Mar 2016 at 21:17 Aleksander Morgado wrote: > On Fri, Mar 11, 2016 at 5:21 PM, Carlo Lobrano >

Re: Update SIM related data according to an event

2016-03-13 Thread Carlo Lobrano
Thanks a lot! I'll have a look at that Carlo Il dom 13 mar 2016 11:57 AM Aleksander Morgado ha scritto: > On Sun, Mar 13, 2016 at 10:25 AM, Carlo Lobrano > wrote: > > That looks like a lot of work :D, better design all the changes before > > starting. > > W

Re: Update SIM related data according to an event

2016-03-22 Thread Carlo Lobrano
that I am still debugging, when SIM is removed and then re-inserted, like if the port status is invalid, "partially" close). Do you think is a viable solution? Best regards, Carlo On 13 March 2016 at 12:46, Carlo Lobrano wrote: > Thanks a lot! I'll have a look at that > >

Re: Update SIM related data according to an event

2016-03-24 Thread Carlo Lobrano
Hi Aleksander, thank you for this reply, lot of information and clear. Carlo On 23 March 2016 at 10:06, Aleksander Morgado wrote: > Hey! > > On Tue, Mar 22, 2016 at 3:25 PM, Carlo Lobrano > wrote: > > I had some time now to look at the changes for SIM hot insertio

[PATCH] Fixed cgmi_retries in dell_custom_init

2016-04-04 Thread Carlo Lobrano
Initialized "cgmi_retries" variable from CustomInitContext with the same value as the other retries, moreover the context is now allocated with g_slice_new0. Before this changes, when cgmi_retries assumed big values during the probing of no AT-capable ports, the command AT+CGMI (mm-plugin-dell.c:

Re: Update SIM related data according to an event

2016-04-07 Thread Carlo Lobrano
u, 24 Mar 2016 at 16:50 Carlo Lobrano wrote: > Hi Aleksander, > > thank you for this reply, lot of information and clear. > > Carlo > > On 23 March 2016 at 10:06, Aleksander Morgado > wrote: > >> Hey! >> >> On Tue, Mar 22, 2016 at 3:25 PM, Carlo Lobr

Re: [PATCH] port-probe: make sure stored task pointer is set to NULL before completing

2016-04-11 Thread Carlo Lobrano
Hi Daniele, it looks like the last commit introduced a some kind of problem. HE910 initialization ends with error > Modem couldn't be initialized: couldn't load current capabilities: Failed to determine modem capabilities Here's the pastebin link of the logs of this test, > http://pastebin.com/

Re: [PATCH] port-probe: make sure stored task pointer is set to NULL before completing

2016-04-13 Thread Carlo Lobrano
No worries :) I double checked and I can confirm the issue is gone. Thanks, Carlo On Wed, 13 Apr 2016 at 09:46 Aleksander Morgado wrote: > On Mon, Apr 11, 2016 at 4:56 PM, Carlo Lobrano > wrote: > > > > it looks like the last commit introduced a some kind of problem. HE910

Could not get unlock retries soon after SIM unlock

2016-05-04 Thread Carlo Lobrano
Hi, I observed a problem in getting the number of unlock retries of some SIMs soon after the unlock (the SIM in not completely ready I assume) and I saw that some plug-ins inserted a little delay in modem_after_sim_unlock to cope with it, but that wouldn't have any effect in my case. I could dela

Re: Could not get unlock retries soon after SIM unlock

2016-05-13 Thread Carlo Lobrano
Thanks Dan, that's what I thought. I understand the problem for shipping this with 1.6, so 1.6.2 for me is fine. On Thu, 12 May 2016 at 18:17 Dan Williams wrote: > On Wed, 2016-05-04 at 17:21 +0200, Carlo Lobrano wrote: > > Hi, > > > > I observed a problem in ge

[PATCH 2/2] Adding a short delay after SIM unlock

2016-05-13 Thread Carlo Lobrano
A short delay is necessary with some SIMs when they have just been unlocked. Using 1 second as secure margin. --- plugins/telit/mm-broadband-modem-telit.c | 38 1 file changed, 38 insertions(+) diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit

[PATCH 1/2] Inverted steps in update_lock_info_context_step

2016-05-13 Thread Carlo Lobrano
Inverted steps UPDATE_LOCK_INFO_CONTEXT_STEP_RETRIES and UPDATE_LOCK_INFO_CONTEXT_STEP_AFTER_UNLOCK. Soon after the unlock, the SIM can be busy and loading unlock retries might fail. When implemented, let run "after unlock" logic before any other step in update lock info, when SIM is not locked t

Re: [PATCH 2/2] Adding a short delay after SIM unlock

2016-05-17 Thread Carlo Lobrano
> On Fri, May 13, 2016 at 5:15 PM, Carlo Lobrano > wrote: > > A short delay is necessary with some SIMs when > > they have just been unlocked. Using 1 second as secure margin. > > I assume there's no SIM status notification, or maybe a command to > check for SIM read

Re: [PATCH 2/2] Adding a short delay after SIM unlock

2016-05-18 Thread Carlo Lobrano
Great, thanks! Carlo On Wed, 18 May 2016 at 09:20 Aleksander Morgado wrote: > On Tue, May 17, 2016 at 4:59 PM, Carlo Lobrano > wrote: > > I tried with +CPIN?, but it returns READY, while the next command for > > loading the unlock retries fails. It would be possible to chec

[PATCH] Hardening PORTCFG parse reply

2016-06-01 Thread Carlo Lobrano
A brief explaination of the issue that this patch solves. I observed a probing failure at resume from memory (S3), caused by a missing or wrong reply to #PORTCFG? AT command sent during port probing. This error is probably due to the overposition of multiple messages and replies, since at the same

Re: [PATCH 1/2] Inverted steps in update_lock_info_context_step

2016-06-01 Thread Carlo Lobrano
Hi, has this change already merged? On Fri, 13 May 2016 at 20:05 Aleksander Morgado wrote: > On Fri, May 13, 2016 at 5:15 PM, Carlo Lobrano > wrote: > > Inverted steps UPDATE_LOCK_INFO_CONTEXT_STEP_RETRIES and > > UPDATE_LOCK_INFO_CONTEXT_STEP_AFTER_UNLOCK. > > > &

Re: [PATCH] Hardening PORTCFG parse reply

2016-06-13 Thread Carlo Lobrano
the updated patch. On 10 June 2016 at 19:27, Dan Williams wrote: > On Wed, 2016-06-01 at 14:51 +0200, Carlo Lobrano wrote: >> A brief explaination of the issue that this patch solves. >> I observed a probing failure at resume from memory (S3), caused by a >> missing or wro

[PATCH] Core logic to support SIM hot swap

2016-06-30 Thread Carlo Lobrano
BaseModem added reprobe property. MMDevice added logic to recreate the modem if it is set invalid and "to reprobe" MMBroadbandModem * added initialization step for SIM hot swap: 1. keep dedicated ports open to listen to modem's unsolicited 2. dedicated error management in case of ini

Re: [PATCH] Core logic to support SIM hot swap

2016-06-30 Thread Carlo Lobrano
drivers, mm_plugin_get_name (self), vendor, -product)); + product, + TRUE /* support s

Re: [PATCH] Hardening PORTCFG parse reply

2016-06-30 Thread Carlo Lobrano
id you see this > issue while you were testing the SIM hotplug thing? Remember that > there's an extra port open reference in that case. > > Adding some code change to support a situation that shouldn't happen > doesn't seem a good thing, we should fix the root cause! :

Re: [PATCH] Core logic to support SIM hot swap

2016-06-30 Thread Carlo Lobrano
On giovedì 30 giugno 2016 15:54:48 CEST Aleksander Morgado wrote: > Hey Carlo! > > On Thu, Jun 30, 2016 at 1:36 PM, Carlo Lobrano wrote: > > BaseModem > > added reprobe property. > > > > MMDevice > > added logic to recreate the mod

Re: [PATCH] Core logic to support SIM hot swap

2016-07-01 Thread Carlo Lobrano
Hi Aleksander, thanks for the review. I agree with all the changes, but regarding the usage of the secondary port, the reason is that I couldn't get unsolicited messages from the primary port when the modem is connected to a network. The same problem does not occur when not connected, namely I

Re: [PATCH] Core logic to support SIM hot swap

2016-07-01 Thread Carlo Lobrano
What about set it in the secondary if it exists, and in the primary if it doesn't? I'm thinking about the case where I receive the unsolicited on both and I have to decide which one to reject On 1 July 2016 at 11:00, Aleksander Morgado wrote: > On Fri, Jul 1, 2016 at 10:47 AM,

[PATCH 1/2] Core logic to support SIM hot swap

2016-07-06 Thread Carlo Lobrano
Hello, this is the second attempt for this patch. I should have fixed all the problems observed in the first code review. Best regards, Carlo --- BaseModem added reprobe property. MMDevice added logic to recreate the modem if it is set invalid and "to reprobe" MMBroadbandModem * added i

[PATCH 2/2] Telit plugin: add support to SIM hot swap

2016-07-06 Thread Carlo Lobrano
MMBroadbandModemTelit: * added logic to set MMBroadbandModem's SIM_HOT_SWAP property to TRUE * added function to enable QSS unsolicited * added QSS unsolicited handler --- plugins/telit/mm-broadband-modem-telit.c | 136 +- 1 files changed, 135 insertions(+), 1 deleti

Re: [PATCH 2/2] Telit plugin: add support to SIM hot swap

2016-07-11 Thread Carlo Lobrano
On 11 July 2016 at 14:09, Aleksander Morgado wrote: > You shouldn't be passing the return of g_regex_new() directly to > mm_port_serial_at_add_unsolicited_msg_handler(), as that method takes > its own reference of the GRegex, and therefore the regex would be > leaking afterwards. You should g_reg

Re: [PATCH] Hardening PORTCFG parse reply

2016-07-13 Thread Carlo Lobrano
new debug traces are. On 11 July 2016 at 13:56, Aleksander Morgado wrote: > On Thu, Jul 7, 2016 at 5:45 PM, Carlo Lobrano wrote: > > I manage to replicate only a slightly different behavior, the log is in > > attachment. > > > > > > The test case is the following:

Re: [PATCH 2/2] Telit plugin: add support to SIM hot swap

2016-07-13 Thread Carlo Lobrano
es = set_current_modes; iface->set_current_modes_finish = set_current_modes_finish; +iface->setup_sim_hot_swap = modem_setup_sim_hot_swap; +iface->setup_sim_hot_swap_finish = modem_setup_sim_hot_swap_finish; } static void On 11 July 2016 at 14:14, Carlo Lobrano wrote: > > On 11 July 2016 at

[PATCH 1/2] Modem: support SIM hot swap (4th attempt)

2016-08-08 Thread Carlo Lobrano
BaseModem added reprobe property. MMDevice added logic to recreate the modem if it is set invalid and "to reprobe" MMBroadbandModem * added initialization step for SIM hot swap: 1. keep dedicated ports open to listen to modem's unsolicited 2. dedicated error management in case of ini

[PATCH 2/2] Telit: add support to SIM hot swap (4th attempt)

2016-08-08 Thread Carlo Lobrano
MMBroadbandModemTelit: * added logic to set MMBroadbandModem's SIM_HOT_SWAP property to TRUE * added function to enable QSS unsolicited * added QSS unsolicited handler --- plugins/telit/mm-broadband-modem-telit.c | 141 ++- 1 file changed, 140 insertions(+), 1 deleti

Re: [PATCH 1/2] Modem: support SIM hot swap (4th attempt)

2016-08-10 Thread Carlo Lobrano
Awsome! Thank you Il mer 10 ago 2016 09:53 Aleksander Morgado ha scritto: > On Mon, Aug 8, 2016 at 3:47 PM, Carlo Lobrano wrote: > > BaseModem > > added reprobe property. > > > > MMDevice > > added logic to recreate the modem if it is set invalid and &quo

Data ports and maximum number of bearers

2016-09-19 Thread Carlo Lobrano
Hello, I have a question about the maximum number of bearers that can be created. My understanding is that this number is bind to the number of data ports and these have to be of NET type (like wwan). Is that correct? Best regards, Carlo ___ ModemManag

Re: Data ports and maximum number of bearers

2016-09-19 Thread Carlo Lobrano
ts.freedesktop.org/archives/modemmanager-devel/2014-June/001187.html> is this the correct direction? BR, Carlo On 19 September 2016 at 12:38, Aleksander Morgado wrote: > On Mon, Sep 19, 2016 at 11:20 AM, Carlo Lobrano > wrote: > > > > I have a question about the maximum

Re: Data ports and maximum number of bearers

2016-09-20 Thread Carlo Lobrano
liams wrote: > On Mon, 2016-09-19 at 12:38 +0200, Aleksander Morgado wrote: > > On Mon, Sep 19, 2016 at 11:20 AM, Carlo Lobrano > > wrote: > > > > > > > > > I have a question about the maximum number of bearers that can be > > > created. > > > &

Re: Data ports and maximum number of bearers

2016-09-23 Thread Carlo Lobrano
Hi Bjørn, thanks for this reply, it's full of information! Carlo On 20 September 2016 at 11:16, Bjørn Mork wrote: > Carlo Lobrano writes: > > > Initially I'd like to investigate this topic without considering the > > protocol (AT, MBIM, QMI), and only the mo

Re: Data ports and maximum number of bearers

2016-10-04 Thread Carlo Lobrano
up default Thanks in advance, Carlo On 23 September 2016 at 09:44, Carlo Lobrano wrote: > Hi Bjørn, > > thanks for this reply, it's full of information! > > Carlo > > On 20 September 2016 at 11:16, Bjørn Mork wrote: > >> Carlo Lobrano writes: >> >&g

[PATCH] Telit: Optimized supported and current band code

2016-10-20 Thread Carlo Lobrano
In place of two slightly different regexes for 2g/3g and 2g/3g/4g modems we now use only one regex with conditional patterns for both supported and current Bands detection. Adding also minor fix in test code --- plugins/telit/mm-modem-helpers-telit.c| 18 -- plugins/te

Fallback MBIM on custom plugin

2016-11-11 Thread Carlo Lobrano
Hello everybody, I'm working on a MBIM modem with GPS capabilities and my understanding is that, since there is no service to access GPS through MBIM protocol, for the gps APIs the ModemManager falls back to the generic broadband modem plugin. If this is correct, would it be possible to make it fa

Re: Fallback MBIM on custom plugin

2016-11-14 Thread Carlo Lobrano
I see. Curious, because I can send "location" commands through mmcli to a MBIM modem and I thought it was because the fallback. I'll look into Cinterion plugin though, thanks a lot! On Fri, 11 Nov 2016 at 18:10 Aleksander Morgado wrote: > On Fri, Nov 11, 2016 at 3:26 PM, Carl

[PATCH] Telit: Blacklist LE866 flashing device

2016-12-07 Thread Carlo Lobrano
--- plugins/telit/77-mm-telit-port-types.rules | 5 + 1 file changed, 5 insertions(+) diff --git a/plugins/telit/77-mm-telit-port-types.rules b/plugins/telit/77-mm-telit-port-types.rules index 36a4f99..072c48f 100644 --- a/plugins/telit/77-mm-telit-port-types.rules +++ b/plugins/telit/77-mm-

Re: [PATCH] Telit: Blacklist LE866 flashing device

2016-12-10 Thread Carlo Lobrano
Oh sure, no problem On 7 December 2016 at 16:22, Dan Williams wrote: > On Wed, 2016-12-07 at 12:59 +0100, Carlo Lobrano wrote: > > --- > > plugins/telit/77-mm-telit-port-types.rules | 5 + > > 1 file changed, 5 insertions(+) > > Would you mind moving this to

[PATCH v2] Telit: Blacklist LE866 flashing device

2016-12-12 Thread Carlo Lobrano
Moved blacklist code to 77-mm-usb-device-blacklist.rules as per code review --- src/77-mm-usb-device-blacklist.rules | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/77-mm-usb-device-blacklist.rules b/src/77-mm-usb-device-blacklist.rules index 28ef060..3ef6310 100644 --- a/src/77-mm-us

[PATCH] [Telit Plugin] Wrong port peek in telit_qss_toggle_ready

2016-12-20 Thread Carlo Lobrano
qss unsolicited handler should be assigned to primary port first, while secondary port was peeked. --- plugins/telit/mm-broadband-modem-telit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c

[PATCH 1/2] Extended wda set format message to enable QMUX

2017-02-15 Thread Carlo Lobrano
Added the following configurable values: - upload datagram protocol - download datagram protocol - download datagram max size - download max datagrams - endpoint type - endpoint interface number According to last GobiNet from CodeAura project, setting the following values is necessary to enable mu

[PATCH 2/2] Added WDS Bind Mux Data Port message

2017-02-15 Thread Carlo Lobrano
This message is used to bind a muxed data port to a controller device. The Muxed data port has to be managed by qmi_wwan driver. The Muxed data port is identified by: - mux_id: the numeric ID given to qmi_wwan once created - interface number: the interface number of the qmi controller device on

Re: Telit HE910 not connecting with Modem Manager 1.6.4

2017-03-14 Thread Carlo Lobrano
; On Mon, Mar 13, 2017 at 03:48:51PM +0000, Carlo Lobrano wrote: > > Hi Salvador, > > > > I'll look into this CSIM lock thing, but with a newer FW version I'm > > actually getting responses to CSIM and the next messages (see logs > below). > > > > Hi

Re: [PATCH] telit: enable 'SIM ready' notifications with #QSS=2

2017-03-15 Thread Carlo Lobrano
Hi Aleksander, that's weird. By the way I should be able to test it this afternoon with a LE910 or HE910 and let you know. BR, Carlo On Wed, 15 Mar 2017 at 00:38 Aleksander Morgado wrote: > It will allow us to avoid totally or partially the after-sim-unlock > explicit wait time that we're forc

Re: [PATCH] telit: lock/unlock CSIM operations by default

2017-03-15 Thread Carlo Lobrano
Hi all, I agree with Dan, we should send the unlock csim command. I should be able to test and fix it this afternoon. BR, Carlo On Wed, 15 Mar 2017 at 02:40 Dan Williams wrote: > On Wed, 2017-03-15 at 00:19 +0100, Aleksander Morgado wrote: > > Wrap the AT+CSIM=XX commands between lock (CSIM=1)

Re: [PATCH] telit: lock/unlock CSIM operations by default

2017-03-15 Thread Carlo Lobrano
nder Morgado [mailto:aleksan...@aleksander.es] > Sent: miércoles, 15 de marzo de 2017 10:28 > To: Dan Williams > Cc: Carlo Lobrano; Penalva, Salvador; Daniele Palmas; ModemManager > (development) > Subject: Re: [PATCH] telit: lock/unlock CSIM operations by default > > On Wed, Mar 1

Re: [PATCH v2] telit: lock/unlock CSIM operations by default

2017-03-16 Thread Carlo Lobrano
Hi all, Sorry for the late reply, but I was double checking this change because of the last paragraph in +CSIM reference: > After the locking of the SIM-ME interface (AT+CSIM=1) the SIM will be > accessible only by AT+CSIM commands (#QSS: 0). The GSM and GPRS services > will be automatically de-r

Re: [PATCH v2] telit: lock/unlock CSIM operations by default

2017-03-16 Thread Carlo Lobrano
o it. #QSS: 0/1 are for physical changes on SIM, #QSS: 2 should be for SIM unlock, but we're not listening to it. On Thu, 16 Mar 2017 at 11:17 Aleksander Morgado wrote: > On Thu, Mar 16, 2017 at 10:58 AM, Carlo Lobrano > wrote: > > Sorry for the late reply, but I was double c

Re: [PATCH] telit: enable 'SIM ready' notifications with #QSS=2

2017-03-17 Thread Carlo Lobrano
Hi Aleksander, I tested your patch and it seems working fine, even if #QSS: 3 always arrives very late respect any acceptable timeout (the modem reads all SIM values, even sms, before signaling QSS:3). Moreover, this change would be really helpful for the issue I reported in "[PATCH] telit: lock/u

Re: [PATCH] telit: enable 'SIM ready' notifications with #QSS=2

2017-03-17 Thread Carlo Lobrano
Aleksander Morgado wrote: > On Fri, Mar 17, 2017 at 10:23 AM, Carlo Lobrano > wrote: > > > > I tested your patch and it seems working fine, even if #QSS: 3 always > > arrives very late respect any acceptable timeout (the modem reads all SIM > > values, even sms, bef

Re: [PATCH] telit: enable 'SIM ready' notifications with #QSS=2

2017-03-17 Thread Carlo Lobrano
Well, before "#QSS: 3" you can expect some errors accessing the SIM, but it's not forbidden, and in fact we got some errors sometimes, like "SIM Busy" On Fri, 17 Mar 2017 at 10:38 Aleksander Morgado wrote: > On Fri, Mar 17, 2017 at 10:35 AM, Carlo Lobrano > w

Re: [PATCH] telit: enable 'SIM ready' notifications with #QSS=2

2017-03-17 Thread Carlo Lobrano
On Fri, 17 Mar 2017 at 12:00 Aleksander Morgado wrote: > On Fri, Mar 17, 2017 at 11:39 AM, Carlo Lobrano > wrote: > > Well, before "#QSS: 3" you can expect some errors accessing the SIM, but > > it's not forbidden, and in fact we got some errors sometimes,

Re: SIM hot swap with SIM locked

2017-03-17 Thread Carlo Lobrano
const ModemCaps *cap = modem_caps; guint32 ret = 0; mm_dbg ("parse_caps_gcap on '%s'", response); if (!response) return FALSE; However, still not a clue about why a use case with SIM locked should work differently that one with SIM unlocked. On Fri

Re: SIM hot swap with SIM locked

2017-03-17 Thread Carlo Lobrano
ager[3946]: (ttyACM0): <-- '332OK' mar 17 16:45:17 D2040 ModemManager[3946]: parse_caps_gcap on '(null)' mar 17 16:45:17 D2040 ModemManager[3946]: (ttyACM0): --> 'AT+CPIN?' mar 17 16:45:17 D2040 ModemManager[3946]: (ttyACM0): <-- '+CME ERROR: 10' mar 17 1

Re: SIM hot swap with SIM locked

2017-03-20 Thread Carlo Lobrano
n Fri, 17 Mar 2017 at 21:03 Aleksander Morgado wrote: > On Fri, Mar 17, 2017 at 4:55 PM, Carlo Lobrano > wrote: > > mar 17 16:45:15 D2040 ModemManager[3946]: (ttyACM0): --> > > 'AT+GCAP' > > mar 17 16:45:15 D2040 ModemManager[3946]: (ttyACM0): <-- >

[PATCH] Fixed wrong MEM1 value passed to +CPMS

2017-03-23 Thread Carlo Lobrano
Let mem1_str defaulting to NULL when current_sms_mem1_storage is MM_SMS_STORAGE_UNKNOWN modem_messaging_set_default_storage considers mem1 storage string valid if *not NULL*, but, previously, when we could not get current_sms_mem1_storage value right, mem1_str defaulted to "unknown" and that strin

Re: [PATCH] Fixed wrong MEM1 value passed to +CPMS

2017-03-23 Thread Carlo Lobrano
t. So, set_default_storage should return error directly when it finds that mem1 is UNKNOWN. Is that right? On Thu, 23 Mar 2017 at 17:16 Aleksander Morgado wrote: > On Thu, Mar 23, 2017 at 2:29 PM, Carlo Lobrano > wrote: > > Let mem1_str defaulting to NULL when current_sms_mem1_storag

Re: [PATCH] Fixed wrong MEM1 value passed to +CPMS

2017-03-23 Thread Carlo Lobrano
ppened, so we should just return error here as well, IMO. Ok, I'll update the patch then On Thu, 23 Mar 2017 at 19:39 Aleksander Morgado wrote: > On Thu, Mar 23, 2017 at 5:32 PM, Carlo Lobrano > wrote: > >> So why is current_sms_mem1_storage UNKNOWN? At which point did it &g

  1   2   3   >