API Call proposal

2015-04-20 Thread Riccardo Vangelisti
Hi, in refer to opened bug https://bugs.freedesktop.org/show_bug.cgi?id=84981 I propose the attached patch, to implement voice or data call in MM core. Please let me know what you think. Regards, -- Riccardo Vangelisti - Sadel SpA Software Development Via Serenari 1, Castel Maggiore (BO

Re: API Call proposal

2015-04-20 Thread Riccardo Vangelisti
not contained in this command, a data service call is initiated." Data call is used for example with ZMODEM in order to trasfer files between two endpoint. Thanks, Riccardo Vangelisti - Sadel SpA Software Development Via Serenari 1, Castel Maggiore (BO) Il 20/04/2015 15:51, Aleksande

Re: API Call proposal

2015-04-21 Thread Riccardo Vangelisti
In spite of the last proposal was very similar, for my opinion, to Messaging/SMS style, I've attach'd a new patch with your last suggestions. If you think I don't understand what you said yet, send me your modified patch. Thanks, Ricc

Re: API Call proposal

2015-04-21 Thread Riccardo Vangelisti
Fiuu... ;) I've attach'd the previuosly patch with CallLog renamed to Voice as you want :) Let me know what's the next step. Thanks, Riccardo Vangelisti - Sadel SpA Software Development Via Serenari 1, Castel Maggiore (BO) Il 21/04/2015 11:15, Aleksander Morgado ha scritto:

Re: [SPAM] Re: API Call proposal

2015-04-22 Thread Riccardo Vangelisti
Hi Dan, I agree in almost all of your opinion; see my comments inline. (In the meanwhile, could you already create a git branch with access for me and a colleague of mine that helps me in this project?) Riccardo Vangelisti - Sadel SpA Software Development Via

Re: API Call proposal

2015-04-22 Thread Riccardo Vangelisti
branch: https://bitbucket.org/riccardovangelisti/modemmanager/branch/voicecall Riccardo Vangelisti - Sadel SpA Software Development Via Serenari 1, Castel Maggiore (BO) Il 22/04/2015 11:23, Aleksander Morgado ha scritto: Hey Dan & Riccardo, Some comments from my side. For states: + * MM_CALL_

Re: API Call proposal

2015-04-27 Thread Riccardo Vangelisti
rt in mmcli tool What do you think ? The hard part was choosing the option of the call that interact on it in mm-cli :) If you agree with this implementation we can go ahead with the next steps. Thanks, Riccardo Vangelisti - Sadel SpA Software Development Via Serenari 1, Castel Maggiore (BO) Il

Re: API Call proposal

2015-05-11 Thread Riccardo Vangelisti
(and many other modems). For now we assume that could be one call at time as we decided. We have tested new mm with these modems: * Simcom SIM7250E * Telit GT863-PY * Falcom Twist * Huawei MU709S-2 all modems works ! :) So, could you check these commits ? Regards, Riccardo Vangelisti -

Re: API Call proposal

2015-05-11 Thread Riccardo Vangelisti
Il 11/05/2015 17:19, Aleksander Morgado ha scritto: We have tested new mm with these modems: * Simcom SIM7250E * Telit GT863-PY * Falcom Twist * Huawei MU709S-2 all modems works ! :) Quick question; how do all these modems implement the actual voice channel? Is it a physical audio chan

Re: Branch for review: 'riccardo/voice'

2015-06-03 Thread Riccardo Vangelisti
Il 27/05/2015 17:58, Dan Williams ha scritto: On Sat, 2015-05-23 at 18:31 +0200, Aleksander Morgado wrote: Hey Dan & others, Riccardo & Marco developed an initial draft of the AT-based voice support, including API, libmm-glib, mmcli, generic modem and Huawei-specific implementations; his work i

Re: Branch for review: 'riccardo/voice'

2015-06-03 Thread Riccardo Vangelisti
Il 03/06/2015 16:43, Aleksander Morgado ha scritto: On Wed, Jun 3, 2015 at 4:04 PM, Riccardo Vangelisti wrote: broadband-modem: added voice call support I'm not sure just checking for ATH is a great indicator of voice support; most devices I know of will support ATH, but almost none act

[PATCH] Huawei: Ignore unsolicited message ^EONS

2017-03-24 Thread Riccardo Vangelisti
s_regex); if (self->priv->syscfg_supported_modes) g_array_unref (self->priv->syscfg_supported_modes); -- *Riccardo Vangelisti* Software Design Engineering Dept. *SADEL S.p.A* ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel

Re: [PATCH] Huawei: Ignore unsolicited message ^EONS

2017-03-24 Thread Riccardo Vangelisti
Ops, sorry :) Il 24/03/2017 15:28, Aleksander Morgado ha scritto: Hey Riccardo, On Fri, Mar 24, 2017 at 3:03 PM, Riccardo Vangelisti wrote: Hi, I've found an unsolicited message (^EONS) that broke the incoming voice call in Huawei ME909s-120 modules. This patch can fix it (simply igno

Re: [review] dcbw/huawei-voice

2017-05-04 Thread Riccardo Vangelisti
Hi, sorry for late reply but we took some time to test this branch using these Huawei modems: +---+-+--+---+ | Modem | Firmware| ^CVOICE Support | Voice | +---+-+

Re: [review] dcbw/huawei-voice

2017-05-05 Thread Riccardo Vangelisti
Hi, On Thu, 2017-05-04 at 16:30 +0200, Riccardo Vangelisti wrote: Hi, sorry for late reply but we took some time to test this branch using these Huawei modems: +---+-+--+--- + Modem | Firmware| ^CVOICE Support

Re: [review] dcbw/huawei-voice

2017-05-05 Thread Riccardo Vangelisti
On Fri, 2017-05-05 at 16:40 +0200, Riccardo Vangelisti wrote: Hi, On Thu, 2017-05-04 at 16:30 +0200, Riccardo Vangelisti wrote: Hi, sorry for late reply but we took some time to test this branch using these Huawei modems

huawei: duplicated DTMF tone

2017-05-08 Thread Riccardo Vangelisti
Hi all, I've found a strange behavior when I receive DTMF during voice call. It seems that DTMF code are received and signaled twice, specifically one time for each active AT port. Jan 1 00:02:22 localhost ModemManager[1940]: [1325376142.982264] [mm-port-serial-at.c:459] debug_log(): (ttyUSB

Re: huawei: duplicated DTMF tone

2017-05-09 Thread Riccardo Vangelisti
uld we mark the port on which voice call has been received and, during the call, use only that for DTMF ? Riccardo On Mon, 2017-05-08 at 15:24 +0200, Riccardo Vangelisti wrote: Hi all, I've found a strange behavior when I receive DTMF during voice call. It seems that DTMF code are receive

Re: huawei: duplicated DTMF tone

2017-05-11 Thread Riccardo Vangelisti
lf->priv->dtmf_device_name = NULL; } static void Riccardo Hi Dan, your patch doesn't compile because "if (port)" needs curly braces after that. Apart of that your patch it works but in case of PPP connection DTMF are not handled anyway and CPU loading issue is pres

Re: [review] dcbw/huawei-voice

2017-06-13 Thread Riccardo Vangelisti
Hey, On Fri, 2017-05-05 at 18:56 +0200, Riccardo Vangelisti wrote: On Fri, 2017-05-05 at 16:40 +0200, Riccardo Vangelisti wrote: Hi, On Thu, 2017-05-04 at 16:30 +0200, Riccardo Vangelisti

Re: huawei: duplicated DTMF tone

2017-06-29 Thread Riccardo Vangelisti
ly braces after that. Apart of that your patch it works but in case of PPP connection DTMF are not handled anyway and CPU loading issue is present (in a very remote case if I receive a lot of DTMF messages). Could we mark the port on which voice call has been received and, during the call, u