Re: [PATCH] broadband-modem-mbim: explicitly remove notification handler on unref

2017-08-11 Thread Aleksander Morgado
On Fri, Aug 11, 2017 at 5:04 PM, Aleksander Morgado wrote: > When we remove the last object reference, make sure the notification > handler is also removed, or we may end up using an already freed > object. > > https://retrace.fedoraproject.org/faf/reports/1815001/ Pushed to git master, and backp

Re: [PATCH] broadband-modem-mbim: explicitly remove notification handler on unref

2017-08-11 Thread Aleksander Morgado
>> When we remove the last object reference, make sure the notification >> handler is also removed, or we may end up using an already freed >> object. >> >> https://retrace.fedoraproject.org/faf/reports/1815001/ > > Good catch; any time we connect a signal somewhere in an object, we > should probab

Re: [PATCH] broadband-modem-mbim: explicitly remove notification handler on unref

2017-08-11 Thread Dan Williams
On Fri, 2017-08-11 at 17:04 +0200, Aleksander Morgado wrote: > When we remove the last object reference, make sure the notification > handler is also removed, or we may end up using an already freed > object. > > https://retrace.fedoraproject.org/faf/reports/1815001/ Good catch; any time we conne