Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

2017-06-30 Thread Eric Caruso
On Fri, Jun 30, 2017 at 1:00 AM, Aleksander Morgado wrote: > On 29/06/17 19:20, Eric Caruso wrote: >> Thanks for taking a look at this! >> >> On Thu, Jun 29, 2017 at 3:22 AM, Carlo Lobrano wrote: >>> Hi, >>> If I'm not mistaken, whenever a sim

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

2017-06-30 Thread Aleksander Morgado
On 29/06/17 19:20, Eric Caruso wrote: > Thanks for taking a look at this! > > On Thu, Jun 29, 2017 at 3:22 AM, Carlo Lobrano wrote: >> Hi, >> >>> If I'm not mistaken, whenever a sim insert/removal event is detected, we >>> should just call >>>

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

2017-06-29 Thread Eric Caruso
Thanks for taking a look at this! On Thu, Jun 29, 2017 at 3:22 AM, Carlo Lobrano wrote: > Hi, > >> If I'm not mistaken, whenever a sim insert/removal event is detected, we >> should just call >> mm_broadband_modem_update_sim_hot_swap_detected(), which will trigger a >> full

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

2017-06-29 Thread Aleksander Morgado
On 29/06/17 10:51, Aleksander Morgado wrote: >> +if (self->priv->last_ready_state != >> MBIM_SUBSCRIBER_READY_STATE_SIM_NOT_INSERTED && >> +ready_state == MBIM_SUBSCRIBER_READY_STATE_SIM_NOT_INSERTED) { >> +/* SIM has been removed */ >> +

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

2017-06-29 Thread Aleksander Morgado
Hey Eric, +Carlo in CC Carlo, would also like your opinion on this. On 28/06/17 23:46, Eric Caruso wrote: > If an MBIM modem supports unsolicited notifications for > subscriber ready status, we can use it to detect when SIM cards > have been removed and reinserted. Upon detection we should re-

[PATCH] mm-broadband-modem-mbim: support hot swapping

2017-06-29 Thread Eric Caruso
If an MBIM modem supports unsolicited notifications for subscriber ready status, we can use it to detect when SIM cards have been removed and reinserted. Upon detection we should re- probe the modem so that we can configure it for the new SIM. --- src/mm-broadband-modem-mbim.c | 16

[PATCH] mm-broadband-modem-mbim: support hot swapping

2017-06-28 Thread Eric Caruso
If an MBIM modem supports unsolicited notifications for subscriber ready status, we can use it to detect when SIM cards have been removed and reinserted. Upon detection we should re- probe the modem so that we can configure it for the new SIM. --- src/mm-broadband-modem-mbim.c | 16