Re: [PATCH] sms-part-3gpp: decode Unicode SMS with non-BMP code points

2017-12-18 Thread Aleksander Morgado
On Fri, Dec 15, 2017 at 9:45 AM, Ben Chan wrote: > Depsite 3GPP TS 23.038 specifies that Unicode SMS messages are encoded in > UCS-2, UTF-16 encoding is commonly used instead on many modern platforms to > allow encoding code points that fall outside the Basic Multilingual Plane > (BMP), such as Em

Re: [PATCH] sms-part-3gpp: decode Unicode SMS with non-BMP code points

2017-12-17 Thread Aleksander Morgado
Hey, On Sat, Dec 16, 2017 at 3:03 AM, Ben Chan wrote: > On Fri, Dec 15, 2017 at 1:16 AM Aleksander Morgado wrote: > > Probably a > good change; will test it once I have a chance. > > But regarding the last > fallback, why is it better to return an empty > string than NULL? I assume > that we retu

Re: [PATCH] sms-part-3gpp: decode Unicode SMS with non-BMP code points

2017-12-15 Thread Ben Chan
On Fri, Dec 15, 2017 at 1:16 AM Aleksander Morgado wrote: > > Probably a good change; will test it once I have a chance. > > But regarding the last fallback, why is it better to return an empty > string than NULL? I assume that we return NULL to indicate an error in > parsing, which is what happen

Re: [PATCH] sms-part-3gpp: decode Unicode SMS with non-BMP code points

2017-12-15 Thread Aleksander Morgado
On Fri, Dec 15, 2017 at 9:45 AM, Ben Chan wrote: > Depsite 3GPP TS 23.038 specifies that Unicode SMS messages are encoded in > UCS-2, UTF-16 encoding is commonly used instead on many modern platforms to > allow encoding code points that fall outside the Basic Multilingual Plane > (BMP), such as Em

[PATCH] sms-part-3gpp: decode Unicode SMS with non-BMP code points

2017-12-15 Thread Ben Chan
Depsite 3GPP TS 23.038 specifies that Unicode SMS messages are encoded in UCS-2, UTF-16 encoding is commonly used instead on many modern platforms to allow encoding code points that fall outside the Basic Multilingual Plane (BMP), such as Emoji. Most of the UCS-2 code points are identical to their