Re: [PATCH 4/4] telit: remove custom +CMER enabling

2017-05-29 Thread Aleksander Morgado
On 22/05/17 19:08, Aleksander Morgado wrote: >>> And now that I see this... >>> * Shouldn't we enable +CIEV only for "signal" (that's the only thing >>> we end up parsing in the generic +CIEV parser)? >>> * Shouldn't we move this setting to the generic broadband modem >>> implementation? >> All t

Re: [PATCH 4/4] telit: remove custom +CMER enabling

2017-05-29 Thread Aleksander Morgado
On 21/05/17 14:54, Aleksander Morgado wrote: > This is now managed directly in the generic plugin. > --- This has been merged to git master. > plugins/cinterion/mm-broadband-modem-cinterion.c | 2 + > plugins/telit/mm-broadband-modem-telit.c | 84 > > 2 files c

Re: [PATCH 4/4] telit: remove custom +CMER enabling

2017-05-22 Thread Aleksander Morgado
On Mon, May 22, 2017 at 6:09 PM, Dan Williams wrote: >> And now that I see this... >> * Shouldn't we enable +CIEV only for "signal" (that's the only thing >> we end up parsing in the generic +CIEV parser)? >> * Shouldn't we move this setting to the generic broadband modem >> implementation? > >

Re: [PATCH 4/4] telit: remove custom +CMER enabling

2017-05-22 Thread Dan Williams
On Sun, 2017-05-21 at 15:41 +0200, Aleksander Morgado wrote: > On Sun, May 21, 2017 at 2:54 PM, Aleksander Morgado > wrote: > > +/* Our own enable now */ > > +mm_base_modem_at_command_full ( > >  MM_BASE_MODEM (self), > >  mm_base_modem_peek_port_secondary (MM_BASE_MODEM (s

Re: [PATCH 4/4] telit: remove custom +CMER enabling

2017-05-21 Thread Aleksander Morgado
On Sun, May 21, 2017 at 2:54 PM, Aleksander Morgado wrote: > +/* Our own enable now */ > +mm_base_modem_at_command_full ( > MM_BASE_MODEM (self), > mm_base_modem_peek_port_secondary (MM_BASE_MODEM (self)), > -unsolicited_enable_sequence, > -NULL, /* respo

[PATCH 4/4] telit: remove custom +CMER enabling

2017-05-21 Thread Aleksander Morgado
This is now managed directly in the generic plugin. --- plugins/cinterion/mm-broadband-modem-cinterion.c | 2 + plugins/telit/mm-broadband-modem-telit.c | 84 2 files changed, 60 insertions(+), 26 deletions(-) diff --git a/plugins/cinterion/mm-broadband-modem-cin