Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem-qmi

2018-06-02 Thread Aleksander Morgado
Hey, > > On Thu, May 10, 2018 at 3:47 PM, Ben Chan wrote: >> This branch contains a series of patches that port the remaining code in >> MMBroadbandQmi to use GTask: >> >> https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-modem-qmi > > Gave it a quick

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem-qmi

2018-05-27 Thread Aleksander Morgado
Hey, On Thu, May 10, 2018 at 3:47 PM, Ben Chan wrote: > This branch contains a series of patches that port the remaining code in > MMBroadbandQmi to use GTask: > > https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-modem-qmi Gave it a quick look and it

[review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem-qmi

2018-05-10 Thread Ben Chan
This branch contains a series of patches that port the remaining code in MMBroadbandQmi to use GTask: https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-modem-qmi ___ ModemManager-devel mailing list ModemManage

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem

2017-07-18 Thread Aleksander Morgado
On Mon, Jul 17, 2017 at 5:42 PM, Ben Chan wrote: >> >> Please rebase your branch on top of master, include the missing >> commits you took out, and repush for review. > > Done. Merged the branch to git master now, thanks! -- Aleksander https://aleksander.es _

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem

2017-07-17 Thread Ben Chan
On Mon, Jul 17, 2017 at 1:25 AM, Aleksander Morgado wrote: > On Mon, Jul 17, 2017 at 10:02 AM, Aleksander Morgado > wrote: >>> What you included here as a >>> snippet is a huge bug actually. >> >> Well, not that huge really... the only issue is that we're setting the >> GSimpleAsyncResult result

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem

2017-07-17 Thread Aleksander Morgado
On Mon, Jul 17, 2017 at 10:02 AM, Aleksander Morgado wrote: >> What you included here as a >> snippet is a huge bug actually. > > Well, not that huge really... the only issue is that we're setting the > GSimpleAsyncResult result twice to TRUE. But, of course, if the > parent's implementation isn't

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem

2017-07-17 Thread Aleksander Morgado
On Mon, Jul 17, 2017 at 9:52 AM, Aleksander Morgado wrote: > What you included here as a > snippet is a huge bug actually. Well, not that huge really... the only issue is that we're setting the GSimpleAsyncResult result twice to TRUE. But, of course, if the parent's implementation isn't using a G

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem

2017-07-17 Thread Aleksander Morgado
On Mon, Jul 17, 2017 at 8:49 AM, Ben Chan wrote: > Just realized there may be an issue with changes to some of those > MMIfaceModem3gpp / MMIfaecModemCdma functions implemented by > MMBroadbandModem. Several plugins have code that chains up parent's > function like this: > >if (!iface_modem_cd

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem

2017-07-16 Thread Ben Chan
On Sun, Jul 16, 2017 at 11:03 PM, Ben Chan wrote: > This branch contains a series of patches that port > MMBroadbandModemMbim to use GTask: > > https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-modem Aleksander, Just realized there may be an issue wit

[review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem

2017-07-16 Thread Ben Chan
This branch contains a series of patches that port MMBroadbandModemMbim to use GTask: https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-modem Ben ___ ModemManager-devel mailing list ModemManager-devel@lists.f

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem-mbim

2017-07-12 Thread Aleksander Morgado
On 11/07/17 19:38, Ben Chan wrote: > This branch contains a series of patches that port MMBroadbandModemMbim to > use GTask: > > https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-modem-mbim > Pushed to git master, thanks. I also included a follow up

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem-mbim

2017-07-12 Thread Aleksander Morgado
On 11/07/17 19:38, Ben Chan wrote: > This branch contains a series of patches that port MMBroadbandModemMbim to > use GTask: > > https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-modem-mbim > Pushed to git master, thanks. I also included a follow up

[review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem-mbim

2017-07-11 Thread Ben Chan
This branch contains a series of patches that port MMBroadbandModemMbim to use GTask: https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-modem-mbim Ben ___ ModemManager-devel mailing list ModemManager-devel@li