Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-09-18 Thread Ben Chan
On Tue, Sep 19, 2017 at 12:01 AM, Aleksander Morgado wrote: >> >> I overlooked one thing when I revised the patches based on Dan's >> suggestion, and also missed that in my testing :-( >> >> MMSimMbim:update_modem_unlock_retries() calls >> mm_iface_modem_update_unlock_retries() to report remainin

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-09-18 Thread Aleksander Morgado
> > I overlooked one thing when I revised the patches based on Dan's > suggestion, and also missed that in my testing :-( > > MMSimMbim:update_modem_unlock_retries() calls > mm_iface_modem_update_unlock_retries() to report remaining attempts > PIN1. That won't affect MMBroadbandModemMbimPriv::sim

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-09-18 Thread Ben Chan
Hi Dan and Aleksander, I overlooked one thing when I revised the patches based on Dan's suggestion, and also missed that in my testing :-( MMSimMbim:update_modem_unlock_retries() calls mm_iface_modem_update_unlock_retries() to report remaining attempts PIN1. That won't affect MMBroadbandModemMb

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-09-07 Thread Aleksander Morgado
On Fri, Aug 11, 2017 at 1:02 AM, Ben Chan wrote: > On Thu, Aug 10, 2017 at 3:34 PM, Aleksander Morgado > wrote: > However, we may be able to improve the situation a bit when MM is > running by making mm_iface_modem_update_lock_info preserve what we > have learned from a prior MBIM_CID

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-08-10 Thread Ben Chan
On Thu, Aug 10, 2017 at 3:34 PM, Aleksander Morgado wrote: However, we may be able to improve the situation a bit when MM is running by making mm_iface_modem_update_lock_info preserve what we have learned from a prior MBIM_CID_PIN response. That's what I'm trying to address wi

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-08-10 Thread Ben Chan
On Thu, Aug 10, 2017 at 11:09 AM, Aleksander Morgado wrote: > Hey, > >>> >>> Hum... looks like the patched logic is actually way more confusing >>> than the original one... See attached logs (the -patched file is after >>> your changes). >>> >> >> Thanks for taking time to test the patch set. I s

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-08-10 Thread Aleksander Morgado
Hey, >> >> Hum... looks like the patched logic is actually way more confusing >> than the original one... See attached logs (the -patched file is after >> your changes). >> > > Thanks for taking time to test the patch set. I should keep calling > the carrier to get a PUK code... > :) > Do you b

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-08-10 Thread Ben Chan
On Thu, Aug 10, 2017 at 2:28 AM, Aleksander Morgado wrote: > > Hey > > Hum... looks like the patched logic is actually way more confusing > than the original one... See attached logs (the -patched file is after > your changes). > Thanks for taking time to test the patch set. I should keep callin

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-08-10 Thread Aleksander Morgado
Hey > It really is unfortunate that the MBIM_CID_PIN query only reports the > information of the "currently applicable" PIN type, although the truth > is that that's the only useful one. Yes, indeed. It would have been much better if MBIM_CID_PIN query could take a PIN t

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-08-08 Thread Aleksander Morgado
It really is unfortunate that the MBIM_CID_PIN query only reports the information of the "currently applicable" PIN type, although the truth is that that's the only useful one. >>> >>> Yes, indeed. It would have been much better if MBIM_CID_PIN query >>> could take a PIN type as argu

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-08-08 Thread Ben Chan
On Tue, Aug 8, 2017 at 11:15 AM, Aleksander Morgado wrote: > Hey, > >>> It really is unfortunate that the MBIM_CID_PIN query only reports the >>> information of the "currently applicable" PIN type, although the truth >>> is that that's the only useful one. >> >> Yes, indeed. It would have been muc

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-08-08 Thread Aleksander Morgado
Hey, >> It really is unfortunate that the MBIM_CID_PIN query only reports the >> information of the "currently applicable" PIN type, although the truth >> is that that's the only useful one. > > Yes, indeed. It would have been much better if MBIM_CID_PIN query > could take a PIN type as argument.

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-08-08 Thread Ben Chan
On Tue, Aug 8, 2017 at 12:43 AM, Aleksander Morgado wrote: > Hey, > > It really is unfortunate that the MBIM_CID_PIN query only reports the > information of the "currently applicable" PIN type, although the truth > is that that's the only useful one. Yes, indeed. It would have been much better if

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-08-08 Thread Aleksander Morgado
Hey, On Tue, Aug 8, 2017 at 1:06 AM, Ben Chan wrote: > This branch contains a series of patches to address the following > issue observed on MBIM modems: > > After MMSimMbim performs a MBIM_CID_PIN set operation, it calls > mm_iface_modem_update_lock_info() (through its base class MMBaseSim) > to

[review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

2017-08-07 Thread Ben Chan
This branch contains a series of patches to address the following issue observed on MBIM modems: After MMSimMbim performs a MBIM_CID_PIN set operation, it calls mm_iface_modem_update_lock_info() (through its base class MMBaseSim) to refresh the unlock retries information, which results in a MBIM_C