Re: New 'u-blox' plugin (v2)

2016-10-12 Thread Aleksander Morgado
On Tue, Oct 11, 2016 at 10:13 AM, Aleksander Morgado wrote: >>> ublox: new +UBANDSEL? response parser >> >> +dupstr = g_strdup (mm_strip_tag (response, "+UBANDSEL:")); >> +i = strlen (dupstr); >> +while (i > 0 && (dupstr[i - 1] == '\r' || dupstr[i - 1] == '\n' || >> dupstr[i - 1] == '

Re: New 'u-blox' plugin (v2)

2016-10-12 Thread Aleksander Morgado
On Tue, Oct 11, 2016 at 10:13 AM, Aleksander Morgado wrote: >>> modem-helpers: new helper to parse +CESQ response into MMSignal >> objects >> >> There's some small differences from the way I implemented it in the >> Huawei signal interface, at least for get_rsrq_db() (-19 instead of >> -20). Not

Re: New 'u-blox' plugin (v2)

2016-10-11 Thread Aleksander Morgado
Hey hey, Thanks again for the review :) >> >> * Added support for the new CSFB related registration state values. > > The DENIED handling looks like it changed: > > +/* Denied? */ > +if (ctx->cs == MM_MODEM_3GPP_REGISTRATION_STATE_DENIED || > +ctx->ps == MM_MODEM_3GPP_REGISTRAT

Re: New 'u-blox' plugin (v2)

2016-10-07 Thread Dan Williams
On Wed, 2016-10-05 at 16:27 +0200, Aleksander Morgado wrote: > Hey Dan & everyone, > > After Dan's review, I've updated the branch implementing support for > the ublox devices with the following changes: > >  * +CGCONTRDP parser is generic, and now supports both formats (pre > and post TS 27.007

New 'u-blox' plugin (v2)

2016-10-05 Thread Aleksander Morgado
Hey Dan & everyone, After Dan's review, I've updated the branch implementing support for the ublox devices with the following changes: * +CGCONTRDP parser is generic, and now supports both formats (pre and post TS 27.007 v9.4.0) * Added some additional comments to explain how the static IP add