Re: Problems compiling with clang (3.8.21)

2019-04-05 Thread Andreas Fett
Hi, On 05/04/19 10:03, Aleksander Morgado wrote: >> >> and the compilation was successful with clang 3.8.21. >> Would it be possible to add a clang build the freedesktop gitlab CI? I looked around a little bit, but unfortunately couldn't figure out what image to use. Maybe there is someone on th

Re: Problems compiling with clang (3.8.21)

2019-04-05 Thread Aleksander Morgado
Hey! > > https://gitlab.freedesktop.org/mobile-broadband/libmbim/merge_requests/8 > > https://gitlab.freedesktop.org/mobile-broadband/libqmi/merge_requests/35 > > > https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/88 > > I tested the patches against the following version

Re: Problems compiling with clang (3.8.21)

2019-04-05 Thread Torsten Hilbrich
[ I forgot to include the list in my previous answer] On 03.04.19 19:48, Ben Chan wrote: > Could you try these patches? > > https://gitlab.freedesktop.org/mobile-broadband/libmbim/merge_requests/8 > https://gitlab.freedesktop.org/mobile-broadband/libqmi/merge_requests/35 > https://gitlab.freedeskt

Re: Problems compiling with clang (3.8.21)

2019-04-03 Thread Ben Chan
Could you try these patches? https://gitlab.freedesktop.org/mobile-broadband/libmbim/merge_requests/8 https://gitlab.freedesktop.org/mobile-broadband/libqmi/merge_requests/35 https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/88 Thanks, Ben On Tue, Apr 2, 2019 at 10:42

Re: Problems compiling with clang (3.8.21)

2019-04-02 Thread Torsten Hilbrich
On 02.04.19 17:02, Dan Williams wrote: > I think -Wno-unused-but-set-variable is actually a mistake and it > should be "-Wunused-but-set-variable". But that causes build errors > that we should fix. > > Does clang support -Wunused-but-set-variable? No. > > Also, does making this change in m4/co

Re: Problems compiling with clang (3.8.21)

2019-04-02 Thread Ben Chan
autoconf seems to set GCC = yes for clang. I believe clang supports Wunused-variable instead of Wunused-but-set-variable. We could use the former, which is also supported by gcc. For other unsupported options, we can work around with -Wno-unknown-warning-option or -Xclang-only= On Tue, Apr 2, 2

Re: Problems compiling with clang (3.8.21)

2019-04-02 Thread Dan Williams
On Tue, 2019-04-02 at 15:34 +0200, Torsten Hilbrich wrote: > Hello, > > I tried to compile libmbim (1.16.0), libqmi (1.20.0) and ModemManager > (1.8.0) with clang and got strange results. > > I set the environment variables CC=clang and CXX=clang++ and ran the > autogen.sh, configure, and make st

Problems compiling with clang (3.8.21)

2019-04-02 Thread Torsten Hilbrich
Hello, I tried to compile libmbim (1.16.0), libqmi (1.20.0) and ModemManager (1.8.0) with clang and got strange results. I set the environment variables CC=clang and CXX=clang++ and ran the autogen.sh, configure, and make steps. Then the configure noticed that clang was used and checked for th