Re: Cleaning up SIM hot swap

On Mon, Jul 10, 2017 at 8:37 PM, Eric Caruso wrote: >>> > While trying to implement setup_sim_hot_swap for MBIM modems, I >>> > noticed that I am setting up and enabling unsolicited events for >>> > SUBSCRIBER_INFO type notifications, but not cleaning them up. This >>> >

Re: [PATCH 1/2] broadband-bearer: check error returned by g_task_propagate_error instead

On 06/07/17 20:30, Ben Chan wrote: > When returning an enum value via g_task_return_int, some code assumes > the enum value is always non-negative and thus considers that a negative > value implies an error. This assumption could be invalidated if a > negative value is later added to the enum. To

Re: [PATCH 2/2] plugin: check error returned by g_task_propagate_error instead

On 06/07/17 20:30, Ben Chan wrote: > mm_plugin_supports_port_finish directly casts the value returned by > g_task_propagate_int to MMPluginSupportsResult enum value, which > implicitly assumes MM_PLUGIN_SUPPORTS_PORT_UNKNOWN equals to -1. > Instead of relying on such an implicit assumption, this

Re: [PATCH] iface-modem: fix mm_iface_modem_initialize_finish

On 12/07/17 10:14, Ben Chan wrote: > This fixes commit 66f10d61a20e6c661cb04225835ec7a343f4fe36 > ("iface-modem: port mm_iface_modem_initialize to use GTask"), which > didn't update mm_iface_modem_initialize_finish to use > g_task_propagate_boolean. > --- Pushed to git master, thanks. >

Re: [PATCH] sim hot swap: improved error management

+ Eric for comments On Wed, Jul 12, 2017 at 2:28 PM, Carlo Lobrano wrote: > Currently, when SIM hot swap fails in either mm-iface or plugin, the > ModemManager still opens ports context and prints a message saying that > SIM hot swap is supported and that it's waiting for

Re: [PATCH] telit: fix modem_set_current_bands to use g_task_report_new_error

On 18/07/17 10:27, Aleksander Morgado wrote: > -g_simple_async_report_error_in_idle (G_OBJECT (self), > - callback, > - user_data, > - M

Re: [PATCH] telit: fix modem_set_current_bands to use g_task_report_new_error

On 18/07/17 02:04, Ben Chan wrote: > Commit acf101335 ("telit: port mm-broadband-modem-telit to use GTask") > ported most of the modem_set_current_bands code to use GTask, but missed > a few g_simple_async_report_error_in_idle calls, which potentially leads > to an incorrect G_TASK cast in

Re: [PATCH 1/3] call-list: fix mm_call_list_delete_call to use g_task_report_new_error

On 18/07/17 03:10, Ben Chan wrote: > Commit a08064492 ("call-list: port mm_call_list_delete_call to use GTask") > ported most of the mm_call_list_delete_call code to use GTask, but missed a > g_simple_async_report_error_in_idle calls, which can potentially lead to > an incorrect G_TASK cast in

Re: [PATCH 3/3] sms-mbim: fix peek_device to use g_task_report_new_error

On 18/07/17 03:11, Ben Chan wrote: > When porting MMSmsMbim to use GTask, peek_device wasn't modified to use > g_task_report_new_error, which could potentially lead to an incorrect > G_TASK cast. > --- Pushed to git master, thanks! > src/mm-sms-mbim.c | 13 +++-- > 1 file changed, 7

Re: [PATCH 2/3] iface-modem-time: fix update_network_timezone to use g_task_report_new_error

On 18/07/17 03:11, Ben Chan wrote: > Commit 7c5f308af ("iface-modem-time: port update_network_timezone to use > GTask") ported most of the update_network_timezone code to use GTask, > but missed a g_simple_async_report_error_in_idle call, which could > potentially lead to an incorrect G_TASK cast.

Re: problem with dell latitude

On Tue, Jul 18, 2017 at 1:45 PM, Bartłomiej Knabel wrote: > I've problem with ModemManager (newest, stable) and dell latitude e6540 > > ModemManager /dev/cdc-wdm0 --debug > > output: https://pastebin.com/9e57n3Zb > > do You have any hint for me? I'm fighting with it

Re: problem with dell latitude

On Tue, Jul 18, 2017 at 2:00 PM, Bartłomiej Knabel wrote: >> Is this a custom system? Looks like ModemManager isn't built with QMI >> and/or with an old libqmi not supporting QMI over MBIM. Which libqmi >> and libmbim versions are being used? >> >> Once the initial

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem

On Mon, Jul 17, 2017 at 5:42 PM, Ben Chan wrote: >> >> Please rebase your branch on top of master, include the missing >> commits you took out, and repush for review. > > Done. Merged the branch to git master now, thanks! -- Aleksander https://aleksander.es

Re: problem with dell latitude

On Tue, Jul 18, 2017 at 2:38 PM, Bartłomiej Knabel wrote: > after recompiling in given order result is the same: > > # cat /usr/include/libqmi-glib/qmi-version.h | grep "define >> QMI_MBIM_QMUX_SUPPORTED" > #define _QMI_VERSION_H_ > * This section defines types that

Re: Cleaning up SIM hot swap

On Sat, Jul 8, 2017 at 12:52 PM, carlo wrote: > > > While trying to implement setup_sim_hot_swap for MBIM modems, I > > noticed that I am setting up and enabling unsolicited events for > > SUBSCRIBER_INFO type notifications, but not cleaning them up. This > > might not end up

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-plugins-altair-lte

On Wed, Jul 19, 2017 at 4:23 PM, Ben Chan wrote: >>> https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-plugins-altair-lte >> >> Reviewed. Everything looks good to me, expect for a patch that >> contains part of the logic of the previous

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-bearer

On Wed, Jul 19, 2017 at 4:21 PM, Ben Chan wrote: >>> This branch contains a series of patches that port MMBroadbandBearer >>> to use GTask: >>> >>> https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-bearer >> >> Reviewed, just some

Re: Unexpected +CGDCONT? error: 'Sending command failed: 'Resource temporarily unavailable''

On Thu, Jul 20, 2017 at 11:15 AM, Ben Chan wrote: > On Thu, Jul 20, 2017 at 1:42 AM, Ben Chan wrote: >> Looking into it a bit more, the periodic signal update doesn't seem to >> cause the issue. But it seems like the primary port is closed and then >>

Re: Telit LE910 failing to find network

On Tue, Jul 18, 2017 at 9:30 PM, Kelvin wrote: > Also QMI-related: > grep QMI .config > # CONFIG_MSM_TEST_QMI_CLIENT is not set > CONFIG_USB_NET_QMI_WWAN=y > CONFIG_MSM_QMI_INTERFACE=y > # CONFIG_MEM_SHARE_QMI_SERVICE is not set > CONFIG_QMI_ENCDEC=y > #

Re: Start-up stalls getting own number

On Wed, Jul 19, 2017 at 10:26 AM, Colin Helliwell wrote: > Just trying out this morning's Head revision, and it seems to be stalling at > the point it's trying to read its own number. > mmcli -L reports no modems, and the logs ends with (i.e. there's no further >

Re: Need help with Netgear 341u

On Wed, Jul 19, 2017 at 3:43 AM, Neil Cherry wrote: > I'm stuck at the beginning, I have this nice Netgear 341u and I don't know > where to begin. I currently have a debian server with 1.4 Modem Manager. > The server is headless so I have no access to the applet via X. > >

Re: Parallel enables occurring (when SIM PIN enabled)

On Wed, Jul 19, 2017 at 8:42 AM, Colin Helliwell wrote: > But I wondered whether anything had been re-structured elsewhere which ought > to address the problem anyway? Don't think anything has been done in that regard, no. -- Aleksander https://aleksander.es

Re: Start-up stalls getting own number

On Wed, Jul 19, 2017 at 11:00 AM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > On Wed, Jul 19, 2017 at 10:26 AM, Colin Helliwell > <colin.helliw...@ln-systems.com> wrote: >> Just trying out this morning's Head revision, and it seems to be stalling at >> the

Re: Unexpected +CGDCONT? error: 'Sending command failed: 'Resource temporarily unavailable''

On Thu, Jul 20, 2017 at 2:04 PM, Piotr Figiel wrote: > Hi Ben, > I stumbled on similar issues when dealing with modem restarts on 1.6. > This was briefly discussed here: > https://lists.freedesktop.org/archives/modemmanager-devel/2017-June/005016.html > In that case patch I

Re: sim hot swap problem with Telit GE910-QUAD

On Thu, Jul 20, 2017 at 5:42 PM, Tim Small wrote: > On 20/07/17 09:09, Carlo Lobrano wrote: >> >>> I think that the commands which mm issue causes it to close and reopen >>> the SIM and this takes longer than mm is giving it. How should I work >>> around this? >> >> This modem

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-plugins-zte

On Thu, Jul 20, 2017 at 7:13 AM, Ben Chan wrote: > This branch contains a series of patches that port zte plugin to use GTask: > > https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-plugins-zte Pushed to git master, thanks! -- Aleksander

Re: [PATCH] sim hot swap: improved error management

> > Finally, this patch replaces the MBIM's sim_hot_swap_on private property > with the new property MM_IFACE_MODEM_SIM_HOT_SWAP_CONFIGURED, since they have > the > same meaning. Eric, could you validate the patch with your MBIM modem as well? -- Aleksander https://aleksander.es

Re: Modem disconnect - serial breaks etc.

>> Any chance you can put a log message in src/mm-port- >> serial.c::flash_do(), something like: >> >> GError *error = NULL; >> >> + mm_log("Done flashing"); >> >>/* Recover context */ >> g_assert (self->priv->flash_ctx != NULL); >> >> just so we can figure out how long the flash is

Re: [PATCH] sim hot swap: improved error management

> More importantly, after SIM hot swap is set up, an 'ATZ' command is > issued which resets the modem to power on state and so turns off sim hot > swap notification. > > 41.395075] (ttyUSB0): --> 'AT+CESQ=?' > 41.414255] (ttyUSB0): <-- '' > 41.414400] (ttyUSB0): <-- '' > 41.414426] (ttyUSB0): <--

Re: [PATCH] telit-plugin: ignore QSS when SIM-ME interface is locked

Hey, On Mon, Jul 24, 2017 at 6:23 PM, Carlo Lobrano wrote: > With some modems, the lock/unlock of the SIM-ME interface with +CSIM=1/0 > command is followed by #QSS unsolicited messages. With the current > implementation, this messages are mistaken for SIM swap events and so

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-plugins-longcheer

On Tue, Jul 25, 2017 at 7:33 AM, Ben Chan <benc...@chromium.org> wrote: > > > On Mon, Jul 24, 2017 at 2:11 AM, Aleksander Morgado > <aleksan...@aleksander.es> wrote: >> >> On Fri, Jul 21, 2017 at 6:04 PM, Ben Chan <benc...@chromium.org> wrote: >>

[PATCH] broadband-bearer: run init sequence after flashing in disconnection

The init-sequence configured for the TTY that is being used as data port must not be launched during the port reopen() sequence; instead we must run it manually after the port flashing has finished. --- Hey Tim & Dan, What do you think of this change? It should clear up the mixup of commands

Re: [PATCH] broadband-bearer: run init sequence after flashing in disconnection

>> That patch looks reasonable, with the caveat that I don't have my >> head >> around the code base at all :-). >> >> It appears to do the job in limited testing: >> >> 56.227702] Flashing data port (ttyUSB0)... >> 56.227879] (ttyUSB0): port attributes not fully set >> 57.228965] (ttyUSB0):

Re: [PATCH] broadband-bearer: run init sequence after flashing in disconnection

On Thu, Jul 27, 2017 at 11:15 AM, Tim Small <t...@seoss.co.uk> wrote: > On 26/07/17 18:02, Aleksander Morgado wrote: > >>> ENV{ID_MM_TTY_DTR_BROKEN}="1" >>> >>> ENV{ID_MM_TTY_RTSCTS_BROKEN}="1" >>> >>> is the right thin

Re: [PATCH] bearer-mbim: avoid calling mbim_message_unref on NULL MbimMessage

On 27/07/17 03:25, Ben Chan wrote: > --- > src/mm-bearer-mbim.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Thanks, pushed to git master and backported to mm-1-6. > diff --git a/src/mm-bearer-mbim.c b/src/mm-bearer-mbim.c > index 439de812..63bb0579 100644 > ---

Re: Modem index increment

On Wed, Jul 26, 2017 at 4:57 PM, José wrote: > I have noticed that when unplugging and plugging a modem, ModemManager > increases its index by one. This can be annoying when you are trying > to script something. > > Would it make sense to assign the same index to the same

Re: ATZ in enabling_modem_init() step

On Wed, Jul 26, 2017 at 4:32 PM, Tim Small <t...@seoss.co.uk> wrote: > On 25/07/17 12:47, Aleksander Morgado wrote: >> A quick solution would be to subclass the enabling_modem_init() step >> and after running the parent method, run a Telit specific setup to >> chec

Re: [PATCH] broadband-bearer: run init sequence after flashing in disconnection

> > Incidentally, a similar thing goes for RTS/CTS, these aren't always > connected up, but the flow control setup logic currently says "if the > host supports RTS/CTS and the modem supports RTS/CTS, then turn it on", > which might not be the right thing to do since they might not actually > be

Re: [PATCH] broadband-bearer: fix crm_range_ready

On Wed, Jul 19, 2017 at 12:28 AM, Ben Chan wrote: > crm_range_ready() misses a return statement after it invokes > interface_initialization_step(), which will lead to an invalid access of > the already freed InitAsyncContext. > --- > src/mm-broadband-bearer.c | 1 + > 1

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-bearer

On Wed, Jul 19, 2017 at 8:23 AM, Ben Chan wrote: > This branch contains a series of patches that port MMBroadbandBearer > to use GTask: > > https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-bearer Reviewed, just some minor issues

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-plugins-altair-lte

On Wed, Jul 19, 2017 at 8:25 AM, Ben Chan wrote: > > https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-plugins-altair-lte Reviewed. Everything looks good to me, expect for a patch that contains part of the logic of the previous one, which

Re: Parallel enables occurring (when SIM PIN enabled)

On Wed, Jul 19, 2017 at 2:22 PM, Colin Helliwell <colin.helliw...@ln-systems.com> wrote: > >> On 19 July 2017 at 09:19 Aleksander Morgado <aleksan...@aleksander.es> wrote: >> >> On Wed, Jul 19, 2017 at 8:42 AM, Colin Helliwell >> >> <colin.helliw.

Re: Telit LE910 failing to find network

On Wed, Jul 19, 2017 at 11:48 AM, Kelvin wrote: > Not fully there yet, though, I tried --3gpp-scan and the modem is listed as > disabled: > > linaro@linaro-gnome:~$ sudo mmcli -m 0 --3gpp-scan > error: modem not enabled yet You need to enable it yourself: $ sudo mmcli -m 0

Re: sim hot swap problem with Telit GE910-QUAD

On Mon, Jul 24, 2017 at 12:02 PM, Carlo Lobrano wrote: >> What would happen if you completely disable and enable the handlers > with >> the method I'm suggesting, and then you just let the #QSS=1 > indication >> happen? If the modem already had a SIM inserted, an extra >

Re: sim hot swap problem with Telit GE910-QUAD

Hey, > >> I just reproduced the issue on my hardware, so I can develop a patch for >> this > > > > after some analysis, I think that the fix for this issue should count two > steps > > 1. When +CSIM=1 is sent, the QSS handler should ignore QSS unsolicited -> I > brefly solved this with a

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-plugins-longcheer

On Fri, Jul 21, 2017 at 6:04 PM, Ben Chan wrote: > > This branch contains a series of patches that port longcheer plugin to use > GTask: > > https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-plugins-longcheer > Reviewed. I believe we

Re: sim hot swap problem with Telit GE910-QUAD

On Thu, Jul 20, 2017 at 7:01 PM, Tim Small <t...@seoss.co.uk> wrote: > On 20/07/17 17:26, Aleksander Morgado wrote: >> The AT+CSIM= command there timed out (it took longer than we expected >> it to take, a pity that these logs don't have timestamp), and then we >&

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

back will > trigger on any change in the subscriber ready state, so this would > catch other state changes such as unlocking the SIM. > I sure hope we're not reprobing completely on SIM unlock notifications... Carlo, could you confirm that? >> >> On 29 June 2017 a

Re: [PATCH 3/4] iface-modem-3gpp: port mm_iface_modem_3gpp_disable to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp.c | 103 > -- > 1 file changed, 53 insertions(+), 50 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c > index

Re: [PATCH 2/4] iface-modem-3gpp: port mm_iface_modem_3gpp_enable to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp.c | 144 > ++ > 1 file changed, 70 insertions(+), 74 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c > index

Re: [PATCH 1/4] iface-modem-3gpp: port mm_iface_modem_3gpp_initialize to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp.c | 95 > +-- > 1 file changed, 43 insertions(+), 52 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c > index

Re: [PATCH] sim-mbim: port MMSimMbim to use GTask

On 30/06/17 11:16, Ben Chan wrote: > --- > src/mm-sim-mbim.c | 201 > -- > 1 file changed, 89 insertions(+), 112 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-sim-mbim.c b/src/mm-sim-mbim.c > index 3d99c99d..f112fe7d

Re: [PATCH] iface-modem-3gpp: port mm_iface_modem_3gpp_register_in_network to use GTask

On 30/06/17 11:21, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp.c | 93 > +-- > 1 file changed, 49 insertions(+), 44 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c > index

Re: [PATCH v2] sms-qmi: port MMSmsQmi to use GTask

On 30/06/17 11:57, Ben Chan wrote: > --- > src/mm-sms-qmi.c | 266 > +-- > 1 file changed, 142 insertions(+), 124 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-sms-qmi.c b/src/mm-sms-qmi.c > index 6f604844..fabd417a

Re: [PATCH 4/4] iface-modem-3gpp: port mm_iface_modem_3gpp_reload_current_registration_info to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-3gpp.c | 83 > ++- > 1 file changed, 46 insertions(+), 37 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c > index

Re: [PATCH 1/5] iface-modem-cdma: port mm_iface_modem_cdma_initialize to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-cdma.c | 105 > +- > 1 file changed, 48 insertions(+), 57 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c > index

Re: [PATCH 5/5] iface-modem-cdma: port mm_iface_modem_cdma_run_registration_checks to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-cdma.c | 207 > +- > 1 file changed, 112 insertions(+), 95 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c > index

Re: [PATCH 2/5] iface-modem-cdma: port mm_iface_modem_cdma_enable to use GTask

On 29/06/17 13:46, Ben Chan wrote: > --- > src/mm-iface-modem-cdma.c | 102 > +- > 1 file changed, 46 insertions(+), 56 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-cdma.c b/src/mm-iface-modem-cdma.c > index

Re: [PATCH] sms-qmi: port MMSmsQmi to use GTask

On 30/06/17 11:17, Ben Chan wrote: > --- > src/mm-sms-qmi.c | 263 > +-- > 1 file changed, 139 insertions(+), 124 deletions(-) > Looks like this one won't compile properly: mm-sms-qmi.c: In function ‘sms_send_from_storage’:

Re: [PATCH 01/10] iface-modem: port mm_iface_modem_initialize to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 426 > --- > 1 file changed, 231 insertions(+), 195 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH 02/10] iface-modem: port mm_iface_modem_enable to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 146 > +-- > 1 file changed, 71 insertions(+), 75 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH v2] iface-modem: port mm_iface_modem_wait_for_final_state to use GTask

On 30/06/17 12:52, Ben Chan wrote: > --- > src/mm-iface-modem.c | 103 > --- > 1 file changed, 64 insertions(+), 39 deletions(-) > Pushed to git master after a minor coding style fixup (see below). Also, not sure we really needed a explicit

Re: [PATCH 04/10] iface-modem: port mm_iface_modem_create_bearer to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 53 > > 1 file changed, 24 insertions(+), 29 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH 08/10] iface-modem: port mm_iface_modem_update_lock_info to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 95 > > 1 file changed, 51 insertions(+), 44 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH 05/10] iface-modem: port mm_iface_modem_set_current_bands to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 64 > ++-- > 1 file changed, 32 insertions(+), 32 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH 03/10] iface-modem: port mm_iface_modem_disable to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 18 +++--- > 1 file changed, 7 insertions(+), 11 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index d718e914..28f3bf01 100644 > --- a/src/mm-iface-modem.c

Re: [PATCH 07/10] iface-modem: port mm_iface_modem_set_power_state to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 169 > +++ > 1 file changed, 91 insertions(+), 78 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH 09/10] iface-modem: port internal_load_unlock_required to use GTask

On 30/06/17 11:23, Ben Chan wrote: > --- > src/mm-iface-modem.c | 85 > +++- > 1 file changed, 45 insertions(+), 40 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index

Re: [PATCH] iface-modem: use g_new0 instead of g_slice_new0 to allocate context

On 30/06/17 15:27, Ben Chan wrote: > By using g_new0 instead of g_slice_new0 to allocate certain context > structs, we can simply use g_free as GDestroyNotify in > g_task_set_task_data and get rid of those functions that solely wrap the > g_slice_free call. Pushed to git master, thanks. > --- >

Re: [PATCH 2/4] base-sms: port sms_send to use GTask

On 01/07/17 09:35, Ben Chan wrote: > --- > src/mm-base-sms.c | 99 > ++- > 1 file changed, 55 insertions(+), 44 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-base-sms.c b/src/mm-base-sms.c > index 565e60e2..3c4e01a3

Re: [PATCH 1/2] base-bearer: port mm_base_bearer_connect to use GTask

On 01/07/17 09:33, Ben Chan wrote: > --- > src/mm-base-bearer.c | 55 > ++-- > 1 file changed, 28 insertions(+), 27 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-base-bearer.c b/src/mm-base-bearer.c > index

Re: [PATCH 3/4] base-sms: port sms_delete to use GTask

On 01/07/17 09:35, Ben Chan wrote: > --- > src/mm-base-sms.c | 69 > +-- > 1 file changed, 37 insertions(+), 32 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-base-sms.c b/src/mm-base-sms.c > index 3c4e01a3..93fe31e5

Re: [PATCH 2/2] base-bearer: port mm_base_bearer_disconnect to use GTask

On 01/07/17 09:33, Ben Chan wrote: > --- > src/mm-base-bearer.c | 41 + > 1 file changed, 17 insertions(+), 24 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-base-bearer.c b/src/mm-base-bearer.c > index ca06596d..c3a9ad28 100644 > ---

Re: [PATCH] base-sim: remove unused wait_for_unlock_id in SendPinPukContext

On 01/07/17 05:00, Ben Chan wrote: > Commit d27e40ae9 ("core: new `Initializing' state in the global modem > state machine") added a 'wait_for_unlock_id' field to SendPinPukContext, > but never actually set it up. Good catch :) pushed to git master, thanks. > --- > src/mm-base-sim.c | 4 >

Re: [PATCH 2/3] bearer-qmi: port disconnect to use GTask

On 01/07/17 09:16, Ben Chan wrote: > --- > src/mm-bearer-qmi.c | 72 > + > 1 file changed, 39 insertions(+), 33 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-bearer-qmi.c b/src/mm-bearer-qmi.c > index 0ce4b6be..e0c8e177

Re: [PATCH 1/3] bearer-qmi: port _connect to use GTask

On 01/07/17 09:16, Ben Chan wrote: > --- > src/mm-bearer-qmi.c | 185 > > 1 file changed, 100 insertions(+), 85 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-bearer-qmi.c b/src/mm-bearer-qmi.c > index ae83a1c9..0ce4b6be

Re: [PATCH 5/6] base-sim: port load_* to use GTask

On 04/07/17 20:40, Ben Chan wrote: > This patch ports the following functions to use GTask: > - load_imsi > - load_operator_identifier > - load_operator_name > - load_sim_identifier > --- > src/mm-base-sim.c | 75 > --- > 1 file changed, 33

Re: [PATCH 6/6] base-sim: port mm_base_sim_send_{pin,puk} to use GTask

On 04/07/17 20:40, Ben Chan wrote: > --- > src/mm-base-sim.c | 107 > +++--- > 1 file changed, 54 insertions(+), 53 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-base-sim.c b/src/mm-base-sim.c > index ebfbc35a..f3525e02

Re: [PATCH 2/6] base-sim: port enable_pin to use GTask

On 04/07/17 20:40, Ben Chan wrote: > --- > src/mm-base-sim.c | 21 + > 1 file changed, 9 insertions(+), 12 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-base-sim.c b/src/mm-base-sim.c > index 51e4e6a7..289b6754 100644 > --- a/src/mm-base-sim.c > +++

Re: [PATCH 1/6] base-sim: port change_pin to use GTask

On 04/07/17 20:40, Ben Chan wrote: > --- > src/mm-base-sim.c | 21 + > 1 file changed, 9 insertions(+), 12 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-base-sim.c b/src/mm-base-sim.c > index fdd9ee14..51e4e6a7 100644 > --- a/src/mm-base-sim.c > +++

Re: [PATCH] iface-modem: check error returned by g_task_propagate_error instead

On 06/07/17 07:20, Ben Chan wrote: > When returning an enum value via g_task_return_int, some code assumes > the enum value is always non-negative and thus considers that a negative > value implies an error. This assumption could be invalidated if a > negative value is later added to the enum. To

Re: Huawei ME906s-158 (a.k.a. HP lt4132) IPv6 support

On Thu, Jul 6, 2017 at 10:55 AM, Bjørn Mork wrote: >> After switching it to configuration #3 (MBIM) everything Just Worked >> without any further tinkering. I see the blog post author went for >> configuration #1 instead, and that looks more cumbersome pull off. >> Maybe it has any

Re: [PATCH 3/5] base-call: port call_hangup to use GTask

On 06/07/17 00:12, Ben Chan wrote: > --- > src/mm-base-call.c | 53 + > 1 file changed, 17 insertions(+), 36 deletions(-) > Pushed to git master, thanks. Also please note that I pushed a follow up commit removing the unneeded

Re: [PATCH 2/5] base-call: port call_accept to use GTask

On 06/07/17 00:12, Ben Chan wrote: > --- > src/mm-base-call.c | 55 > ++ > 1 file changed, 18 insertions(+), 37 deletions(-) > Pushed to git master, thanks. Also please note that I pushed a follow up commit removing the unneeded

Re: [PATCH 1/5] base-call: port call_start to use GTask

On 06/07/17 00:12, Ben Chan wrote: > --- > src/mm-base-call.c | 59 > ++ > 1 file changed, 20 insertions(+), 39 deletions(-) > Pushed to git master, thanks. Also please note that I pushed a follow up commit removing the unneeded

Re: [PATCH 4/5] base-call: port call_send_dtmf_ready to use GTask

On 06/07/17 00:12, Ben Chan wrote: > --- > src/mm-base-call.c | 44 +++- > 1 file changed, 11 insertions(+), 33 deletions(-) > Pushed to git master, thanks. Also please note that I pushed a follow up commit removing the unneeded g_task_set_task_data()

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

Hey Eric, +Carlo in CC Carlo, would also like your opinion on this. On 28/06/17 23:46, Eric Caruso wrote: > If an MBIM modem supports unsolicited notifications for > subscriber ready status, we can use it to detect when SIM cards > have been removed and reinserted. Upon detection we should re-

Re: [PATCH 3/4] iface-modem-time: port mm_iface_modem_time_disable to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-time.c | 91 > +-- > 1 file changed, 48 insertions(+), 43 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c > index

Re: [PATCH 1/4] iface-modem-time: port mm_iface_modem_time_initialize to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-time.c | 93 > --- > 1 file changed, 40 insertions(+), 53 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c > index

Re: [PATCH 4/4] iface-modem-time: port update_network_timezone to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-time.c | 120 > +++--- > 1 file changed, 61 insertions(+), 59 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c > index

Re: [PATCH 2/4] iface-modem-time: port mm_iface_modem_time_enable to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-time.c | 108 > +- > 1 file changed, 49 insertions(+), 59 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c > index

Re: [PATCH] mm-broadband-modem-mbim: support hot swapping

On 29/06/17 10:51, Aleksander Morgado wrote: >> +if (self->priv->last_ready_state != >> MBIM_SUBSCRIBER_READY_STATE_SIM_NOT_INSERTED && >> +ready_state == MBIM_SUBSCRIBER_READY_STATE_SIM_NOT_INSERTED) { >

Re: [PATCH 3/3] iface-modem-oma: port mm_iface_modem_oma_disable to use GTask

On 29/06/17 06:43, Ben Chan wrote: > --- > src/mm-iface-modem-oma.c | 87 > +--- > 1 file changed, 46 insertions(+), 41 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c > index

Re: [PATCH 2/3] iface-modem-oma: port mm_iface_modem_oma_enable to use GTask

On 29/06/17 06:43, Ben Chan wrote: > --- > src/mm-iface-modem-oma.c | 125 > ++- > 1 file changed, 59 insertions(+), 66 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c > index

Re: [PATCH 1/3] iface-modem-voice: port mm_iface_modem_voice_initialize to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-voice.c | 97 > -- > 1 file changed, 42 insertions(+), 55 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c > index

Re: [PATCH 2/3] iface-modem-voice: port mm_iface_modem_voice_enable to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-voice.c | 108 > - > 1 file changed, 49 insertions(+), 59 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c > index

Re: [PATCH 1/3] iface-modem-oma: port mm_iface_modem_oma_initialize to use GTask

On 29/06/17 06:43, Ben Chan wrote: > --- > src/mm-iface-modem-oma.c | 99 > +--- > 1 file changed, 43 insertions(+), 56 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-oma.c b/src/mm-iface-modem-oma.c > index

Re: [PATCH 3/3] iface-modem-voice: port mm_iface_modem_voice_disable to use GTask

On 29/06/17 06:44, Ben Chan wrote: > --- > src/mm-iface-modem-voice.c | 89 > -- > 1 file changed, 47 insertions(+), 42 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c > index

Re: [PATCH v2 1/1] telit: port mm-common-telit to use GTask

On 29/06/17 11:09, Daniele Palmas wrote: > --- > v2: address GTask cancellation issues highlighted by Aleksander > --- > plugins/telit/mm-common-telit.c | 65 > +++-- > 1 file changed, 30 insertions(+), 35 deletions(-) > Pushed to git master, thanks. > diff

Re: [PATCH 1/1] telit: port mm-common-telit to use GTask

Hey Daniele, See comments below. On 28/06/17 16:07, Daniele Palmas wrote: > --- > plugins/telit/mm-common-telit.c | 64 > +++-- > 1 file changed, 29 insertions(+), 35 deletions(-) > > diff --git a/plugins/telit/mm-common-telit.c

<    2   3   4   5   6   7   8   9   10   11   >